Null-dereference READ in gpu::Buffer::GetDataAddress |
||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=5257076044726272 Fuzzer: afl_gpu_fuzzer Job Type: afl_chrome_asan Platform Id: linux Crash Type: Null-dereference READ Crash Address: 0x000000000018 Crash State: gpu::Buffer::GetDataAddress AsAtomic gpu::ServiceDiscardableHandle::ForceDelete Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=473023:473070 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5257076044726272 Issue filed automatically. See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/838072e44f3a5d5856660d48837689d51eb18100 commit 838072e44f3a5d5856660d48837689d51eb18100 Author: Eric Karl <ericrk@chromium.org> Date: Tue Jun 06 17:23:43 2017 Fix null dereference due to corrupted cmd buffer command. Currently, passing a InitializeDiscardableTextureCHROMIUM command with an invalid shared memory ID can lead to a nullptr dereference. This change ensures that we only ever add entries to our discardable manager if both the texture and shared mem ID are valid. Bug: 725101 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I03b20d16376b42bbd3b9022aed69bcd1426e725a Reviewed-on: https://chromium-review.googlesource.com/523670 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#477315} [modify] https://crrev.com/838072e44f3a5d5856660d48837689d51eb18100/gpu/command_buffer/common/discardable_handle.cc [modify] https://crrev.com/838072e44f3a5d5856660d48837689d51eb18100/gpu/command_buffer/common/discardable_handle.h [modify] https://crrev.com/838072e44f3a5d5856660d48837689d51eb18100/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/838072e44f3a5d5856660d48837689d51eb18100/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
,
Jun 7 2017
ClusterFuzz has detected this issue as fixed in range 477283:477334. Detailed report: https://clusterfuzz.com/testcase?key=5257076044726272 Fuzzer: afl_gpu_fuzzer Job Type: afl_chrome_asan Platform Id: linux Crash Type: Null-dereference READ Crash Address: 0x000000000018 Crash State: gpu::Buffer::GetDataAddress AsAtomic gpu::ServiceDiscardableHandle::ForceDelete Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=473023:473070 Fixed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=477283:477334 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5257076044726272 See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Jun 7 2017
ClusterFuzz testcase 5257076044726272 is verified as fixed, so closing issue. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
||
►
Sign in to add a comment |
||
Comment 1 by msrchandra@chromium.org
, May 24 2017Components: Internals>GPU>Internals
Labels: M-60 Test-Predator-Correct-CLs
Owner: ericrk@chromium.org
Status: Assigned (was: Untriaged)