New issue
Advanced search Search tips

Issue 725091 link

Starred by 1 user
Status: Fixed
Owner:
fdoray@chromium.org
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

ClipboardUtilsTest.GetClipboardText has been failing on ClangToTLinuxUBSanVptr for a while

Project Member Reported by thakis@chromium.org, May 22 2017 
Started here: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxUBSanVptr%20tester/builds/1301

[ RUN      ] ClipboardUtilsTest.GetClipboardText
../../base/message_loop/message_loop.h:508:12: runtime error: downcast of address 0x2d559d32c1d0 which does not point to an object of type 'base::MessageLoopForUI'
0x2d559d32c1d0: note: object is of type 'base::MessageLoop'
 55 2d 00 00  58 cd 9c 18 00 00 00 00  c0 2d 4c 9d 55 2d 00 00  01 00 00 00 55 2d 00 00  40 7e 3f 9d
              ^~~~~~~~~~~~~~~~~~~~~~~
              vptr for 'base::MessageLoop'
    #0 0xb371a54  (/b/s/w/ir/out/Release/unit_tests+0xb371a54)
    #1 0xb370c33  (/b/s/w/ir/out/Release/unit_tests+0xb370c33)
    #2 0xb362ed3  (/b/s/w/ir/out/Release/unit_tests+0xb362ed3)
    #3 0xb366008  (/b/s/w/ir/out/Release/unit_tests+0xb366008)
    #4 0xe42b140  (/b/s/w/ir/out/Release/unit_tests+0xe42b140)
    #5 0x1fecb70  (/b/s/w/ir/out/Release/unit_tests+0x1fecb70)
    #6 0x9317870  (/b/s/w/ir/out/Release/unit_tests+0x9317870)
    #7 0x93199fd  (/b/s/w/ir/out/Release/unit_tests+0x93199fd)
    #8 0x931b302  (/b/s/w/ir/out/Release/unit_tests+0x931b302)
    #9 0x932d037  (/b/s/w/ir/out/Release/unit_tests+0x932d037)
    #10 0x932c02a  (/b/s/w/ir/out/Release/unit_tests+0x932c02a)
    #11 0x7e41d41  (/b/s/w/ir/out/Release/unit_tests+0x7e41d41)
    #12 0x7e45d63  (/b/s/w/ir/out/Release/unit_tests+0x7e45d63)
    #13 0x7e45bc8  (/b/s/w/ir/out/Release/unit_tests+0x7e45bc8)
    #14 0x7e31f4f  (/b/s/w/ir/out/Release/unit_tests+0x7e31f4f)
    #15 0x7f946e3cef44  (/lib/x86_64-linux-gnu/libc.so.6+0x21f44)
    #16 0x859c72  (/b/s/w/ir/out/Release/unit_tests+0x859c72)


Likely one of fdoray's change in that window. Please take a look!

Comment 1 by thakis@chromium.org, May 22 2017 

...and a whole bunch of more tests started failing in https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxUBSanVptr%20tester/builds/1315 a week later:

ClientSideDetectionHostTest.OnPhishingDetectionDoneVerdictNotPhishingButSBMatchOnSubresourceWhileNavPending
BookmarkContextMenuTest.MultipleFoldersWithURLs
ClientSideDetectionHostTest.OnPhishingDetectionDoneVerdictNotPhishingButSBMatchSubResource
BookmarkContextMenuTest.DisableIncognito
AppInfoDialogViewsTest.UninstallingAppClosesDialog
BookmarkContextMenuTest.SingleURL
BookmarkContextMenuTest.EmptyNodes
BookmarkContextMenuTest.MultipleEmptyFolders
AppInfoDialogViewsTest.DestroyedProfileClosesDialog
BookmarkContextMenuTest.SingleFolder
AppInfoDialogViewsTest.UninstallingOtherAppDoesNotCloseDialog
BookmarkContextMenuTest.DisabledItemsWithOtherNode
BrowserFeatureExtractorTest.MalwareFeatures
BookmarkContextMenuTest.MultipleURLs
AppInfoDialogViewsTest.DestroyedOtherProfileDoesNotCloseDialog
AppInfoDialogViewsTest.ViewInStore
BookmarkContextMenuTest.CutCopyPasteNode
BookmarkContextMenuTest.DeleteURL
ClipboardUtilsTest.GetClipboardText
BrowserFeatureExtractorTest.MalwareFeatures_ExceedLimit
ClientSideDetectionHostTest.OnPhishingDetectionDoneMultiplePings
ClientSideDetectionHostTest.OnPhishingDetectionDoneVerdictNotPhishingButSBMatchOnNewRVH
BookmarkContextMenuTest.ShowManagedBookmarks



Error looks virtually identical, probably caused by another fdoray message loop change. Let's use this bug for both issues.
Project Member

Comment 2 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dfa3e2c27b8254e156adf9a15f6d0ae261bf602

commit 7dfa3e2c27b8254e156adf9a15f6d0ae261bf602
Author: fdoray <fdoray@chromium.org>
Date: Wed May 24 13:59:22 2017

Add MessageLoopForUI to the ubsan vptr blacklist.

MessageLoopForUI has the same layout as it base class. This
is enforced by a static_assert in
base/message_loop/message_loop.h:

// Do not add any member variables to MessageLoopForUI!  This is important b/c
// MessageLoopForUI is often allocated via MessageLoop(TYPE_UI).  Any extra
// data that you need should be stored on the MessageLoop's pump_ instance.
static_assert(sizeof(MessageLoop) == sizeof(MessageLoopForUI),
              "MessageLoopForUI should not have extra member variables");

BUG= 725091 

Review-Url: https://codereview.chromium.org/2902733002
Cr-Commit-Position: refs/heads/master@{#474276}

[modify] https://crrev.com/7dfa3e2c27b8254e156adf9a15f6d0ae261bf602/tools/ubsan/vptr_blacklist.txt

Comment 3 by fdoray@chromium.org, May 24 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment