New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725082 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

PictureImageLayer in CV not working properly

Reported by sujith...@samsung.com, May 22 2017

Issue description

Steps to reproduce the problem:
If we create a PictureImageLayer in CV side, and try to display an image in it. Its not showing properly.
Also layer masking also not working if we do it in CV side.

What is the expected behavior?
Both Image display and masking should work properly.

What went wrong?
Issue happens due to ResourceProvider::GetImageTextureTarget returigit ng wrong GLenum. 
Since the buffer_to_texture_target_map_ is empty for browser process.
But for renderProcess it has proper values.

GLenum ResourceProvider::GetImageTextureTarget(gfx::BufferUsage usage,
                                               ResourceFormat format) {
  gfx::BufferFormat buffer_format = BufferFormat(format);
  auto found = buffer_to_texture_target_map_.find(
      BufferToTextureTargetKey(usage, buffer_format));
  DCHECK(found != buffer_to_texture_target_map_.end());
  return found->second;
}

Did this work before? N/A 

Chrome version: 56.0.2924.87  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 22.0 r0
 
Raised a patch to fix this
https://codereview.chromium.org/2895273002
Cc: aelias@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4b9cf2a67c8be392a878373d356a43ac4b3fe24

commit c4b9cf2a67c8be392a878373d356a43ac4b3fe24
Author: sujiths.s <sujiths.s@samsung.com>
Date: Fri Jul 07 04:32:13 2017

Unified the use of BufferToTextureTargetMap for all the Processes

Currently BufferToTextureTargetMap is generated seperately for
ui/renderer process. Now added forbrowser process as well and
unified the use of it.

BUG= 725082 

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2895273002
Cr-Commit-Position: refs/heads/master@{#484833}

[modify] https://crrev.com/c4b9cf2a67c8be392a878373d356a43ac4b3fe24/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/c4b9cf2a67c8be392a878373d356a43ac4b3fe24/content/browser/gpu/compositor_util.cc
[modify] https://crrev.com/c4b9cf2a67c8be392a878373d356a43ac4b3fe24/content/browser/gpu/compositor_util.h
[modify] https://crrev.com/c4b9cf2a67c8be392a878373d356a43ac4b3fe24/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/c4b9cf2a67c8be392a878373d356a43ac4b3fe24/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/c4b9cf2a67c8be392a878373d356a43ac4b3fe24/ui/aura/mus/mus_context_factory.cc
[modify] https://crrev.com/c4b9cf2a67c8be392a878373d356a43ac4b3fe24/ui/compositor/compositor_util.cc
[modify] https://crrev.com/c4b9cf2a67c8be392a878373d356a43ac4b3fe24/ui/compositor/compositor_util.h

Status: Fixed (was: Unconfirmed)
Closing for now, please reopen if more work is needed.

Sign in to add a comment