New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725066 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 725065

Blocking:
issue 709301



Sign in to add a comment

Migrate components/autofill/content/browser/risk to consume geolocation via GeolocationService

Project Member Reported by blundell@chromium.org, May 22 2017

Issue description

It adds itself as a listener for location update callbacks. This shouldn't be hard to switch to the Mojo service, since it's async to start with.
 
Components: Blink>Location
Labels: DeviceService OS-All
Status: Available (was: Untriaged)
Blocking: 709301
Blockedon: 725065
Cc: amoylan@chromium.org
Components: Blink>Geolocation
Components: -Blink>Location
Components: Internals>Services>Device

Comment 8 by ke...@intel.com, Nov 15 2017

Cc: blundell@chromium.org
Owner: ke...@intel.com
I start to work on this issue since I didn't find any blocker on it.
Now the geolocation_context.mojom is already hosted by device service, geolocation_context owns the geolocation_impl.
So the risk/fingerprint can be converted as customer of geolocation_context. Note that fingerprint just wants to get the geo-position only once, so it don't need to setclient to geolocation-core, just call the QueryNextPosition() of geolocation.mojom is ok.

Comment 9 by ke...@intel.com, Nov 15 2017

Status: Started (was: Available)

Comment 10 by ke...@intel.com, Nov 15 2017

If my above understanding is correct, the 725065 is not really a blocker.
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aef0ac75e8be45fc95fdcae4562e115ce8d9b1cc

commit aef0ac75e8be45fc95fdcae4562e115ce8d9b1cc
Author: Ke He <ke.he@intel.com>
Date: Tue Nov 21 03:40:26 2017

Migrate components/autofill/content/browser/risk to consume geolocation via mojo

All clients of geolocation-core should be converted to consume via mojo.
Accordingly, in browsertest it shouldn't call the
OverrideLocationForTesting() either, instead, we use the
Connector::TestApi::OverrideBinderForTesting().

BUG= 725066 

Change-Id: I1cdeae60a3a08336a5ca12b044941d8347992dd7
Reviewed-on: https://chromium-review.googlesource.com/771380
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#518094}
[modify] https://crrev.com/aef0ac75e8be45fc95fdcae4562e115ce8d9b1cc/chrome/browser/autofill/risk_util.cc
[modify] https://crrev.com/aef0ac75e8be45fc95fdcae4562e115ce8d9b1cc/components/BUILD.gn
[modify] https://crrev.com/aef0ac75e8be45fc95fdcae4562e115ce8d9b1cc/components/autofill/content/browser/BUILD.gn
[modify] https://crrev.com/aef0ac75e8be45fc95fdcae4562e115ce8d9b1cc/components/autofill/content/browser/DEPS
[modify] https://crrev.com/aef0ac75e8be45fc95fdcae4562e115ce8d9b1cc/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/aef0ac75e8be45fc95fdcae4562e115ce8d9b1cc/components/autofill/content/browser/risk/fingerprint.h
[modify] https://crrev.com/aef0ac75e8be45fc95fdcae4562e115ce8d9b1cc/components/autofill/content/browser/risk/fingerprint_browsertest.cc

Comment 12 by ke...@intel.com, Nov 22 2017

Status: Fixed (was: Started)

Sign in to add a comment