Migrate geolocation interfaces from being hosted by //content/browser to being hosted by the Device Service |
|||||||||
Issue description- Have the Device Service constructor take in the callback that produces the geolocation URLRequestContextGetter - Change the callsites of GeolocationManager::SetClient() to call via Mojo rather than C++
,
May 22 2017
,
May 22 2017
,
Jun 2 2017
,
Sep 22 2017
,
Sep 22 2017
,
Nov 7 2017
,
Dec 20 2017
The geolocation_config mojo interface implemenation is hosted in //content/browser/service_manager/common_browser_interfaces.cc, it should be moved to be hosted by device service.
,
Dec 20 2017
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95e51a93db90cddbc7ba0e3b81af13ea1a9d4c81 commit 95e51a93db90cddbc7ba0e3b81af13ea1a9d4c81 Author: Ke He <ke.he@intel.com> Date: Tue Jan 09 03:28:33 2018 Migrate geolocation_config interface to be hosted by Device Service. Migrate geolocation_config interface to be hosted by Device Service, to make Geolocation-core be decoupled from //content. So we can move the Geolocation-core into //services/device and make it an internal implementation in next step. BUG= 725065 Change-Id: I98d803f9bf83689d6bce71f93108619aa9414390 Reviewed-on: https://chromium-review.googlesource.com/835659 Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#527891} [modify] https://crrev.com/95e51a93db90cddbc7ba0e3b81af13ea1a9d4c81/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/95e51a93db90cddbc7ba0e3b81af13ea1a9d4c81/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/95e51a93db90cddbc7ba0e3b81af13ea1a9d4c81/content/browser/service_manager/common_browser_interfaces.cc [modify] https://crrev.com/95e51a93db90cddbc7ba0e3b81af13ea1a9d4c81/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/95e51a93db90cddbc7ba0e3b81af13ea1a9d4c81/device/geolocation/geolocation_config.cc [modify] https://crrev.com/95e51a93db90cddbc7ba0e3b81af13ea1a9d4c81/device/geolocation/geolocation_config.h [modify] https://crrev.com/95e51a93db90cddbc7ba0e3b81af13ea1a9d4c81/services/device/device_service.cc [modify] https://crrev.com/95e51a93db90cddbc7ba0e3b81af13ea1a9d4c81/services/device/device_service.h [modify] https://crrev.com/95e51a93db90cddbc7ba0e3b81af13ea1a9d4c81/services/device/manifest.json
,
Jan 10 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by blundell@chromium.org
, May 22 2017Labels: DeviceService OS-All
Status: Available (was: Untriaged)