New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725061 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Avoid sending RenderWidget::DidReceiveCompositorFrameAck unnecessarily

Project Member Reported by skyos...@chromium.org, May 22 2017

Issue description

It seems like RenderWidget::DidReceiveCompositorFrameAck gets sent to the renderer every frame, but it's not clear whether it does anything useful most of the time (i.e., when we're not resizing/force-repainting the view). We should avoid sending this message unnecessarily.

I found this in the M60 trace from https://docs.google.com/document/d/1Ij2U31v3jq7X-4wx6Wtjan6c5GgNJUsZE6GRJZvISK0/edit#
 

Comment 1 by shrike@chromium.org, May 22 2017

Labels: Performance-Power
Is this an IPC message or something happening solely within the renderer? If it's an IPC message that we could remove it would be great to prioritize its removal.
It's is triggered by an IPC message from the browser, but I don't know if we can remove the entire message or just the cc=>main thread hop (which is almost as expensive as an IPC)
Project Member

Comment 3 by sheriffbot@chromium.org, May 23 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Still there.
Labels: -Pri-3 Pri-2
Owner: ksolt@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d60b40e28c03273690c45f70e6fd9a53f8449f4

commit 4d60b40e28c03273690c45f70e6fd9a53f8449f4
Author: Karolina Soltys <ksolt@chromium.org>
Date: Mon Oct 01 19:28:20 2018

Removed several levels of calls to RenderWidget::DidReceiveCompositorFrameAck.

Bug:  725061 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9bec1e76635379dd7a09a5160e1dff69074692f9
Reviewed-on: https://chromium-review.googlesource.com/1183232
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Karolina Soltys <ksolt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595498}
[modify] https://crrev.com/4d60b40e28c03273690c45f70e6fd9a53f8449f4/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/4d60b40e28c03273690c45f70e6fd9a53f8449f4/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/4d60b40e28c03273690c45f70e6fd9a53f8449f4/cc/trees/proxy_impl.cc
[modify] https://crrev.com/4d60b40e28c03273690c45f70e6fd9a53f8449f4/cc/trees/proxy_impl.h
[modify] https://crrev.com/4d60b40e28c03273690c45f70e6fd9a53f8449f4/cc/trees/single_thread_proxy.cc
[modify] https://crrev.com/4d60b40e28c03273690c45f70e6fd9a53f8449f4/content/renderer/gpu/layer_tree_view.cc
[modify] https://crrev.com/4d60b40e28c03273690c45f70e6fd9a53f8449f4/content/renderer/gpu/layer_tree_view.h
[modify] https://crrev.com/4d60b40e28c03273690c45f70e6fd9a53f8449f4/content/renderer/gpu/layer_tree_view_delegate.h
[modify] https://crrev.com/4d60b40e28c03273690c45f70e6fd9a53f8449f4/content/renderer/render_widget.cc
[modify] https://crrev.com/4d60b40e28c03273690c45f70e6fd9a53f8449f4/content/renderer/render_widget.h
[modify] https://crrev.com/4d60b40e28c03273690c45f70e6fd9a53f8449f4/content/test/stub_layer_tree_view_delegate.h

Status: Fixed (was: Assigned)

Sign in to add a comment