New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 725041 link

Starred by 2 users
Status: Duplicate
Merged: issue 724920
Owner:
wangxianzhu@chromium.org
Closed: May 2017
Cc:
ajha@chromium.org
█ manoranj...@chromium.org
█ kavvaru@chromium.org
█ bustamante@chromium.org
█ brajkumar@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 724263



Sign in to add a comment

Regression: Content is seen missing in google search results page

Project Member Reported by sc00335...@techmahindra.com, May 22 2017 
Chrome Version: 60.0.3107.0 dev
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome and search for anything or go to https://www.google.co.in/search?q=debugging+in+testing&oq=DEBUGGING+IN+TEST&aqs=chrome.1.69i57j0l5.6759j0j4&sourceid=chrome&ie=UTF-8
(2)Expand any item from People also ask section and observe content

Expected: Content should be fully seen.
Actual: Instead some content is seen missing.

This is a regression issue broken in M60.

Good Build: 60.0.3104.0 dev
Bad Build: 60.0.3105.0 dev
Expected_search result.png
196 KB View Download
Actual_search result.png
177 KB View Download

Comment 1 by sandeepkumars@chromium.org, May 22 2017

Labels: hasbisect-per-revision ReleaseBlock-Dev
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,

Good Build: 60.0.3104.0 (Revision: 473014)
Bad Build: 60.0.3105.0 (Revision: 473393)
 
You are probably looking for a change made after 473370 (known good), but no later than 473371 (first known bad).

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/d00385ad4d2d12bf0aede04cbe08ae4122148ed7..3c7f1c4ecd1421d074daa5a103ea3f895c1c8724

@wangxianzhu: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review URL: https://codereview.chromium.org/2894093002

Thank You.

Able to reproduce the issue on Mac 10.12.4 using latest Canary #60.0.3017.0 as well. Hence adding the Release Block Dev, undo if not the case.

Comment 2 by sandeepkumars@chromium.org, May 22 2017

Labels: -Needs-Bisect -ReleaseBlock-Stable

Comment 3 by ajha@chromium.org, May 22 2017

Cc: manoranj...@chromium.org bustamante@chromium.org

Comment 4 by schenney@chromium.org, May 22 2017

Labels: BugSource-Chromium PaintTeamTriaged-20170522

Comment 5 by wangxianzhu@chromium.org, May 22 2017

Mergedinto: 724920
Status: Duplicate (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, May 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86c54d1018d43154254a9b479f43621bd8f6cad6

commit 86c54d1018d43154254a9b479f43621bd8f6cad6
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Mon May 22 18:49:59 2017

Revert of Don't access DisplayItemClient::VisualRect() for cached display items. (patchset #3 id:40001 of https://codereview.chromium.org/2894093002/ )

Reason for revert:
BUG= 724920 ,724263, 725041 , 724936 

Original issue's description:
> Don't access DisplayItemClient::VisualRect() for cached display items.
>
> - Access DisplayItemClient::VisualRect() when a new DisplayItem is
>   created, and save it in the new DisplayItem.
> - When a cached display item is copied, don't access DisplayItemClient::
>   VisualRect() but fetch from the cached DisplayItem.
> - Remove DisplayItemList::visual_rects_.
> - Save original visual rects (LayoutRect) and apply GraphicsLayer offset
>   with EnclosingIntRect() when the display items are added into
>   WebDisplayItemList.
>
> Please see the bug for the reason.
>
> BUG=724263
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2894093002
> Cr-Commit-Position: refs/heads/master@{#473371}
> Committed: https://chromium.googlesource.com/chromium/src/+/3c7f1c4ecd1421d074daa5a103ea3f895c1c8724

TBR=chrishtr@chromium.org,wkorman@chromium.org,pdr@chromium.org,michaelpg@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=724263

Review-Url: https://codereview.chromium.org/2899793002
Cr-Commit-Position: refs/heads/master@{#473640}

[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h
[add] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
[delete] https://crrev.com/cabeb0d9ab1b39fc25a1647d38afade5bea2e70e/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItemTest.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.h

Comment 7 by manoranj...@chromium.org, May 23 2017 

wangxianzhu@, Thank you for the revert. I would like to consider this revert to 3107 branch for this week's Chrome Dev release, so can you please merge it to 3107 ASAP?

PS: You do not need any 'Merge-Approval' process, since 3107 is yet to be branched officially.
Project Member

Comment 8 by bugdroid1@chromium.org, May 23 2017

Labels: merge-merged-3107
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/238659de163326395f9628bfc9cac04b55678f88

commit 238659de163326395f9628bfc9cac04b55678f88
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Tue May 23 00:15:31 2017

Revert of Don't access DisplayItemClient::VisualRect() for cached display items. (patchset #3 id:40001 of https://codereview.chromium.org/2894093002/ )

Reason for revert:
BUG= 724920 ,724263, 725041 , 724936 

Original issue's description:
> Don't access DisplayItemClient::VisualRect() for cached display items.
>
> - Access DisplayItemClient::VisualRect() when a new DisplayItem is
>   created, and save it in the new DisplayItem.
> - When a cached display item is copied, don't access DisplayItemClient::
>   VisualRect() but fetch from the cached DisplayItem.
> - Remove DisplayItemList::visual_rects_.
> - Save original visual rects (LayoutRect) and apply GraphicsLayer offset
>   with EnclosingIntRect() when the display items are added into
>   WebDisplayItemList.
>
> Please see the bug for the reason.
>
> BUG=724263
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2894093002
> Cr-Commit-Position: refs/heads/master@{#473371}
> Committed: https://chromium.googlesource.com/chromium/src/+/3c7f1c4ecd1421d074daa5a103ea3f895c1c8724

TBR=chrishtr@chromium.org,wkorman@chromium.org,pdr@chromium.org,michaelpg@chromium.org
BUG=724263
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2899793002
Cr-Original-Commit-Position: refs/heads/master@{#473640}
Review-Url: https://codereview.chromium.org/2897943004
Cr-Commit-Position: refs/branch-heads/3107@{#4}
Cr-Branched-From: 0461d19b57461980dde77a7f4f5e5c3c80d4dc4b-refs/heads/master@{#473482}

[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h
[add] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
[delete] https://crrev.com/700a4414d338475949c04337cad6aec760d2c53d/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItemTest.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.h

Comment 9 by sandeepkumars@chromium.org, May 23 2017

Labels: TE-Verified-60.0.3107.4 TE-Verified-60
Verified this issue on Win 10, Mac 10.12.4, Ubuntu 14.04 using chrome latest dev M60 #60.0.3107.4 by following steps mentioned in the original comment. 

Observed the page is loading with full content while expanding the People also ask section. Hence adding the TE- Verified label

Please refer the screen cast

Thanks,
May 23 2017 11-29 AM.webm
4.3 MB View Download

Comment 10 by wangxianzhu@chromium.org, May 23 2017

Blocking: 724263
►

Sign in to add a comment