UI glitch with sign-in promo in bookmarks |
|||
Issue descriptionWith a cold state, click on Sign in button, enter a valid account/password, and then click on "UNDO". Expected UI: https://drive.google.com/open?id=0ByXziH_JVCGJWkhCSER3T1dtVjg Result UI: https://drive.google.com/open?id=0ByXziH_JVCGJSkZTbnJ5SS1IN3c
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50dd2bde25f729081248de4c835d1ef99c695754 commit 50dd2bde25f729081248de4c835d1ef99c695754 Author: jlebel <jlebel@chromium.org> Date: Tue May 23 12:37:28 2017 Fixing glitch about Sign-in promo height in bookmarks -[BookmarkFolderCollectionView cellSizeForIndexPath:] can use the current cell to compute its height when reloading. So when BookmarkFolderCollectionView receives the notification to update the SigninPromoView, the view has to be updated even if the section is reloaded. BUG= 725040 Review-Url: https://codereview.chromium.org/2895173003 Cr-Commit-Position: refs/heads/master@{#473868} [modify] https://crrev.com/50dd2bde25f729081248de4c835d1ef99c695754/ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm
,
May 24 2017
,
Jun 16 2017
Verified on 61.0.3128.0 Canary on iOs 11.0 Beta on iPad mini. https://drive.google.com/open?id=0B6GVWQnhaMClZDEyWUJMcllFWFk |
|||
►
Sign in to add a comment |
|||
Comment 1 by jlebel@chromium.org
, May 22 2017