Issue metadata
Sign in to add a comment
|
Regression: Spacing is seen missing between iron icon & 'change channel' button in chrome://md-settings/help/details page. |
||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3105.0/9574.0.0 dev-channel Daisy,Candy,Minnie OS: Chrome OS What steps will reproduce the problem? (1)Sign in as second user or Browse as guest >> Go to chrome://md-settings/help/details page and Observe iron icon & 'change channel' button Expected: Proper spacing should be seen between iron icon & 'change channel' button. Actual: Instead, no space is seen. This is regression issue as space is seen in 60.0.3102.0/9565.0.0 dev channel Daisy Attached screen shots for reference.
,
May 22 2017
,
May 25 2017
,
Jun 2 2017
I believe that we put the controlledBy icon before the control if the control is on the end of the line. like: RowLabel <icon> [Button] Is this the only case where the controlledBy icon is at the end of the row (if so, should we consider changing that -- which may also fix this issue reported in this bug).
,
Jun 2 2017
See also issue 681901; we should reconsider the ordering when we update the UI.
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a23aa8aa9ae6a45f59deb0a5b3d9938630f9171e commit a23aa8aa9ae6a45f59deb0a5b3d9938630f9171e Author: stevenjb <stevenjb@chromium.org> Date: Mon Jun 05 17:51:27 2017 Settings > About > Details: Fix policy indicator spacing BUG= 725035 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2916323003 Cr-Commit-Position: refs/heads/master@{#477017} [modify] https://crrev.com/a23aa8aa9ae6a45f59deb0a5b3d9938630f9171e/chrome/browser/resources/settings/about_page/detailed_build_info.html
,
Jun 12 2017
,
Jun 23 2017
9678.0.0, 61.0.3138.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, May 22 2017