New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724944 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: Lengthy Address in auto-fill settings is overlapping with 3 Dot menu focus

Project Member Reported by divya.pa...@techmahindra.com, May 22 2017

Issue description

Chrome Version: 60.0.3107.0
OS: Ubuntu 14.04, Win 7

What steps will reproduce the problem?
(1)Launch chrome and go to chrome://settings, Change the font size to very large
(2)Go to auto-fill settings, enter lengthy name eg:(Abcd auto fill organisation name) and street address eg: (abcd auto fill street address details in addresses) in the addresses field and observe the focus


Expected 
Text in addresses field should not overlap with 3 dot menu focus

Actual
Text in addresses field is overlapping with 3 dot menu focus


This is a Regression issue seen in M-60
========================
Manual Bisect Info:

Good Build: 60.0.3103.0 
Bad Build: 60.0.3104.0

 
Expected. Autofill2.ogv
4.9 MB View Download
Actual.Autofill.ogv
2.6 MB View Download

Comment 2 by ajha@chromium.org, May 22 2017

Components: UI>Settings
Labels: -Type-Bug -Pri-3 Proj-MaterialDesign-WebUI Needs-Bisect M-60 OS-Mac Pri-2 Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)
Looks like actual and expected videos are uploaded incorrectly. However, I am able to see the similar behavior on Linux Ubuntu 14.04, chrome version: 60.0.3107.0.
Cc: jmukthavaram@chromium.org
Labels: -Pri-2 -Needs-Bisect hasbisect Pri-1
Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce this issue on windows 7,Mac 10.12.4 ,Linux Ubuntu 14.04 with Chrome Canary-60.0.3104.0
Manual Bisect:
-------------
Good Build: 60.0.3103.0 -Revision-472587
Bad Build: 60.0.3104.0 -Revision-473014

Bisect Tool Info: (With Old script as new script has the issue)
----------------
You are probably looking for a change made after 472963 (known good), but no later than 472976 (first known bad).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/2708a58f9e5004527b4909e9f03d3df8aa06d633..8a14c40573ecd9fbf68ac4c4d97b9e4c9f504a6d

Possible Suspect:
-----------------
https://chromium.googlesource.com/chromium/src/+/8a14c40573ecd9fbf68ac4c4d97b9e4c9f504a6d

dschuyler@,Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change.

Thanks.!

Comment 4 by dbeam@chromium.org, May 22 2017

Labels: -Pri-1 Hotlist-MD-Settings-PasswordsForms Pri-3
I suggest landing https://codereview.chromium.org/2848973003/ prior to addressing this.
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e959cddaeca101036a8edf445a5d57c629632afc

commit e959cddaeca101036a8edf445a5d57c629632afc
Author: dschuyler <dschuyler@chromium.org>
Date: Wed May 31 22:31:27 2017

[MD settings] adjust button layout

This CL gives proper spacing of paper-buttons in settings boxes. There are several cases to consider: a button at the start of a row; a button at the end of the row; multiple buttons in a row; buttons before or after a separator.

BUG= 725172 ,  726262 ,  724944 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2902363002
Cr-Commit-Position: refs/heads/master@{#476067}

[modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/chrome/browser/resources/settings/controls/controlled_button.html
[modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
[modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html
[modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/ui/webui/resources/cr_elements/shared_style_css.html
[modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/ui/webui/resources/cr_elements/shared_vars_css.html

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 7 2017

Labels: merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c366c9166c518e396d66db4edf2a7f0dba12e7f0

commit c366c9166c518e396d66db4edf2a7f0dba12e7f0
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Wed Jun 07 21:03:17 2017

[MD settings] adjust button layout

This CL gives proper spacing of paper-buttons in settings boxes. There are several cases to consider: a button at the start of a row; a button at the end of the row; multiple buttons in a row; buttons before or after a separator.

BUG= 725172 ,  726262 ,  724944 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2902363002
Cr-Original-Commit-Position: refs/heads/master@{#476067}
Review-Url: https://codereview.chromium.org/2931723002 .
Cr-Commit-Position: refs/branch-heads/3112@{#235}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/chrome/browser/resources/settings/controls/controlled_button.html
[modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
[modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html
[modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/ui/webui/resources/cr_elements/shared_style_css.html
[modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/ui/webui/resources/cr_elements/shared_vars_css.html

Labels: TE-Verified-M60 TE-Verified-60.0.3112.24
Tested the issue on Windows-10, Ubuntu 14.04 and Mac OS 10.12.5 using chrome latest Beta M60-60.0.3112.24 by following steps mentioned in the original comment. Observed that 3 dot menu focus is displaying as expected. Hence adding TE-Verified label.

Please find the screen shot for reference.

Thank you!
724944.png
128 KB View Download

Sign in to add a comment