New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 724936 link

Starred by 2 users
Status: Duplicate
Merged: issue 724920
Owner:
wangxianzhu@chromium.org
Closed: May 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 724263



Sign in to add a comment

Regression: Buttons are seen blank on chrome://extensions

Reported by aiman.an...@etouch.net, May 22 2017 
Chrome Version: 60.0.3107.0 (Official Build)(cohort: Stable)0461d19b57461980dde77a7f4f5e5c3c80d4dc4b-refs/heads/master@{#473482}(32/64-bit).

OS: Windows(7,8,8.1), Linux(14.04 LTS), Mac(10.11.6, 10.12.1, 10.12).

Steps to reproduce:
1.Launch Chrome, go to chrome://extensions, select checkbox for Developer Mode
2. Observe.

Actual Result: Buttons are seen blank.
Expected Result: Buttons should not be blank.

This is Regression issue broken in M-60,  will soon update other info.

Manual Bisect:
Good Build: 60.0.3104.0
Bad Build: 60.0.3105.0
Actual Result.mp4
576 KB View Download
Expected Result.mp4
573 KB View Download

Comment 1 by rbasuvula@chromium.org, May 22 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:60.0.3104.0 (Revision:473014).
Bad build:60.0.3105.0 (Revision:473393).

You are probably looking for a change made after 473370 (known good), but no later than 473371 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/d00385ad4d2d12bf0aede04cbe08ae4122148ed7..3c7f1c4ecd1421d074daa5a103ea3f895c1c8724

From the CL above, assigning the issue to the concern owner

@wangxianzhu: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2894093002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #60.0.3105.0
Adding Release Block-Stable for this issue.Please remove if not the case.

Comment 2 by wangxianzhu@chromium.org, May 22 2017

Mergedinto: 724920
Status: Duplicate (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86c54d1018d43154254a9b479f43621bd8f6cad6

commit 86c54d1018d43154254a9b479f43621bd8f6cad6
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Mon May 22 18:49:59 2017

Revert of Don't access DisplayItemClient::VisualRect() for cached display items. (patchset #3 id:40001 of https://codereview.chromium.org/2894093002/ )

Reason for revert:
BUG= 724920 ,724263, 725041 , 724936 

Original issue's description:
> Don't access DisplayItemClient::VisualRect() for cached display items.
>
> - Access DisplayItemClient::VisualRect() when a new DisplayItem is
>   created, and save it in the new DisplayItem.
> - When a cached display item is copied, don't access DisplayItemClient::
>   VisualRect() but fetch from the cached DisplayItem.
> - Remove DisplayItemList::visual_rects_.
> - Save original visual rects (LayoutRect) and apply GraphicsLayer offset
>   with EnclosingIntRect() when the display items are added into
>   WebDisplayItemList.
>
> Please see the bug for the reason.
>
> BUG=724263
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2894093002
> Cr-Commit-Position: refs/heads/master@{#473371}
> Committed: https://chromium.googlesource.com/chromium/src/+/3c7f1c4ecd1421d074daa5a103ea3f895c1c8724

TBR=chrishtr@chromium.org,wkorman@chromium.org,pdr@chromium.org,michaelpg@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=724263

Review-Url: https://codereview.chromium.org/2899793002
Cr-Commit-Position: refs/heads/master@{#473640}

[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h
[add] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
[delete] https://crrev.com/cabeb0d9ab1b39fc25a1647d38afade5bea2e70e/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItemTest.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.cpp
[modify] https://crrev.com/86c54d1018d43154254a9b479f43621bd8f6cad6/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.h
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2017

Labels: merge-merged-3107
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/238659de163326395f9628bfc9cac04b55678f88

commit 238659de163326395f9628bfc9cac04b55678f88
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Tue May 23 00:15:31 2017

Revert of Don't access DisplayItemClient::VisualRect() for cached display items. (patchset #3 id:40001 of https://codereview.chromium.org/2894093002/ )

Reason for revert:
BUG= 724920 ,724263, 725041 , 724936 

Original issue's description:
> Don't access DisplayItemClient::VisualRect() for cached display items.
>
> - Access DisplayItemClient::VisualRect() when a new DisplayItem is
>   created, and save it in the new DisplayItem.
> - When a cached display item is copied, don't access DisplayItemClient::
>   VisualRect() but fetch from the cached DisplayItem.
> - Remove DisplayItemList::visual_rects_.
> - Save original visual rects (LayoutRect) and apply GraphicsLayer offset
>   with EnclosingIntRect() when the display items are added into
>   WebDisplayItemList.
>
> Please see the bug for the reason.
>
> BUG=724263
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2894093002
> Cr-Commit-Position: refs/heads/master@{#473371}
> Committed: https://chromium.googlesource.com/chromium/src/+/3c7f1c4ecd1421d074daa5a103ea3f895c1c8724

TBR=chrishtr@chromium.org,wkorman@chromium.org,pdr@chromium.org,michaelpg@chromium.org
BUG=724263
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2899793002
Cr-Original-Commit-Position: refs/heads/master@{#473640}
Review-Url: https://codereview.chromium.org/2897943004
Cr-Commit-Position: refs/branch-heads/3107@{#4}
Cr-Branched-From: 0461d19b57461980dde77a7f4f5e5c3c80d4dc4b-refs/heads/master@{#473482}

[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h
[add] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
[delete] https://crrev.com/700a4414d338475949c04337cad6aec760d2c53d/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItemTest.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.cpp
[modify] https://crrev.com/238659de163326395f9628bfc9cac04b55678f88/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.h

Comment 5 by sandeepkumars@chromium.org, May 23 2017

Labels: TE-Verified-60.0.3107.4 TE-Verified-60
Verified this issue on Win 10, Mac 10.12.4, Ubuntu 14.04 using chrome latest dev M60 #60.0.3107.4 by following steps mentioned in the original comment. 

Observed the text on the buttons. Hence adding the TE- Verified label

Please refer the screen cast

Thanks,
May 23 2017 1-37 PM.webm
1.6 MB View Download

Comment 6 by wangxianzhu@chromium.org, May 23 2017

Blocking: 724263
►

Sign in to add a comment