Preemptively load virtual keyboard to improve start up latency. |
|||||||
Issue descriptionProposal: Load virtual keyboard on one of the following conditions: - tablet mode is enabled - accessibility keyboard is enabled - session is changed when tablet mode or accessibilily keyboard is on
,
Jun 5 2017
,
Jun 5 2017
After adding trace markers, I can see that pretty much the entire loading time is spent in JS execution.
,
Jun 9 2017
Thank you for your investigation. Can you measure how much time would be saved by preemptive load: (time for keyboard to appear on the first time) - (the second time) ?
,
Jun 9 2017
FYI: I wrote a change to add state diagram explicitly and will submit it soon. https://chromium-review.googlesource.com/c/516866/ Hope it helps. (Design doc: https://docs.google.com/document/d/1f8h6SNIx7szzzVg9d_Wog6eR6ZF1Jo4zHDPfC2s0UOE/edit#heading=h.vqdn9okkt4o5) The idea of preemptive load is to initiate INITIAL -> LOADING_EXTENSION -> HIDDEN transition whenever (1) the state is INITIAL and (2) keyboard::IsKeybaordEnabled becomes true.
,
Jun 12 2017
,
Jun 29 2017
,
Jul 3 2017
Here's a video of the new changes: https://drive.google.com/file/d/0ByiCx2FXM7kMa20xQ0NxMkt2YWM/view
,
Jul 3 2017
Oops, looks like it's not committed yet.
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9917f026d85f1881f70d4a74fac74c91579fac6 commit d9917f026d85f1881f70d4a74fac74c91579fac6 Author: Blake O'Hare <blakeo@chromium.org> Date: Tue Jul 11 05:44:49 2017 Pre-load the keyboard extension when the keyboard controller is activated This will initialize loading the keyboard extension when the RootWindowController calls ActivateKeyboard. Bug: 724908 Change-Id: I3af07338dd3e619f9ae6d85e0f191890d0cd5a67 Reviewed-on: https://chromium-review.googlesource.com/547921 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Keigo Oka <oka@chromium.org> Cr-Commit-Position: refs/heads/master@{#485532} [modify] https://crrev.com/d9917f026d85f1881f70d4a74fac74c91579fac6/ash/root_window_controller.cc [modify] https://crrev.com/d9917f026d85f1881f70d4a74fac74c91579fac6/ash/root_window_controller_unittest.cc [modify] https://crrev.com/d9917f026d85f1881f70d4a74fac74c91579fac6/ash/wm/always_on_top_controller_unittest.cc [modify] https://crrev.com/d9917f026d85f1881f70d4a74fac74c91579fac6/chrome/browser/ui/ash/keyboard_controller_browsertest.cc [modify] https://crrev.com/d9917f026d85f1881f70d4a74fac74c91579fac6/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/d9917f026d85f1881f70d4a74fac74c91579fac6/ui/keyboard/keyboard_controller.h [modify] https://crrev.com/d9917f026d85f1881f70d4a74fac74c91579fac6/ui/keyboard/keyboard_layout_manager.cc
,
Jul 11 2017
Thank you for making the change. Let's see how FirstLoad UMA improves. https://uma.googleplex.com/p//timeline_v2/?sid=35fdf26fa16dc10197a393e7a4acb187
,
Jul 11 2017
Will this process be killed when transitioning from tablet to clamshell?
,
Jul 20 2017
should be closed right?
,
Jul 20 2017
Yes.
,
Aug 10 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by oka@chromium.org
, May 22 2017