New issue
Advanced search Search tips

Issue 724907 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Compat

Blocked on:
issue 719303

Blocking:
issue 567358



Sign in to add a comment

Upstream http/tests/worklet to WPT

Project Member Reported by nhiroki@chromium.org, May 22 2017

Issue description

http/tests/worklet contains tests for the Worklet Level 1 specification:
https://drafts.css-houdini.org/worklets/

These should be upstreamed to the WPT repository.
 
Blockedon: 719303
Blocking: 567358
Why is this blocked on  issue 71903 ?

Can't the WPT tests just track the current spec and change if the spec changes? 

Comment 4 Deleted

Oops  issue 719303 .
Re c#3, this is because our current impl and layout tests are not in conformance with the current spec, too.

Implementing the current spec needs changes in our bindings layer and implementing the new spec also needs different changes in the bindings layer, so I want to wait until the spec discussion is settled.
Status: Started (was: Assigned)
Cc: flackr@chromium.org xidac...@chromium.org ikilpatrick@chromium.org
 Issue 768389  has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b03a253cd3778652b4e3983c2424786ff642942c

commit b03a253cd3778652b4e3983c2424786ff642942c
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Sep 28 00:48:01 2017

Worklet: Upstream http/tests/worklet to WPT

This CL upstreams http/tests/worklet to external/wpt/worklets on the WPT
repository.

Bug:  724907 
Change-Id: I0928ea9bd7f615b84cf138a8682816c68a779ed5
Reviewed-on: https://chromium-review.googlesource.com/683714
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504833}
[add] https://crrev.com/b03a253cd3778652b4e3983c2424786ff642942c/third_party/WebKit/LayoutTests/external/wpt/worklets/OWNERS
[add] https://crrev.com/b03a253cd3778652b4e3983c2424786ff642942c/third_party/WebKit/LayoutTests/external/wpt/worklets/README.md
[rename] https://crrev.com/b03a253cd3778652b4e3983c2424786ff642942c/third_party/WebKit/LayoutTests/external/wpt/worklets/animation-worklet-import.html
[add] https://crrev.com/b03a253cd3778652b4e3983c2424786ff642942c/third_party/WebKit/LayoutTests/external/wpt/worklets/paint-worklet-import.html
[rename] https://crrev.com/b03a253cd3778652b4e3983c2424786ff642942c/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/empty-worklet-script.js
[rename] https://crrev.com/b03a253cd3778652b4e3983c2424786ff642942c/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-cyclic-worklet-script.js
[rename] https://crrev.com/b03a253cd3778652b4e3983c2424786ff642942c/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-nested-internal-worklet-script.js
[rename] https://crrev.com/b03a253cd3778652b4e3983c2424786ff642942c/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-nested-worklet-script.js
[rename] https://crrev.com/b03a253cd3778652b4e3983c2424786ff642942c/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-tests.js
[rename] https://crrev.com/b03a253cd3778652b4e3983c2424786ff642942c/third_party/WebKit/LayoutTests/external/wpt/worklets/resources/throwing-worklet-script.js
[delete] https://crrev.com/08ac8e55a0db2ca91d1a835d7edb8058def1f399/third_party/WebKit/LayoutTests/http/tests/worklet/paint-worklet-import.html

Labels: M-63
Status: Fixed (was: Started)

Sign in to add a comment