New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 724906 link

Starred by 7 users
Status: Fixed
Owner:
tkent@chromium.org
Closed: Jun 2017
Cc:
█ dominicc@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 725414



Sign in to add a comment

Implement DOMTokenList.replace()

Project Member Reported by tkent@chromium.org, May 22 2017 
Chrome Version: 60 canary
OS: All but iOS

What steps will reproduce the problem?
(1) Open http://w3c-test.org/dom/nodes/Element-classlist.html

What is the expected result?
No failures about classList.replace() tests

What happens instead?
All classList.replace() tests fail.

Please use labels and text to provide additional information.
Specification: https://dom.spec.whatwg.org/#dom-domtokenlist-replace

Edge: Not supported
Firefox: OK
Safari: OK

This needs both of a chromestatus.com entry and Intent-to-implement-and-ship.

Comment 2 by tkent@chromium.org, May 23 2017

Blocking: 725414

Comment 3 by tkent@chromium.org, May 23 2017

Blocking: -600964

Comment 4 by tkent@chromium.org, Jun 1 2017

Owner: tkent@chromium.org
Status: Started (was: Available)

Comment 5 by tkent@chromium.org, Jun 1 2017

Labels: -Needs-BlinkIntent
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32f911942ef880c8ce582b9d81e7c7826cd804d5

commit 32f911942ef880c8ce582b9d81e7c7826cd804d5
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Jun 01 09:57:01 2017

Implement DOMTokenList.prototype.replace().

Firefox and Safari already shipped it.
This CL fixes 256 failing tests in external/wpt/.

Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/0P4_WvNr1xY

Bug:  724906 
Change-Id: Ic55ead1509afd3e631ed0251fa312bd5b4a7001f
Reviewed-on: https://chromium-review.googlesource.com/521002
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476240}
[delete] https://crrev.com/92db6b2c14f28d8339590ea4c6a0186d9bbf08c5/third_party/WebKit/LayoutTests/external/wpt/custom-elements/reactions/DOMTokenList-expected.txt
[modify] https://crrev.com/32f911942ef880c8ce582b9d81e7c7826cd804d5/third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
[delete] https://crrev.com/92db6b2c14f28d8339590ea4c6a0186d9bbf08c5/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Element-classlist-expected.txt
[modify] https://crrev.com/32f911942ef880c8ce582b9d81e7c7826cd804d5/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/32f911942ef880c8ce582b9d81e7c7826cd804d5/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/32f911942ef880c8ce582b9d81e7c7826cd804d5/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/32f911942ef880c8ce582b9d81e7c7826cd804d5/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/32f911942ef880c8ce582b9d81e7c7826cd804d5/third_party/WebKit/Source/core/dom/DOMTokenList.cpp
[modify] https://crrev.com/32f911942ef880c8ce582b9d81e7c7826cd804d5/third_party/WebKit/Source/core/dom/DOMTokenList.h
[modify] https://crrev.com/32f911942ef880c8ce582b9d81e7c7826cd804d5/third_party/WebKit/Source/core/dom/DOMTokenList.idl
[modify] https://crrev.com/32f911942ef880c8ce582b9d81e7c7826cd804d5/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp
[modify] https://crrev.com/32f911942ef880c8ce582b9d81e7c7826cd804d5/third_party/WebKit/Source/core/dom/SpaceSplitString.h

Comment 7 by tkent@chromium.org, Jun 1 2017

Labels: M-61
Status: Fixed (was: Started)

Comment 8 by tkent@chromium.org, Jun 4 2017

Cc: dominicc@chromium.org
 Issue 580339  has been merged into this issue.
►

Sign in to add a comment