PasswordProtectionService stores binary data in prefs |
|||
Issue descriptionPrefs only supports data types serializable as JSON. Storing a base::Value of type BINARY renders prefs unserializable. PasswordProtectionService stores a serialized proto as a binary base::Value in content settings (which is backed by prefs). I'm fairly certain this triggered issue 721685. Please use an alternative format (e.g. base64 encode the serialized proto).
,
May 22 2017
sammc@, thanks for pointing this out! Do you mean applying base::Base64Encode(..) to the serialized string and then store it as STRING?
,
May 22 2017
,
May 22 2017
Yes.
,
May 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee69e6f69b1498d2f7b91a8e8ffc2a77603951e8 commit ee69e6f69b1498d2f7b91a8e8ffc2a77603951e8 Author: jialiul <jialiul@chromium.org> Date: Mon May 22 23:58:56 2017 Change string data instead of binary in content settings. BUG= 724905 Review-Url: https://codereview.chromium.org/2895323002 Cr-Commit-Position: refs/heads/master@{#473750} [modify] https://crrev.com/ee69e6f69b1498d2f7b91a8e8ffc2a77603951e8/components/safe_browsing/password_protection/password_protection_service.cc
,
May 23 2017
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/537415ea77b5938871ca199b1f68253bcd657da6 commit 537415ea77b5938871ca199b1f68253bcd657da6 Author: Sam McNally <sammc@chromium.org> Date: Tue May 23 10:30:17 2017 Check that prefs are serializable in TestingPrefStore and JsonPrefStore. Bug: 724905 Change-Id: Ic813e70973ba9aef1c88278e51d4424547d245b8 Reviewed-on: https://chromium-review.googlesource.com/509409 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#473849} [modify] https://crrev.com/537415ea77b5938871ca199b1f68253bcd657da6/components/prefs/json_pref_store.cc [modify] https://crrev.com/537415ea77b5938871ca199b1f68253bcd657da6/components/prefs/testing_pref_store.cc [modify] https://crrev.com/537415ea77b5938871ca199b1f68253bcd657da6/components/prefs/testing_pref_store.h |
|||
►
Sign in to add a comment |
|||
Comment 1 by jialiul@chromium.org
, May 22 2017