New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724901 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
EstimatedDays: 0
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Master-Paladin fails with KeyError during empty runs

Project Member Reported by davidjames@chromium.org, May 22 2017

Issue description

Example: https://uberchromegw.corp.google.com/i/chromeos/builders/master-paladin/builds/14566

@@@STEP_FAILURE@@@
05:06:35: ERROR: Traceback (most recent call last):
  File "/b/cbuild/repository/chromite/cbuildbot/stages/generic_stages.py", line 629, in Run
    self.PerformStage()
  File "/b/cbuild/repository/chromite/cbuildbot/stages/completion_stages.py", line 950, in PerformStage
    super(CommitQueueCompletionStage, self).PerformStage()
  File "/b/cbuild/repository/chromite/cbuildbot/stages/completion_stages.py", line 297, in PerformStage
    statuses = self._FetchSlaveStatuses()
  File "/b/cbuild/repository/chromite/cbuildbot/stages/completion_stages.py", line 215, in _FetchSlaveStatuses
    manager, build_id, db, builder_names, timeout))
  File "/b/cbuild/repository/chromite/cbuildbot/stages/completion_stages.py", line 946, in _GetSlaveBuildStatus
    timeout=timeout)
  File "/b/cbuild/repository/chromite/cbuildbot/manifest_version.py", line 633, in GetBuildersStatus
    builder_status = slave_builder_statuses.GetBuilderStatusForBuild(builder)
  File "/b/cbuild/repository/chromite/lib/builder_status_lib.py", line 366, in GetBuilderStatusForBuild
    build_config, self.cidb_info_dict, self.buildbucket_info_dict)
  File "/b/cbuild/repository/chromite/lib/builder_status_lib.py", line 294, in _GetDashboardUrl
    return buildbucket_info_dict[build_config].url
KeyError: u'x86-mario-paladin'
 

Comment 1 by nxia@chromium.org, May 22 2017

Owner: nxia@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/788e0088112dc8658e5032b1a68ccd1f5f496cbf

commit 788e0088112dc8658e5032b1a68ccd1f5f496cbf
Author: Ningning Xia <nxia@chromium.org>
Date: Fri Jun 02 22:11:18 2017

Do not get builder statues for slaves if no slaves were triggered.

If a CQ master build didn't pick up any new CLs or chumped CLs, no
slaves will be triggered, do not get builder statuses for slaves in this
case.

BUG= chromium:724901 
TEST=unit_tests

Change-Id: Idee584766fc400a0548948dc4884383784f06f86
Reviewed-on: https://chromium-review.googlesource.com/517238
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/788e0088112dc8658e5032b1a68ccd1f5f496cbf/cbuildbot/manifest_version.py
[modify] https://crrev.com/788e0088112dc8658e5032b1a68ccd1f5f496cbf/cbuildbot/manifest_version_unittest.py

Comment 4 by nxia@chromium.org, Jun 2 2017

Status: Fixed (was: Assigned)

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment