New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724890 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in sfntly::FontData::BoundLength

Project Member Reported by ClusterFuzz, May 21 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6543236482203648

Fuzzer: libfuzzer_sfntly_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  sfntly::FontData::BoundLength
  sfntly::ReadableFontData::ReadBytes
  sfntly::NameTable::Name
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=417039:417261

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6543236482203648


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: thestig@chromium.org ranjitkan@chromium.org
Labels: M-60 Test-Predator-Correct-CLs
Assigning to concern owner from Predator results --
The result is a list of CL's that change the crashed files. 

Author: Lei Zhang
Project: chromium-sfntly
Changelist: https://chromium.googlesource.com/external/github.com/googlei18n/sfntly.git/+/dd230461d199c49d762185d0b02107505d216bee
Time: Thu Sep 01 07:18:38 2016
Lines 96-141 of file readable_font_data.cc which potentially caused crash are changed in this cl (frame #1, "sfntly::ReadableFontData::ReadBytes").
Minimum distance from crash line to modified line: 0. (file: readable_font_data.cc, crashed on: 129, modified: 129).

@ thestig: CC'ing you, request you to please take a look into it and help us to find an owner to triage it. Unable to assign the Owner of  the cl for this change.

Thanks.!
Cc: -thestig@chromium.org behdad@chromium.org
Components: Internals>Skia>PDF
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by mmoroz@chromium.org, Oct 24 2017

For more information, please see https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md.

The link referenced in the description is no longer valid.

(bulk edit)
Labels: -M-60 M-66
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e18303469043d05e27e125c44161e66a32be28bc

commit e18303469043d05e27e125c44161e66a32be28bc
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Feb 22 03:47:02 2018

Roll DEPS for sfntly 16f3404..2804148

2804148 Handle negative offsets when reading name tables.
f5e0c30 Validate table count in font headers.

BUG= 724890 , 811938 
TBR=behdad@chromium.org

Change-Id: Ie3a073347099b963e38ec80ea5bbaec5c17b49ec
Reviewed-on: https://chromium-review.googlesource.com/930365
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538337}
[modify] https://crrev.com/e18303469043d05e27e125c44161e66a32be28bc/DEPS

Project Member

Comment 6 by ClusterFuzz, Feb 22 2018

ClusterFuzz has detected this issue as fixed in range 538333:538342.

Detailed report: https://clusterfuzz.com/testcase?key=6543236482203648

Fuzzer: libFuzzer_sfntly_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  sfntly::FontData::BoundLength
  sfntly::ReadableFontData::ReadBytes
  sfntly::NameTable::Name
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=417039:417261
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=538333:538342

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6543236482203648

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Feb 22 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6543236482203648 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment