New issue
Advanced search Search tips

Issue 724847 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

"EditingTest.RichTextMoveByLine" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 21 2017

Issue description

"EditingTest.RichTextMoveByLine" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 7 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKQsSBUZsYWtlIh5FZGl0aW5nVGVzdC5SaWNoVGV4dE1vdmVCeUxpbmUM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by Findit, May 21 2017

Labels: Test-Findit-Analyzed
Findit identified the culprit r472523 with confidence 66.6% in the config "tryserver.chromium.linux / linux_chromium_chromeos_rel_ng"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0uY2hyb21pdW1vcy9MaW51eCBDaHJvbWl1bU9TIFRlc3RzICgxKS8zODkwMS9jaHJvbWV2b3hfdGVzdHMvUldScGRHbHVaMVJsYzNRdVVtbGphRlJsZUhSTmIzWmxRbmxNYVc1bAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in alpha version.
Feedback is welcome using component Tools>Test>FindIt>Flakiness !
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14f07ec38cce6cb7cf5fdf2bcdeaed94c427a1ad

commit 14f07ec38cce6cb7cf5fdf2bcdeaed94c427a1ad
Author: tsergeant <tsergeant@chromium.org>
Date: Mon May 22 02:30:05 2017

Disable flaky test "EditingTest.RichTextMoveByLine"

This test has been failing flakily on ChromeOS bots since it was added
in https://crrev.com/472523.

BUG= 724847 
TBR=dtseng@chromium.org,dmazzoni@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2897823002
Cr-Commit-Position: refs/heads/master@{#473492}

[modify] https://crrev.com/14f07ec38cce6cb7cf5fdf2bcdeaed94c427a1ad/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs

Cc: dmazz...@chromium.org
Labels: -Sheriff-Chromium
Owner: dtseng@chromium.org
Status: Assigned (was: Untriaged)
This test has been disabled as it was failing quite frequently on tryjobs.

See here for example failure output: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_chromeos_rel_ng%2F431324%2F%2B%2Frecipes%2Fsteps%2Fchromevox_tests__with_patch_%2F0%2Flogs%2FEditingTest.RichTextMoveByLine%2F0

That log output is quite long and contains several failed assertions, so it's hard for me to copy the relevant part here directly.
Project Member

Comment 4 by chromium...@appspot.gserviceaccount.com, May 22 2017

Labels: Sheriff-Chromium
Detected 9 new flakes for test/step "EditingTest.RichTextMoveByLine". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKQsSBUZsYWtlIh5FZGl0aW5nVGVzdC5SaWNoVGV4dE1vdmVCeUxpbmUM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Project Member

Comment 6 by chromium...@appspot.gserviceaccount.com, Jun 10 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "EditingTest.RichTextMoveByLine". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKQsSBUZsYWtlIh5FZGl0aW5nVGVzdC5SaWNoVGV4dE1vdmVCeUxpbmUM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
@dtseng, this is still flaking even after you re-enabled it in:

https://chromium.googlesource.com/chromium/src/+/feef72d0d19c8336b0199b6b7c8ad10b0251f675

Please disable or fix immediately as it's affecting tree health.
Components: UI>Accessibility>ChromeVox
Labels: -Pri-1 Pri-3
Disable in flight, dropping to p3.
Project Member

Comment 10 by chromium...@appspot.gserviceaccount.com, Jun 13 2017

Detected 3 new flakes for test/step "EditingTest.RichTextMoveByLine". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKQsSBUZsYWtlIh5FZGl0aW5nVGVzdC5SaWNoVGV4dE1vdmVCeUxpbmUM. This message was posted automatically by the chromium-try-flakes app.
Labels: -Sheriff-Chromium
Removing sheriff tracking since these have workarounds in place.
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e68adf216466ddb631e88c39987be66435c69fce

commit e68adf216466ddb631e88c39987be66435c69fce
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Tue Jun 13 18:58:37 2017

Disabled flaky failing EditingTest.RichTextMove* tests.

BUG= 731825 , 732000 , 724847 
TEST=none
TBR=dtseng

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3428fcfc7a45b95bc1a38059b28610c212b588e0
Reviewed-on: https://chromium-review.googlesource.com/533594
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479084}
[modify] https://crrev.com/e68adf216466ddb631e88c39987be66435c69fce/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b2d9fd6510ad34f7530a616586a93c68eb0b10e

commit 7b2d9fd6510ad34f7530a616586a93c68eb0b10e
Author: dtseng <dtseng@chromium.org>
Date: Wed Jun 14 04:19:17 2017

Fix EditingTest.RichText*

BUG= 724847 , 731825 , 732000 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2939753002
Cr-Commit-Position: refs/heads/master@{#479282}

[modify] https://crrev.com/7b2d9fd6510ad34f7530a616586a93c68eb0b10e/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs

Status: fixed (was: Assigned)

Sign in to add a comment