New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724836 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 732158



Sign in to add a comment

Dragging with pen is broken

Reported by martinar...@gmail.com, May 21 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3106.0 Safari/537.36

Example URL:
https://sketch.io/sketchpad/

Steps to reproduce the problem:
1. Head to https://sketch.io/sketchpad/ (or any sketch websites, for that matter)
2. Open a new tab, or go to an already existing tab
3. Go back to the sketch website; pen should not work now

If step 2 does not work as intended, play with the website instead of just switching tabs.

What is the expected behavior?
The pen should behave normally and be able to draw on the canvas.

What went wrong?
The Wacom pen is still responsive, however, it is not possible to make any lines on the canvas; other buttons work fine.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? No 

Does this work in other browsers? Yes

Chrome version: 60.0.3106.0  Channel: n/a
OS Version: 10.0
Flash Version: Shockwave Flash 25.0 r0

I am using a Wacom Bamboo, CTH-461/S. Windows 10.
 
Components: -Blink Blink>Input
Cc: dtapu...@chromium.org mustaq@chromium.org nzolghadr@chromium.org
Labels: -Type-Bug -Pri-2 Hotlist-Input-Dev Pri-1 Type-Bug-Regression
Owner: lanwei@chromium.org
Status: Assigned (was: Unconfirmed)
lanwei@ this is reported against Canary. Please attempt to reproduce today branch is Thursday and if this is a reproducible issue we need to fix it ASAP.

Comment 3 by lanwei@chromium.org, May 23 2017

I tried on Canary Version 60.0.3108.0, and could not reproduce this problem. I am using Wacom intuos pro.

I draw on the sketchpad website, and open a new tab, I can still come back to the sketchpad website and continue drawing. Could you please check again on the new Canary?

Comment 4 by mustaq@chromium.org, May 23 2017

martinarkley56@: Two clarification questions since we are unable to repro:
A. Does it happen on every attempt? Or intermittently?
B. How are you opening/switching tabs? Using keyboard or pen?
C. Does it happen if you switch windows (not tabs)?
Also are you having the pen leave the drawing surface or have it remain in contact with the surface? Does this work in Edge correctly?
lanwei@: I tried again on the newest canary, the problem still persists.

mustaq@: This happens on every attempt. 
I am switching tabs using the pen. 
This problem does not occur when I switch windows.

dtapu...@: The pen is on the drawing surface during the time. This problem does not occur in Edge or Internet Explorer.

It seems my Wacom device does not like Chromium. The moment I grab the pen and start to drag links or pictures with the pen on any website, the browser is completely unresponsive until I either move the computer mouse or let the pen leave the browser, and, for example, move it to my taskbar. Refreshing the page fixes this problem, as well. I can provide a link to a video showing this in real time if you would like, because it is very difficult to describe it in text.

I would also like to mention that Chrome works perfectly fine. Chromium is the only issue.

Thank you.


Comment 7 by lanwei@chromium.org, May 25 2017

Thanks for explaining your issue. A video will be very helpful.

When you switch tabs using the pen, do you always press the pen on the tablet and use the button on the pen to click on the tab, or you use your pen click on the tab, which means that your pen is not in contact with the tablet after the click?  
lanwei@: I switch tabs using the pen alone; no buttons on the tablet or the pen. I am just tapping the tablet. The pen is in contact with the tablet during the click, and I release the pen after the click is done, similar to a mouse.

Since it is hard to reproduce this issue in the way I described, here is a video that explains it pretty well.

I attached the file, but here is a youtube link if that does not work. 

https://youtu.be/eE_3MH4lbg0

The drawing website shown in the video is located at drawception.com/sandbox.

It was difficult to reproduce with the example url I gave url, so try this one instead.

Thanks.


2017-05-25 10-45-11.mp4
25.8 MB Download
Summary: Dragging with pen is broken (was: Wacom pen unresponsive after certain actions)
Project Member

Comment 10 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/984c0003a871be8eec92691961ae0617fe728fb1

commit 984c0003a871be8eec92691961ae0617fe728fb1
Author: lanwei <lanwei@chromium.org>
Date: Wed May 31 16:16:37 2017

Disable drag and drop when we use stylus on Windows

Windows DoDragDrop function does not support invoking drag and drop support when
we handle touch or pen input. If we want to support drag and drop for pen input,
we have to listen to WM_MOUSE instead of WM_POINTER.
https://msdn.microsoft.com/en-us/library/windows/desktop/ms678486(v=vs.85).aspx

Edge does not support drag and drop for pen neither.

BUG= 724836 

Review-Url: https://codereview.chromium.org/2911413002
Cr-Commit-Position: refs/heads/master@{#475934}

[modify] https://crrev.com/984c0003a871be8eec92691961ae0617fe728fb1/third_party/WebKit/Source/core/input/MouseEventManager.cpp

The issue seems to be fixed with the newest version of Chromium. I can not drag, as expected, and so the browser never freezes. Thank you.
Status: Fixed (was: Assigned)
The reason that the pen stops working is because we are switching to WM_POINTER, and Windows does not support drag and drop for pen input. We decide to convert stylus dragging into direct manipulation like touch to match other operating systems like Android/ChromeOS.
Labels: Merge-Request-60
Cc: girard@chromium.org
Project Member

Comment 15 by sheriffbot@chromium.org, Jul 11 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
This change meets the bar and is approved for merge into M60
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 11 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac6e8af1c459e9a34d028cc286992b7ca5b90bc7

commit ac6e8af1c459e9a34d028cc286992b7ca5b90bc7
Author: lanwei <lanwei@chromium.org>
Date: Tue Jul 11 20:41:54 2017

Disable drag and drop when we use stylus on Windows

Windows DoDragDrop function does not support invoking drag and drop support when
we handle touch or pen input. If we want to support drag and drop for pen input,
we have to listen to WM_MOUSE instead of WM_POINTER.
https://msdn.microsoft.com/en-us/library/windows/desktop/ms678486(v=vs.85).aspx

Edge does not support drag and drop for pen neither.

BUG= 724836 

TBR=dtapuska@chromium.org

Review-Url: https://codereview.chromium.org/2911413002
Cr-Original-Commit-Position: refs/heads/master@{#475934}
(cherry picked from commit 984c0003a871be8eec92691961ae0617fe728fb1)
Review-Url: https://codereview.chromium.org/2976783002 .
Cr-Commit-Position: refs/branch-heads/3112@{#586}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/ac6e8af1c459e9a34d028cc286992b7ca5b90bc7/third_party/WebKit/Source/core/input/MouseEventManager.cpp

Labels: TE-NeedsTriageFromMTV
Adding TE-NeedsTriageFromMTV as it requires pen to verify the issue.

MTV@ Could any one from MTV team please check this issue.

Thanks,
Cc: lanwei@chromium.org sandeepkumars@chromium.org hdodda@chromium.org
 Issue 738009  has been merged into this issue.
Labels: M-60
Status: Verified (was: Fixed)
Labels: -TE-NeedsTriageFromMTV
lanwei@, thank you for verifying this fix from your end on Latest Beta#60.0.3112.66 (Surface Book).
Blocking: 732158

Sign in to add a comment