New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724812 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

hardware video decode broken on lumpy/butterfly

Project Member Reported by vapier@chromium.org, May 20 2017

Issue description

Chrome Version       : 60.0.3100.0
OS Version: 9554.1.0
URLs (if applicable) : https://imgur.com/gallery/2E3c3

What steps will reproduce the problem?
1. visit https://imgur.com/gallery/2E3c3
2. see a black screen
3. disable chrome://flags/#disable-accelerated-video-decode
4. log out & log in
5. visit URL again and now video decode works

going to attach the mp4 directly that fails.  downloading and trying to play locally also does not work.
https://i.imgur.com/BjYfSUj.mp4

UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 9554.1.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3100.0 Safari/537.36
 
BjYfSUj.mp4
248 KB View Download
Owner: posciak@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: vsu...@chromium.org avkodipelli@chromium.org
Labels: Needs-Feedback
Unable to repo issue on 60.0.3105.0 :9574.0.0  on daisy and one intel device.

vapier@ Can you please provide device details and is it observed atfer new update. Also please submit feedback report using alt + shit +i and add bug number. Thanks!

Comment 3 by vapier@chromium.org, May 23 2017

Labels: -Needs-Feedback
there is nothing newer than 60.0.3100.0 available for lumpy so i can't test that

daisy is an arm platform with vastly different hardware than lumpy, and i suspect your "one intel device" is also not a lumpy (or sandybridge based at least).  you need to get a comparable platform before trying to reproduce.

i've posted feedback now.
Components: -Internals>Media>Video OS>Kernel>Video
Labels: M-60
vapier@ Thanks for the device info.

Observed issue on 9578.0.0 / 60.0.3105.0 on lumpy device. Not observed issue by disabling h/w decode from about:flags 

Feedback Id : 61464778137

Labels: -Type-Bug -Pri-2 M-59 ReleaseBlock-Stable Pri-1 Type-Bug-Regression
This video is working on 53.0.2785.154/8530.96.0 and 58.0.3029.140/9334.72.0.

But not working on 59.0.3071.57/9460.42.0.

https://bugs.chromium.org/p/chromium/issues/detail?id=724876 is also similar issue ?

Comment 6 by vapier@chromium.org, May 24 2017

Blockedon: 724876
thanks, that bug sounds related, prob even the same.  i'll let Paweł decide how he wants to manage these :).
Labels: videoshortlist
Labels: -ReleaseBlock-Stable ReleaseBlock-Beta
this issue also effecting vimeo videos and local MP4 videos. 
Build used : 9460.50.0, 59.0.3071.71, device : lumpy
Good build : 9434.0.0/59.0.3055.0
Bad build : 9435.0.0/59.0.3063.0

Chrome OS diff:
https://crosland.corp.google.com/log/9434.0.0..9435.0.0

Chrome diff: 
https://chromium.googlesource.com/chromium/src/+log/59.0.3055.0..59.0.3063.0?pretty=fuller&n=10000
none of those CrOS changes look relevant (applies to repos/boards not used by lumpy), or interesting (doesn't look video related).

the Chrome pin/unpin are a little interesting, but if the Chrome bisect is accurate, there's plenty to go through there :).
This issue also happening on butterfly.
Summary: hardware video decode broken on lumpy/butterfly (was: hardware video decode broken on lumpy)
Cc: acourbot@chromium.org
Status: Started (was: Assigned)
I could not reproduce this on other platforms, and I was not able to secure a lumpy or butterfly locally here.

I tested instead on a remote device on ToT and the decoding was working fine on this stream, the stream is also correct running it through the reference decoder. This could suggest an issue in rendering rather then decoding.

Probably the easiest would be to bisect Chrome, given that we have a short regression range, but for that I will need to coordinate with someone that could actually see the screen, given that decoding seems to be fine and there seem to have been some video rendering-related changes in the bisect diff.
i guess i wasn't explicit before ... playing the video seems to work in the sense that i hear audio and the progress bar moves steadily.  but the window stays black.

if need be, i could put my lumpy into dev mode and test out builds you have.
Cc: dcasta...@chromium.org
Bisected to have been caused by crrev.com/517d0115d3c435383f79a0b730b6514a6cc97f44.
Cc: reve...@chromium.org
dcastagna@: Looks like your intention in crrev.com/517d0115d3c435383f79a0b730b6514a6cc97f44 has been to use RGBA_RESOURCE everywhere but on Android. However, on lumpy, returning RGBA_RESOURCE instead of STREAM_TEXTURE_RESOURCE seems to be causing this rendering issue.

video_frame->metadata()->IsTrue(media::VideoFrameMetadata::COPY_REQUIRED) is false on lumpy and before your CL we used STREAM_TEXTURE_RESOURCE there.

Could you suggest what should we do here please? Thanks.
Can this bug be caught be thumbnail testcase in VDA unittest?
No, unfortunately this is an issue in rendering path in Chrome, which is not used in the codec unittest.
I'm going to revert this CL for now, since we need to unblock beta.
Labels: Merge-Request-60 Merge-Request-59
Revert is in. Requesting merge to 59 and 60 please.
Project Member

Comment 24 by sheriffbot@chromium.org, Jun 2 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: We are only 3 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: hsiangc@chromium.org posciak@chromium.org
 Issue 724876  has been merged into this issue.
Blockedon: -724876
Labels: Merge-Approved-59
Project Member

Comment 28 by sheriffbot@chromium.org, Jun 3 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-59 -Merge-Approved-59 -Merge-Approved-60 Merge-Merged
Status: Fixed (was: Started)
Verified on 9460.60.0, 59.0.3071.91. 

I'll close the issue after testing on M60.
Status: Verified (was: Fixed)
Verified on butterfly on 9592.20.0/60.0.3112.31
Labels: -Hotlist-Merge-Review

Sign in to add a comment