New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 724733 link

Starred by 1 user
Status: Fixed
Owner:
ccameron@chromium.org
Closed: May 2017
Cc:
█ junov@chromium.org
█ zakerinasab@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 713891



Sign in to add a comment

color: images/pixelated-canvas.html layout test has swapped R and G channels

Project Member Reported by ccameron@chromium.org, May 20 2017 
This happens only when run as a layout test.

It appears that RuntimeEnabledFeatures::experimentalCanvasFeaturesEnabled() is being set to true in this layout test.

When we elide this CanvasRenderingContext::CanvasRenderingContext, the issue goes away.

Comment 1 by ccameron@chromium.org, May 20 2017

Cc: zakerinasab@chromium.org junov@chromium.org
There is a lot of code behind
  if (RuntimeEnabledFeatures::experimentalCanvasFeaturesEnabled() &&
      RuntimeEnabledFeatures::colorCorrectRenderingEnabled())
which is causing these bugs.

IMO we should add a --enable-canvas-color-modes, or something to that effect.

As it is, we need to keep this stuff disabled as we enable color correct rendering.

I can repro most of these failures with the full command line
  --disable-gpu-rasterization \
  --enable-color-correct-rendering \
  --force-color-profile=srgb \
  --enable-experimental-canvas-features \
  --diasble-zero-copy \
Project Member

Comment 2 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1e300b0f88b6a65a87c9b27cd3e327499c25e86

commit b1e300b0f88b6a65a87c9b27cd3e327499c25e86
Author: ccameron <ccameron@chromium.org>
Date: Fri May 26 05:24:27 2017

color: Add ColorCanvasExtensions runtime flag

These features being developed behind --enable-color-correct-rendering
and --enable-experimental-canvas-features.

We're turning on  --enable-color-correct-rendering for all layout tests,
some of which also use --enable-experimental-canvas-features, but do
not want to opt in to new canvas behaviors (at least yet).

To avoid this, use the Blink feature flag ColorCanvasExtensions. While
we're in the neighborhood, pull out the uses of the flag
--enable-color-correct-rendering-default-mode and related code.

BUG= 724733 

Review-Url: https://codereview.chromium.org/2893243003
Cr-Commit-Position: refs/heads/master@{#474921}

[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/content/public/common/content_switches.cc
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/content/public/common/content_switches.h
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/content/public/common/web_preferences.h
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/content/renderer/render_view_impl.cc
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/core/html/ImageData.cpp
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/b1e300b0f88b6a65a87c9b27cd3e327499c25e86/third_party/WebKit/public/platform/WebRuntimeFeatures.h

Comment 3 by ccameron@chromium.org, May 26 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment