New issue
Advanced search Search tips

Issue 724730 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

exposureMode: manual is broken in Android

Project Member Reported by mcasas@chromium.org, May 20 2017

Issue description

🔥 When I simply set applyConstraints({advanced: [ {exposureMode: ‘manual’} ]}), video becomes too bright (even with ISO set to 100) and lags a LOT.


Steps to reproduce

(1) Go to https://beaufortfrancois.github.io/sandbox/image-capture/playground.html
(2) configure the drop down menu "exposureMode" to "manual"
(3) see the exposure going bananas: usually too dark.
 

Comment 1 by mcasas@chromium.org, May 20 2017

Components: Blink>Image

Comment 2 by mcasas@chromium.org, May 20 2017

Components: -Blink>Image Blink>ImageCapture
Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4808673d8daf77d882a14591d103a052c92a430f

commit 4808673d8daf77d882a14591d103a052c92a430f
Author: Miguel Casas-Sanchez <mcasas@chromium.org>
Date: Tue May 23 00:09:57 2017

Image Capture: use current exposure time when exposureMode is set to manual

retrieve the current exposure time and use it for the exposureMode == manual

Bug:  724730 
Change-Id: I6a4e7dff5a89f72d31be45c85668c3e7d1ba9f99
Reviewed-on: https://chromium-review.googlesource.com/509173
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473756}
[modify] https://crrev.com/4808673d8daf77d882a14591d103a052c92a430f/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java

Comment 4 by mcasas@chromium.org, May 23 2017

Labels: Merge-Request-59
Project Member

Comment 5 by sheriffbot@chromium.org, May 23 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by mcasas@chromium.org, May 23 2017

Status: Fixed (was: Started)
In Chromium 60.0.3109.0, the manual exposure is now too dark on my Google Pixel Phone with Android 0 Developer Preview. See https://drive.google.com/a/google.com/file/d/0B8A3Ku3z80zGdGtqVlJZenBkNUU/view?usp=sharing
https://drive.google.com/a/google.com/file/d/0B8A3Ku3z80zGOXRQRHFiLWlyS28/view?usp=sharing

Comment 8 by mcasas@chromium.org, May 23 2017

Labels: -Hotlist-Merge-Review
#7: There might still be things we don't understand here, 
removing the merge request.
Labels: -Merge-Review-59
I just compiled a Chromium build for sailfish and set 
exposureMode = "manual" and it looked fine-ish (not too dark). Same 
behaviour for Canary 3108.3 (#3 landed in 3108.). Perhaps the O 
preview is messing up? Could you try with another phone plz?
I can reproduce with a Nexus 6 phone (shamu) with Android 7.0.0 and Chrome Canary 61.0.3115.0. Note that in that case, it is too bright, not too dark... ;(

Sign in to add a comment