Improve Bluetooth User Metrics |
|||||||||||
Issue descriptionThis is the umbrella bug to track the progress of improving the Bluetooth user metrics in BlueZ.
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c4da1390d590da133fa547a590edfbbcb292df4 commit 6c4da1390d590da133fa547a590edfbbcb292df4 Author: mcchou <mcchou@google.com> Date: Wed Jun 28 22:30:12 2017 Add UMA metrics for Bluetooth system daemon This adds the following histograms and corresponding enums definitions. [Histograms] - BlueZ.ReasonOfDisconnection - BlueZ.ResultOfAdvertisementRegistration - BlueZ.ResultOfConnection - BlueZ.ResultOfPairing - BlueZ.TimeLengthOfAdvertisement - BlueZ.TimeLengthOfDiscoverable - BlueZ.TimeLengthOfDiscovering - BlueZ.TimeLengthOfPairing - BlueZ.TimeLengthOfSetupConnection - BlueZ.TypeOfDiscovery - BlueZ.TypeOfFoundDevice [Enums] - BlueZReasonOfDisconnection - BlueZResultOfAdvertisementRegistration - BlueZResultOfConnection - BlueZResultOfPairing - BlueZTypeOfDiscovery - BlueZTypeOfFoundDevice BUG= chromium:724720 Review-Url: https://codereview.chromium.org/2956143002 Cr-Commit-Position: refs/heads/master@{#483175} [modify] https://crrev.com/6c4da1390d590da133fa547a590edfbbcb292df4/tools/metrics/histograms/enums.xml [modify] https://crrev.com/6c4da1390d590da133fa547a590edfbbcb292df4/tools/metrics/histograms/histograms.xml
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/8f39e42be5fc4011ffaad312cf2f81ed60da9970 commit 8f39e42be5fc4011ffaad312cf2f81ed60da9970 Author: Miao-chen Chou <mcchou@chromium.org> Date: Thu Jul 06 04:54:53 2017 CHROMIUM: Add libmetrics as a linkage This patch imports libmetrics as a dependency for future UMA metrics collection. BASE_VER is an environment variable from libchrome. BUG= chromium:724720 TEST=embed a sample in the start-up of adapter, build BlueZ with lmetrics linkage and verify the record on chrome://histograms CQ-DEPEND=CL:509940 Change-Id: I9d2794e825e144f9fb9d087c0550800039405362 Reviewed-on: https://chromium-review.googlesource.com/509977 Commit-Ready: Miao-chen Chou <mcchou@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/8f39e42be5fc4011ffaad312cf2f81ed60da9970/Makefile.am
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8beabd78453507d6daaed35ac44c1b5635f5acf7 commit 8beabd78453507d6daaed35ac44c1b5635f5acf7 Author: Miao-chen Chou <mcchou@chromium.org> Date: Thu Jul 06 04:54:52 2017 bluez: Add "VERBOSE=1" to src_test() This adds "VERBOSE=1" to src_test() so that error messages can be printed. BUG= chromium:724720 TEST=add a false assert in the test, build BlueZ with "FEATURES=test emerge-caroline bluez" and verify that the error message shows Change-Id: I4ddac418c592b53a3a9fe9fd6ec022a4a021f574 Reviewed-on: https://chromium-review.googlesource.com/547023 Commit-Ready: Miao-chen Chou <mcchou@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/8beabd78453507d6daaed35ac44c1b5635f5acf7/net-wireless/bluez/bluez-9999.ebuild
,
Jul 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/edf4d9a58d5ff822cd43ef85f4711b01f281b6c1 commit edf4d9a58d5ff822cd43ef85f4711b01f281b6c1 Author: Miao-chen Chou <mcchou@chromium.org> Date: Fri Jul 07 04:13:50 2017 CHROMIUM: Add the UMA metrics wrapper This introduces a metrics wrapper of UMA metrics client library. This wrapper defines several types of timers for Count histograms and enums type for Enum histograms. This also includes the unit test for the wrapper. BUG= chromium:724720 TEST=build BlueZ with "FEATURES=test emerge-caroline bluez" and verify the metrics_unittests passed CQ-DEPEND=CL:547023 Change-Id: I3d49f218d4077801e40e384bc2abb874465b8534 Reviewed-on: https://chromium-review.googlesource.com/538909 Commit-Ready: Miao-chen Chou <mcchou@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/edf4d9a58d5ff822cd43ef85f4711b01f281b6c1/src/advertising.c [modify] https://crrev.com/edf4d9a58d5ff822cd43ef85f4711b01f281b6c1/src/device.c [modify] https://crrev.com/edf4d9a58d5ff822cd43ef85f4711b01f281b6c1/src/device.h [modify] https://crrev.com/edf4d9a58d5ff822cd43ef85f4711b01f281b6c1/src/advertising.h [add] https://crrev.com/edf4d9a58d5ff822cd43ef85f4711b01f281b6c1/src/metrics_unittests.c [modify] https://crrev.com/edf4d9a58d5ff822cd43ef85f4711b01f281b6c1/src/adapter.h [modify] https://crrev.com/edf4d9a58d5ff822cd43ef85f4711b01f281b6c1/Makefile.am [add] https://crrev.com/edf4d9a58d5ff822cd43ef85f4711b01f281b6c1/src/metrics.c [modify] https://crrev.com/edf4d9a58d5ff822cd43ef85f4711b01f281b6c1/src/adapter.c [add] https://crrev.com/edf4d9a58d5ff822cd43ef85f4711b01f281b6c1/src/metrics.h
,
Jul 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/1fc0e14b1e6e06c1f151bc3d25345531ce95204b commit 1fc0e14b1e6e06c1f151bc3d25345531ce95204b Author: Miao-chen Chou <mcchou@chromium.org> Date: Fri Jul 07 04:13:50 2017 CHROMIUM: Add UMA metrics This adds the following metrics to BlueZ. - Time Length of the discovery - Type of the discovery - Type of the discovered devices - Time length of discoverable status - Number of advertisement requests, failures and success cases - Time length of successful advertising - Number of pairing failures in terms of error code and success cases - Time length for pairing to finish successfully - Time difference between connection requested to connection result received - Number of connections request in terms of BREDR LE - Number of connections failures in terms of error code and success cases - Number of disconnections in terms of disconnection reasons Please see the server-side XML changes at https://codereview.chromium.org/2956143002/. BUG= chromium:724720 TEST=build BlueZ with lmetrics linkage, perform some Bluetooth activities and verify the records on chrome://histograms Change-Id: I11a1a9d383c68ec356bf91fa60b29697b49f2079 Reviewed-on: https://chromium-review.googlesource.com/538910 Commit-Ready: Miao-chen Chou <mcchou@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/1fc0e14b1e6e06c1f151bc3d25345531ce95204b/src/advertising.c [modify] https://crrev.com/1fc0e14b1e6e06c1f151bc3d25345531ce95204b/src/adapter.c [modify] https://crrev.com/1fc0e14b1e6e06c1f151bc3d25345531ce95204b/src/device.c
,
Oct 16 2017
,
Oct 16 2017
,
Oct 16 2017
This bug requires manual review: We are only 0 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17 2017
Approved for 62 and 63.
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5a0727f63a302804a7900fcff499f9d4bd115c8 commit b5a0727f63a302804a7900fcff499f9d4bd115c8 Author: Miao-chen Chou <mcchou@chromium.org> Date: Tue Oct 17 21:33:10 2017 Add UMA metrics for Chrome OS Bluetooth system daemon This adds the following histograms and their definitions. [Histograms] - BlueZ.AdapterLost - BlueZ.NumberOfExistingAdvertisements BUG= chromium:724720 Change-Id: I44e8cb0df131efff57582d5bbbda7abe2b16a97b Reviewed-on: https://chromium-review.googlesource.com/722076 Commit-Queue: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#509544} [modify] https://crrev.com/b5a0727f63a302804a7900fcff499f9d4bd115c8/tools/metrics/histograms/histograms.xml
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/445b208c87564827a73be500dfdf0dca707f2784 commit 445b208c87564827a73be500dfdf0dca707f2784 Author: Miao-chen Chou <mcchou@chromium.org> Date: Wed Oct 18 01:14:01 2017 Add UMA metrics for Chrome OS Bluetooth system daemon This adds the following histograms and their definitions. [Histograms] - BlueZ.AdapterLost - BlueZ.NumberOfExistingAdvertisements BUG= chromium:724720 TBR=mcchou@chromium.org (cherry picked from commit b5a0727f63a302804a7900fcff499f9d4bd115c8) Change-Id: I44e8cb0df131efff57582d5bbbda7abe2b16a97b Reviewed-on: https://chromium-review.googlesource.com/722076 Commit-Queue: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509544} Reviewed-on: https://chromium-review.googlesource.com/724719 Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#709} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/445b208c87564827a73be500dfdf0dca707f2784/tools/metrics/histograms/histograms.xml
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e40f3d2fe300502d4d4b9da06d83dc3cfaf592a9 commit e40f3d2fe300502d4d4b9da06d83dc3cfaf592a9 Author: Miao-chen Chou <mcchou@chromium.org> Date: Thu Oct 19 17:43:12 2017 Add UMA metrics for Chrome OS Bluetooth system daemon This adds the following histograms and their definitions. [Histograms] - BlueZ.AdapterLost - BlueZ.NumberOfExistingAdvertisements BUG= chromium:724720 TBR=mcchou@chromium.org (cherry picked from commit b5a0727f63a302804a7900fcff499f9d4bd115c8) Change-Id: I44e8cb0df131efff57582d5bbbda7abe2b16a97b Reviewed-on: https://chromium-review.googlesource.com/722076 Commit-Queue: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509544} Reviewed-on: https://chromium-review.googlesource.com/728349 Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#73} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/e40f3d2fe300502d4d4b9da06d83dc3cfaf592a9/tools/metrics/histograms/histograms.xml
,
Oct 31 2017
,
Jan 22 2018
,
Jan 23 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by ddorwin@chromium.org
, Jun 9 2017