New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724719 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 724708



Sign in to add a comment

EasyUnlock v2: Remove Bluetooth throttler

Project Member Reported by tengs@chromium.org, May 20 2017

Issue description

The Bluetooth throttler was a hack for working around a design flaw in BlueZ/kernel, which permanently wedges a classic Bluetooth connection.

With BLE, we no longer go down this code path, so we can remove or lighten the throttling.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9d3b3997673274a86176c159bf453012b747196

commit e9d3b3997673274a86176c159bf453012b747196
Author: tengs <tengs@chromium.org>
Date: Mon May 22 19:11:26 2017

[EasyUnlock] Reduce Bluetooth throttler time from 7 seconds to 1 seconds.

Ideally, we should simply remove this throttling logic altogether, as it was
used to work around some Bluetooth classic bugs. These bugs should no longer be
relevant for BLE.

However, to be safe, we'll simply reduce the throttling time first and see if
this causes insability.

BUG= 724719 

Review-Url: https://codereview.chromium.org/2896733002
Cr-Commit-Position: refs/heads/master@{#473648}

[modify] https://crrev.com/e9d3b3997673274a86176c159bf453012b747196/components/cryptauth/bluetooth_throttler_impl.cc

Comment 2 by tengs@chromium.org, May 22 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment