New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724715 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 724708



Sign in to add a comment

EasyUnlock v2: Add slider for configuring the RSSI

Project Member Reported by tengs@chromium.org, May 20 2017

Issue description

Ideally, we would like to have a calibration step for the proximity during setup, but at least with a slider, the user can do something if proximity detection is not working for them.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f9fada9b2e464e9229047ea801bb3a61ec03634

commit 7f9fada9b2e464e9229047ea801bb3a61ec03634
Author: tengs <tengs@chromium.org>
Date: Thu May 25 01:35:21 2017

[EasyUnlock] Reduce RSSI threshold to -70.

Because we have a hardcoded, unconfigurable value, we should set the threshold
to be on the conservative side.

BUG= 724715 

Review-Url: https://codereview.chromium.org/2902023004
Cr-Commit-Position: refs/heads/master@{#474513}

[modify] https://crrev.com/7f9fada9b2e464e9229047ea801bb3a61ec03634/components/proximity_auth/proximity_monitor_impl.cc
[modify] https://crrev.com/7f9fada9b2e464e9229047ea801bb3a61ec03634/components/proximity_auth/proximity_monitor_impl_unittest.cc

Cc: tbuck...@chromium.org bettes@chromium.org
Is there a UX design for this?

The description mentions a "slider" but this CL implements a dropdown: https://codereview.chromium.org/2973243002/

I am specifically concerned about localization of that dropdown.

Comment 3 by tengs@chromium.org, Jul 17 2017

You can find the UX deck here:
https://docs.google.com/presentation/d/1GnKn5ca_KrM_BTQB-He9cCmzAQtwVF6JJJ6Lo6i4gqI/edit?ts=59656279#slide=id.g4af27b4ff_35243

We decided to go with a drop down instead of a slider because it's more clear to the user what the RSSI value does.

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/474f53bea3f44cba536a1c6f6fe8611d4d89f720

commit 474f53bea3f44cba536a1c6f6fe8611d4d89f720
Author: sacomoto <sacomoto@chromium.org>
Date: Tue Jul 18 22:37:18 2017

Adding pref to store the user-selected proximity threshold.

BUG= 724715 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2973243002
Cr-Commit-Position: refs/heads/master@{#487630}

[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/chrome/browser/signin/easy_unlock_service.cc
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/components/proximity_auth/DEPS
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/components/proximity_auth/proximity_auth_pref_manager.cc
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/components/proximity_auth/proximity_auth_pref_manager.h
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/components/proximity_auth/proximity_auth_pref_manager_unittest.cc
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/components/proximity_auth/proximity_auth_pref_names.cc
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/components/proximity_auth/proximity_auth_pref_names.h
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/components/proximity_auth/proximity_auth_system.cc
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/components/proximity_auth/proximity_auth_system.h
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/components/proximity_auth/proximity_monitor_impl.cc
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/components/proximity_auth/proximity_monitor_impl.h
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/components/proximity_auth/proximity_monitor_impl_unittest.cc
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/components/proximity_auth/unlock_manager_impl.cc
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/components/proximity_auth/unlock_manager_impl.h
[modify] https://crrev.com/474f53bea3f44cba536a1c6f6fe8611d4d89f720/components/proximity_auth/unlock_manager_impl_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/290a492b2f848ae26608d6f925c18c9b0ec2bede

commit 290a492b2f848ae26608d6f925c18c9b0ec2bede
Author: Gustavo Sacomoto <sacomoto@chromium.org>
Date: Fri Jul 21 13:19:22 2017

[EasyUnlock] Exposing a proximity threshold selector in settings.

The mocks are here:
https://docs.google.com/a/google.com/presentation/d/1GnKn5ca_KrM_BTQB-He9cCmzAQtwVF6JJJ6Lo6i4gqI/edit?usp=sharing (slide 38)

EasyUnlock is disabled:
https://screenshot.googleplex.com/2WxZMn78UgM

EasyUnlock is enabled (the default value is selected):
https://screenshot.googleplex.com/WJ0KYLa5Jhm

EasyUnlock is enabled, user is selecting the value:
https://screenshot.googleplex.com/AXUadsCLgax

Bug:  724715 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I77e3f7a2d28feb9c5c8c9557df39c61c7e9065f0
Reviewed-on: https://chromium-review.googlesource.com/580407
Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488642}
[modify] https://crrev.com/290a492b2f848ae26608d6f925c18c9b0ec2bede/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/290a492b2f848ae26608d6f925c18c9b0ec2bede/chrome/browser/resources/settings/people_page/compiled_resources2.gyp
[modify] https://crrev.com/290a492b2f848ae26608d6f925c18c9b0ec2bede/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/290a492b2f848ae26608d6f925c18c9b0ec2bede/chrome/browser/resources/settings/people_page/lock_screen.js
[modify] https://crrev.com/290a492b2f848ae26608d6f925c18c9b0ec2bede/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Status: Fixed (was: Assigned)
Labels: Merge-Request-61
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 24 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-2 Pri-1
I only need to merge the CL in comment#5. The others were already included in the branch.
Cc: omrilio@chromium.org
Owner: sacomoto@chromium.org
Status: Assigned (was: Fixed)
Cc: keta...@chromium.org
@ketakid, do you have any update here? 

This is blocking other EasyUnlock merges in the M61 branch (our CLs are interdependent, and merging them out of order would create many conflicts).
Labels: M-61
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 7 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92f34c3a7647555f96ed9292b1cb00edd67b9457

commit 92f34c3a7647555f96ed9292b1cb00edd67b9457
Author: Tim Song <tengs@chromium.org>
Date: Mon Aug 07 17:16:48 2017

[EasyUnlock] Exposing a proximity threshold selector in settings.

The mocks are here:
https://docs.google.com/a/google.com/presentation/d/1GnKn5ca_KrM_BTQB-He9cCmzAQtwVF6JJJ6Lo6i4gqI/edit?usp=sharing (slide 38)

EasyUnlock is disabled:
https://screenshot.googleplex.com/2WxZMn78UgM

EasyUnlock is enabled (the default value is selected):
https://screenshot.googleplex.com/WJ0KYLa5Jhm

EasyUnlock is enabled, user is selecting the value:
https://screenshot.googleplex.com/AXUadsCLgax

TBR=sacomoto@chromium.org

(cherry picked from commit 290a492b2f848ae26608d6f925c18c9b0ec2bede)

Bug:  724715 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I77e3f7a2d28feb9c5c8c9557df39c61c7e9065f0
Reviewed-on: https://chromium-review.googlesource.com/580407
Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488642}
Reviewed-on: https://chromium-review.googlesource.com/604110
Cr-Commit-Position: refs/branch-heads/3163@{#352}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/92f34c3a7647555f96ed9292b1cb00edd67b9457/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/92f34c3a7647555f96ed9292b1cb00edd67b9457/chrome/browser/resources/settings/people_page/compiled_resources2.gyp
[modify] https://crrev.com/92f34c3a7647555f96ed9292b1cb00edd67b9457/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/92f34c3a7647555f96ed9292b1cb00edd67b9457/chrome/browser/resources/settings/people_page/lock_screen.js
[modify] https://crrev.com/92f34c3a7647555f96ed9292b1cb00edd67b9457/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Status: Fixed (was: Assigned)
Merging in advance because this is blocking some other CLs.
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 18 by sheriffbot@chromium.org, Aug 14 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 19 by sheriffbot@chromium.org, Aug 17 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 20 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment