New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 724710 link

Starred by 1 user
Status: Archived
Owner:
█ sacomoto@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
hansberry@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 724708



Sign in to add a comment

EasyUnlock v2: Update D2D protocol to v1 to support separate sequence numbers

Project Member Reported by tengs@chromium.org, May 20 2017 
Currently, the D2D v0 protocol uses a shared sequence number for both sides. Because our protocol is bidirectional and BLE is quite slow, we frequently run into sequence number race conditions when sending messages.

See cl/122789174 for corresponding implementation on Android.

Comment 1 by tengs@chromium.org, May 20 2017

Cc: hansberry@chromium.org
Summary: EasyUnlock v2: Update D2D protocol to v1 to support separate sequence numbers (was: Update D2D protocol to v1 to support separate sequence numbers)

Comment 2 by sacomoto@chromium.org, May 22 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00555778f4fc32501162d851633180b1fe0cec9f

commit 00555778f4fc32501162d851633180b1fe0cec9f
Author: sacomoto <sacomoto@chromium.org>
Date: Tue May 23 12:04:27 2017

Updating D2D protocol to v1 to support separate sequence numbers.

BUG= 724710 

Review-Url: https://codereview.chromium.org/2899863002
Cr-Commit-Position: refs/heads/master@{#473864}

[modify] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/BUILD.gn
[modify] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/device_to_device_authenticator.cc
[modify] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/device_to_device_authenticator.h
[modify] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/device_to_device_authenticator_unittest.cc
[modify] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/device_to_device_initiator_operations.cc
[modify] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/device_to_device_initiator_operations.h
[modify] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/device_to_device_operations_unittest.cc
[modify] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/device_to_device_responder_operations.cc
[modify] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/device_to_device_responder_operations.h
[modify] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/device_to_device_secure_context.cc
[modify] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/device_to_device_secure_context.h
[modify] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/device_to_device_secure_context_unittest.cc
[modify] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/proto/securemessage.proto
[add] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/session_keys.cc
[add] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/session_keys.h
[add] https://crrev.com/00555778f4fc32501162d851633180b1fe0cec9f/components/cryptauth/session_keys_unittest.cc

Comment 4 by sacomoto@chromium.org, May 23 2017

Status: Fixed (was: Started)

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment