New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 724707 link

Starred by 1 user
Status: Fixed
Owner:
█ sbc@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
jkwang@google.com
tbuck...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

native_client_sdk/src/build_tools/build_sdk.py broken

Project Member Reported by jkwang@google.com, May 20 2017 
The script is looking for src/testing/gmock/src/gmock.cc, which is not there any more.

To reproduce:
Run the script.

Comment 1 by tbuck...@chromium.org, May 22 2017

Labels: M-60
Status: Assigned (was: Untriaged)
@sbc let us know if there's someone else we should reach out to.
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ba1aa2f95523e8402a9480b876491f802a97b48

commit 1ba1aa2f95523e8402a9480b876491f802a97b48
Author: sbc <sbc@chromium.org>
Date: Mon May 22 22:59:00 2017

[NaCl SDK] Fix location of gmock and gtest libraries

This fixes the SDK build which was broken when these
libraries were moved.

BUG= 724707 

Review-Url: https://codereview.chromium.org/2896703005
Cr-Commit-Position: refs/heads/master@{#473730}

[modify] https://crrev.com/1ba1aa2f95523e8402a9480b876491f802a97b48/native_client_sdk/src/libraries/gmock/library.dsc
[modify] https://crrev.com/1ba1aa2f95523e8402a9480b876491f802a97b48/native_client_sdk/src/libraries/gtest/library.dsc

Comment 3 by sbc@chromium.org, May 30 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment