New issue
Advanced search Search tips

Issue 724700 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----



Sign in to add a comment

[Home] Fix new NTP shown over svelte tab switcher

Project Member Reported by twelling...@chromium.org, May 19 2017

Issue description

The Z-indexing needs to be updated so that the Chrome Home bottom sheet is shown over the svelte/accessibility tab switcher when a new tab is created.
 
Screenshot_20170519-160804.png
134 KB View Download
Cc: mdjones@chromium.org
Cc: cl...@chromium.org
Screenshots from in-flight patch attached.

As a P2, whether the incognito stack is visible or not is handled differently in the svelte tab switcher than it is in the regular tab switcher, so it's possible to have the bottom sheet half open over a black screen. This should be fixed for beta/stable experimentation. We need UX consideration for what this should look like since there is nothing distinguishing the normal tabs from incognito tabs in the accessibility tab switcher when CH is open.
Screenshot_20170523-095437.png
278 KB View Download
Screenshot_20170523-095752.png
157 KB View Download
Screenshot_20170523-095743.png
146 KB View Download
Issue 726034 has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dfe6af12787999c6f219ae1df78d44608d5dc45

commit 7dfe6af12787999c6f219ae1df78d44608d5dc45
Author: twellington <twellington@chromium.org>
Date: Wed May 24 20:55:55 2017

[Android] Add OverviewListLayout to main CoordinatorLayout

Rather than adding the accessibility tab switcher layout to
R.id.content, add it to a FrameLayout in the main CoordinatorLayout
so that the Chrome Home bottom sheet can be drawn on top of it.

BUG= 724700 

Review-Url: https://codereview.chromium.org/2898243002
Cr-Commit-Position: refs/heads/master@{#474417}

[modify] https://crrev.com/7dfe6af12787999c6f219ae1df78d44608d5dc45/chrome/android/java/res/layout/main.xml
[modify] https://crrev.com/7dfe6af12787999c6f219ae1df78d44608d5dc45/chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on 60.0.3112.10 build

Sign in to add a comment