+dtrainor@ - we should consider adding an accessibility announcement for all IPH.

+ktam@ - I think the accessibility announcement should say "Pull up bottom navigation panel to see bookmarks and more". Does that sound good to you? 

There's actually a separate thread here about the string: https://docs.google.com/document/d/1stgWSswlVLX-eJ2XCZW9h0J5zCLTT4YmArlb0t9B77M/edit

Shimi's proposal is "Pull up on the address bar to see bookmarks, downloads, and history" which I'm good with.

The in-product help widget supports setting a different string for accessibility, but it also changes the text that is displayed. See attached screenshot.

Deleted: Screenshot_20170522-154426.png 491 KB

	Screenshot_20170522-154426.png 491 KB View Download

Help bubbles when the expand button is present and accessibility is enabled and disabled

Deleted: Screenshot_20170522-171419.png 284 KB

	Screenshot_20170522-171419.png 284 KB View Download

Deleted: Screenshot_20170522-171311.png 274 KB

	Screenshot_20170522-171311.png 274 KB View Download

+shaktisahu@.  We should be announcing I thought.  We worked with the accessibility team to figure out what the correct behavior was.  The suggestion was to change the string when talkback was enabled to match what we read out to the user.

Shakti, if we aren't announcing do you know if that's expected or not?  Could you follow up with vtsaran@ to make sure we're doing the right thing?

I wonder if part of this is timing, since our IPH is shown at start up. When I was testing yesterday, sometimes the IPH was announced when it was shown and sometimes it wasn't.

Oh interesting...  Maybe things like initialization/focus changes are cancelling and overriding the accessibility?

It's definitely possible. If IPH announcement works in other scenarios, I think we can punt a bit on the CH IPH announcement since we're re-doing it before stable experimentation anyway.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44dd1fe909c433cf0b8297be8825e372fc2d57a8

commit 44dd1fe909c433cf0b8297be8825e372fc2d57a8
Author: twellington <twellington@chromium.org>
Date: Tue May 23 18:36:17 2017

[Home] Add some accessibility support

 * Announce when the panel is opened and closed.
 * Prevent focus from going to the tab content when the bottom
   sheet is open.
 * Change the in-product help bubble when the expand button is
   enabled and use different strings for non-accessibility mode
   and accessibility mode.
 * Announce when a different bottom sheet tab is selected.
 * When the expand button isn't visible, make the entire toolbar
   focusable for accessibility and add a content description.

BUG= 724694 , 724696 , 724693 , 724695 

Review-Url: https://codereview.chromium.org/2895223003
Cr-Commit-Position: refs/heads/master@{#473995}

[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/strings/android_chrome_strings.grd

This didn't actually get fixed with the IPH changes for beta/stable in issue 728265. There are too many things loading/changing in the UI and the accessibility announcement gets skipped. We could try to delay showing the IPH help for an arbitrary amount of time or wait until the M62 integration with the IPH back-end system which should (hopefully) fix this. My preference is to wait for M62.

Kingston and I agreed that this can be a P2 targeting M62

+nyquist@ for FYI.  Is this a problem with other UI announcements during loading as well?  Or just IPH?

I don't know that we have a bunch of other UI announcements, but I suspect that the system will get overloaded and skip speaking something if we throw too much at it at once.

Over to Shakti to look at as part of the M62 CH IPH work

This should at least be fixed for M62 before CH

Fixed with the following revision

https://chromium.googlesource.com/chromium/src.git/+/863956a504507d526e85ed04410aeb0ca6a3b02c