For the overflow menu it would say "More options button. Double tap to activate. Swipe up to access navigation panel." I couldn't get swiping up on the menu button to actually open the bottom panel.

Tapping on the omnibox reads the current URL then says "edit box. Double tap to edit. Long-press and hold..." so I don't think it make sense to append the "Swipe up" string there either.

If the in-product help is changed to use the specified string when accessibility is enabled, are these changes still needed?

A quick correction on the strings - the "Double tap activate" and similar strings are appended automatically by Android, so the strings would read more like "More options button. Swipe up to access navigation panel. Double tap to activate."

I came up with a good compromise. When the expand button is not visible, I made the bottom toolbar focusable via touch exploration and set the content description to "Address bar. Pull up to see bookmarks, downloads, and history."

That way if users are swiping between items when talk back is on, the entire toolbar can gain focus and will read the description.

Perfect - yes that sounds great. Thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44dd1fe909c433cf0b8297be8825e372fc2d57a8

commit 44dd1fe909c433cf0b8297be8825e372fc2d57a8
Author: twellington <twellington@chromium.org>
Date: Tue May 23 18:36:17 2017

[Home] Add some accessibility support

 * Announce when the panel is opened and closed.
 * Prevent focus from going to the tab content when the bottom
   sheet is open.
 * Change the in-product help bubble when the expand button is
   enabled and use different strings for non-accessibility mode
   and accessibility mode.
 * Announce when a different bottom sheet tab is selected.
 * When the expand button isn't visible, make the entire toolbar
   focusable for accessibility and add a content description.

BUG= 724694 , 724696 , 724693 , 724695 

Review-Url: https://codereview.chromium.org/2895223003
Cr-Commit-Position: refs/heads/master@{#473995}

[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/strings/android_chrome_strings.grd

Verified in M60-60.0.3112.10 build. It is reading as "Navigation Panel Opened and Closed

I'm going to re-open to track an add on piece for accessibility. We should change the toolbar content description to "pull down to close navigation panel" or something like that when the sheet is opened.

Sounds reasonable to me. +Laura any thoughts here? Otherwise, I think calling "Swipe down to close navigation panel" seems fine to me.

If we do "Swipe down to close..." should we change the existing accessibility to "Swipe up to see..." (it's currently "Pull up to see...")?

Sure - let's keep to pull down since that's already been reviewed.

Laura, changing the content description of the toolbar while it's focused causes TalkBack to read the new content description. For example, if the user focuses the toolbar, TalkBack will currently read "Address bar. Swipe up to see bookmarks, downloads, and history." If the user then pulls up on the address bar to open the navigation panel, TalkBack will read "Address bar. Swipe down to close navigation panel. Navigation panel opened."

I think it's a bit odd that it reads the new content description. I can prevent it by temporarily marking the view and not important for accessibility, but that causes the toolbar to lose accessibility focus. From your perspective, what is the correct behavior?

post holiday bump - lpalmaro@, will you pleas comment on #13 when you have a few minutes?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8d100d9581474a2f45bc03c2ed7b45bfa6b9b1d

commit b8d100d9581474a2f45bc03c2ed7b45bfa6b9b1d
Author: Theresa Wellington <twellington@google.com>
Date: Thu Jul 13 22:50:39 2017

[Home] Update toolbar content description based on sheet state

BUG= 724695 

Change-Id: Ibb733a5ac20664aa4bac20fe41e13ffe1523ffef
Reviewed-on: https://chromium-review.googlesource.com/570665
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486505}
[modify] https://crrev.com/b8d100d9581474a2f45bc03c2ed7b45bfa6b9b1d/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
[modify] https://crrev.com/b8d100d9581474a2f45bc03c2ed7b45bfa6b9b1d/chrome/android/java/strings/android_chrome_strings.grd

To circle back, when the sheet is opened I give focus to the bottom sheet. When the sheet is closed, focus stays on the toolbar (if it has focus) so the content descriptions may be read back to back. The experience seems pretty good to me, but we can polish after accessibility review if needed.

Hey! Sorry for the delay as I was traveling for 2 back to back a11y conferences. I think it's fine to have the description read, actually, as it gives the user confirmation of what happened. The only thing I'd say is that if we could reorder what is spoken, that might be best -- for example, if we could say "Address bar. Navigation panel opened. Swipe down to close navigation panel." that might be more intuitive. What do you think? 

No problem, thanks for the feedback!

"Address bar" and "Swipe down to close navigation panel" are part of the same content description, so they can't be broken up. I could try to swap the order -- "Navigation panel opened. Address bar. Swipe down to close navigation panel." ?