It's easier to implement if there isn't a distinction between half-height and full-height. Is it okay if the announcement just says "Navigation panel opened"?

I asked Laura this specifically and she preferred to have it announce a distinction but I'm good with just announcing navigation panel opened for now and then having half/full height as a P2. Laura thoughts?

If the user is opening the panel via swipe, should we announce "Navigation panel opened" right away or wait for the user to release the sheet? If it's right away, we don't actually know whether the panel is going to half-height or full-height. If it's after the sheet is released, I'd like to push the "half-height" vs "full-height" to a P2 after M60 branch.

I was imagining that it would be after the sheet is released. I'm fine with punting the half- vs. full- height to P2 pre-Beta/Stable experiment.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44dd1fe909c433cf0b8297be8825e372fc2d57a8

commit 44dd1fe909c433cf0b8297be8825e372fc2d57a8
Author: twellington <twellington@chromium.org>
Date: Tue May 23 18:36:17 2017

[Home] Add some accessibility support

 * Announce when the panel is opened and closed.
 * Prevent focus from going to the tab content when the bottom
   sheet is open.
 * Change the in-product help bubble when the expand button is
   enabled and use different strings for non-accessibility mode
   and accessibility mode.
 * Announce when a different bottom sheet tab is selected.
 * When the expand button isn't visible, make the entire toolbar
   focusable for accessibility and add a content description.

BUG= 724694 , 724696 , 724693 , 724695 

Review-Url: https://codereview.chromium.org/2895223003
Cr-Commit-Position: refs/heads/master@{#473995}

[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/strings/android_chrome_strings.grd

Lowering priority to track the rest of the work, which is adding "half state" and "full state" to "Navigation panel opened" announcement.

Removing ownership since this is "available"

Accessibility team considers this launch-blocking. Increasing the priority.

Laura, the panel can go from closed -> half -> full -> half -> full -> .. etc. My in-flight CL announces each time it stops at the half or full height. Is that desired behavior?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/258dfd85e3f0d0cfeb6c168b4324bf0a02388078

commit 258dfd85e3f0d0cfeb6c168b4324bf0a02388078
Author: Theresa Wellington <twellington@google.com>
Date: Fri Sep 15 17:25:43 2017

[Home] Announce panel opened at half/full height

BUG= 724694 

Change-Id: I8761d26c8281a3550101b55053a1bc311fb2f6eb
Reviewed-on: https://chromium-review.googlesource.com/668199
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502294}
[modify] https://crrev.com/258dfd85e3f0d0cfeb6c168b4324bf0a02388078/chrome/android/OWNERS
[modify] https://crrev.com/258dfd85e3f0d0cfeb6c168b4324bf0a02388078/chrome/android/java/OWNERS
[modify] https://crrev.com/258dfd85e3f0d0cfeb6c168b4324bf0a02388078/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
[modify] https://crrev.com/258dfd85e3f0d0cfeb6c168b4324bf0a02388078/chrome/android/java/strings/android_chrome_strings.grd

re-tested on M63-63.0.3220.0
Now reading as panel opened at half/full height

reading panel open at half and full height only for newtab and incognito tab.

but not reading same way for home,download,bookmarks, History

Deleted: bookmark.png 118 KB

	bookmark.png 118 KB View Download

The expectation is that when the panel changes to half-height or full-height, TalkBack will read "Panel opened at half-height" or "Panel opened at full-height". When switching tabs, TalkBack should read "Downloads tab selected", or "Bookmarks tab selected", etc.