New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724693 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Tapping a pane in the bottom toolbar should inform user

Project Member Reported by k...@chromium.org, May 19 2017

Issue description

Issue Steps:
+ Tap a bottom toolbar pane (Home, Bookmarks, Downloads, History)
+ There’s no information about the pane being selected
 
Proposed Solution:
When user taps a bottom toolbar pane, e.g. Bookmarks, then we should move focus to the header of the pane and say “<Home/Bookmarks/Downloads/History> tab”. This way, when the user then swipes to the right, focus is then at the top of that pane instead of still back down in Chrome Home.

 
Cc: k...@chromium.org
We can easily announce that new tab was selected, but if we give focus to the toolbar (which is the top view) Talk Back will announce different things depending on which view is being shown. For Downloads, it will announce "Dropdown list downloads. Double tap to change." since downloads has a spinner as it's first element. For bookmarks, it will announce the title of the current folder since that's what's shown in the toolbar. For history, it will announce "History".

I propose that we announce which tab was selected without trying to give focus to the toolbar.

Comment 2 by k...@chromium.org, May 23 2017

Cc: lpalmaro@chromium.org
Yes, I'm fine with that solution. It's what Google Photos does. Feel free to disagree Laura.
Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44dd1fe909c433cf0b8297be8825e372fc2d57a8

commit 44dd1fe909c433cf0b8297be8825e372fc2d57a8
Author: twellington <twellington@chromium.org>
Date: Tue May 23 18:36:17 2017

[Home] Add some accessibility support

 * Announce when the panel is opened and closed.
 * Prevent focus from going to the tab content when the bottom
   sheet is open.
 * Change the in-product help bubble when the expand button is
   enabled and use different strings for non-accessibility mode
   and accessibility mode.
 * Announce when a different bottom sheet tab is selected.
 * When the expand button isn't visible, make the entire toolbar
   focusable for accessibility and add a content description.

BUG= 724694 , 724696 , 724693 , 724695 

Review-Url: https://codereview.chromium.org/2895223003
Cr-Commit-Position: refs/heads/master@{#473995}

[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java
[modify] https://crrev.com/44dd1fe909c433cf0b8297be8825e372fc2d57a8/chrome/android/java/strings/android_chrome_strings.grd

Status: Fixed (was: Assigned)
Verified on M60-60.0.3112.0 build
Labels: -Pri-1 Pri-2
Status: Assigned (was: Fixed)
I'm going to re-open to track an add on piece for accessibility. We should change the toolbar content description to "pull down to close navigation panel" or something like that when the sheet is opened.
Status: Verified (was: Assigned)
This was the wrong bug to re-open.  Issue 724695  is about telling users the toolbar is swipeable.

Sign in to add a comment