Parallel download sub requests shouldn't use post method. |
|||
Issue descriptionWe recently find more HTTP 405 method not allowed error code in the parallel download finch experiment group metrics. Currently the sub requests only uses GET method, however the download request can be POST also. We should limit the parallel download to GET method only, since post method can have data in the post body used by the server, and it's risky and questionable to copy post body data in the sub requests.
,
May 23 2017
,
May 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16ca9f743af85a9194b63b4585636d59b7c6bf53 commit 16ca9f743af85a9194b63b4585636d59b7c6bf53 Author: xingliu <xingliu@chromium.org> Date: Thu May 25 22:32:47 2017 Limit parallel download to http GET requests. Currently we have seen 405 error code in parallel download metrics. And parallel download should be only used in GET requests since we don't know how the server uses POST body data. BUG= 724690 Review-Url: https://codereview.chromium.org/2897743002 Cr-Commit-Position: refs/heads/master@{#474823} [modify] https://crrev.com/16ca9f743af85a9194b63b4585636d59b7c6bf53/content/browser/download/download_create_info.cc [modify] https://crrev.com/16ca9f743af85a9194b63b4585636d59b7c6bf53/content/browser/download/download_create_info.h [modify] https://crrev.com/16ca9f743af85a9194b63b4585636d59b7c6bf53/content/browser/download/download_job_factory.cc [modify] https://crrev.com/16ca9f743af85a9194b63b4585636d59b7c6bf53/content/browser/download/download_request_core.cc [modify] https://crrev.com/16ca9f743af85a9194b63b4585636d59b7c6bf53/content/browser/download/download_stats.h [modify] https://crrev.com/16ca9f743af85a9194b63b4585636d59b7c6bf53/content/browser/download/parallel_download_job.cc [modify] https://crrev.com/16ca9f743af85a9194b63b4585636d59b7c6bf53/tools/metrics/histograms/enums.xml
,
Jun 2 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by xingliu@chromium.org
, May 19 2017