Remove "connecting" spinner from network/vpn/bluetooth rows in system menu |
|||||
Issue descriptionAccording to the code, when a device of network/vpn/bluetooth type is trying to connect, a spinner is added to the right side of the its row in the detailed view. According to the specs, that's not needed. So, we can remove the spinner.
,
May 22 2017
I confirm. connecting state on a row should be indicated by a second line marking "connecting..." as well as an animated icon when possible.
,
May 23 2017
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37549ddbe11771e1f3fdeb52456cad8bf4ea48f5 commit 37549ddbe11771e1f3fdeb52456cad8bf4ea48f5 Author: Mohsen Izadi <mohsen@chromium.org> Date: Tue May 23 05:27:45 2017 Remove spinner from connectivity rows in system menu According to MD specs for system menu detailed views, there is no spinner for network/vpn/bluetooth rows that are trying to connect. BUG= 724680 TEST=none Change-Id: If610554c95b1c35ffbcc32bd6ad9f51927bf558d Reviewed-on: https://chromium-review.googlesource.com/509231 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#473817} [modify] https://crrev.com/37549ddbe11771e1f3fdeb52456cad8bf4ea48f5/ash/BUILD.gn [modify] https://crrev.com/37549ddbe11771e1f3fdeb52456cad8bf4ea48f5/ash/system/bluetooth/tray_bluetooth.cc [modify] https://crrev.com/37549ddbe11771e1f3fdeb52456cad8bf4ea48f5/ash/system/network/network_list.cc [modify] https://crrev.com/37549ddbe11771e1f3fdeb52456cad8bf4ea48f5/ash/system/network/vpn_list_view.cc [delete] https://crrev.com/436a4cf74a6fa89ec5c570f43f6dd0cc04c0ea98/ash/system/tray/throbber_view.cc [delete] https://crrev.com/436a4cf74a6fa89ec5c570f43f6dd0cc04c0ea98/ash/system/tray/throbber_view.h
,
May 23 2017
,
May 25 2017
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by moh...@chromium.org
, May 19 2017