New issue
Advanced search Search tips

Issue 724675 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

hover effect on back button for maximized window is broken in RTL

Project Member Reported by est...@chromium.org, May 19 2017

Issue description

I recently broke this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c7cdc7b3156ce8527708922c7b6b1208ad805f0

commit 8c7cdc7b3156ce8527708922c7b6b1208ad805f0
Author: estade <estade@chromium.org>
Date: Wed May 24 00:25:30 2017

Change default ink drop center points to center of contents bounds
rather than local bounds.

This needs RTL mirroring, so introduce utility View::GetMirroredRect()
and use it to reduce verbosity in a bunch of places that are currently
using GetMirroredXForRect().

BUG= 724675 

Review-Url: https://codereview.chromium.org/2897533003
Cr-Commit-Position: refs/heads/master@{#474120}

[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/chrome/browser/ui/views/frame/browser_header_painter_ash.cc
[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc
[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/chrome/browser/ui/views/frame/contents_layout_manager.cc
[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/chrome/browser/ui/views/status_bubble_views.cc
[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/chrome/browser/ui/views/toolbar/app_menu.cc
[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/chrome/browser/ui/views/toolbar/toolbar_button.h
[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/ui/views/animation/ink_drop_host_view.cc
[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/ui/views/view.cc
[modify] https://crrev.com/8c7cdc7b3156ce8527708922c7b6b1208ad805f0/ui/views/view.h

Comment 2 by est...@chromium.org, May 24 2017

Status: Fixed (was: Assigned)

Sign in to add a comment