New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724670 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until July 2018
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: ----
Type: ----



Sign in to add a comment

If page is untranslated and the user choses "Always" we should translate the page Inbox x Helpful x PM x

Project Member Reported by yyushkina@chromium.org, May 19 2017

Issue description

Feature description: If page is untranslated and the user choses "Always" we should translate the page 

Eng owner: ramyasharma@
Product owner: yyushkina

Right now if a user choses the "Always" option before translating a page it remains untranslated. That's counterintuitive so we it'd be better if we translated the page.

 
Labels: Translate-te
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f32a232b18f75e5af490a160486468a55ef85641

commit f32a232b18f75e5af490a160486468a55ef85641
Author: ramyasharma <ramyasharma@chromium.org>
Date: Tue May 23 01:42:50 2017

If page is untranslated and the user chooses "Always", translate the page.

When user selects "Always translate page", if the page is untranslated,
then translate the page, and make UI changes to indicate selected
tab on the infobar.

BUG= 724670 

Review-Url: https://codereview.chromium.org/2899663002
Cr-Commit-Position: refs/heads/master@{#473778}

[modify] https://crrev.com/f32a232b18f75e5af490a160486468a55ef85641/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

Status: Fixed (was: Started)

Sign in to add a comment