New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724669 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 764593



Sign in to add a comment

Add bluetooth suspend_resume and reboot files

Project Member Reported by rjahagir@chromium.org, May 19 2017

Issue description

Add suspend_resume and reboot options to bluetooth pairing tests to be run in bluetooth_sanity suite.

These tests can then be stressed and added to the bluetooth_stress suite.
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/57c5c197fb4c0f27db2c6c9c531de847574b588a

commit 57c5c197fb4c0f27db2c6c9c531de847574b588a
Author: Ruchi Jahagirdar <rjahagir@google.com>
Date: Thu Jun 08 06:45:45 2017

[Bluetooth] Adding bluetooth_AdapterSuspendResume

Adding bluetooth_AdapterSuspendResume to ebuild file.

TEST=None
BUG= chromium:724669 

Change-Id: Ica70f7d33195c7853ea1ea14034f1eada284e706
Reviewed-on: https://chromium-review.googlesource.com/525097
Commit-Ready: Ruchi Jahagirdar <rjahagir@chromium.org>
Tested-by: Ruchi Jahagirdar <rjahagir@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>

[modify] https://crrev.com/57c5c197fb4c0f27db2c6c9c531de847574b588a/chromeos-base/autotest-server-tests/autotest-server-tests-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/774fb07b0625f4df0494fc4b9e76c6b138ec7659

commit 774fb07b0625f4df0494fc4b9e76c6b138ec7659
Author: Ruchi Jahagirdar <rjahagir@google.com>
Date: Fri Jun 16 08:49:29 2017

[Bluetooth] bt_AdapterPairing: add SR test

Adding suspend_resume control files to
bluetooth_AdapterPairing test.

BUG= chromium:724669 
TEST=test_that ${DUT_IP}
bluetooth_AdapterPairing.mouse.suspend_resume
--args "chameleon_host=$CHAMELEON_IP"

Change-Id: I9002cbbf2a01caab0c983f85c78b731212021a96
Reviewed-on: https://chromium-review.googlesource.com/509936
Commit-Ready: Ruchi Jahagirdar <rjahagir@chromium.org>
Tested-by: Ruchi Jahagirdar <rjahagir@chromium.org>
Reviewed-by: Shyh-In Hwang <josephsih@chromium.org>

[add] https://crrev.com/774fb07b0625f4df0494fc4b9e76c6b138ec7659/server/site_tests/bluetooth_AdapterPairing/control.mouse.suspend_resume_stress_100
[modify] https://crrev.com/774fb07b0625f4df0494fc4b9e76c6b138ec7659/server/cros/bluetooth/bluetooth_adapter_tests.py
[add] https://crrev.com/774fb07b0625f4df0494fc4b9e76c6b138ec7659/server/site_tests/bluetooth_AdapterPairing/control.mouse.suspend_resume
[modify] https://crrev.com/774fb07b0625f4df0494fc4b9e76c6b138ec7659/server/site_tests/bluetooth_AdapterPairing/bluetooth_AdapterPairing.py

Cc: josephsih@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e6092e74d781eec7a96b42a1a9a980fde01f9148

commit e6092e74d781eec7a96b42a1a9a980fde01f9148
Author: Alexander Lent <alent@google.com>
Date: Fri Aug 25 21:21:40 2017

[autotest] Fix bad argument to test_connection_by_device

The method test_connection_by_device attempts to make the emulated
Bluetooth device connect to the DUT. Consequently it needs to be passed
the emulated device object, not the address of the emulated device.

Note that bluetooth_AdapterPairing.mouse.suspend_resume still fails,
even with this patch. The test has a logic error that this fix exposed.

The logic error is under investigation, and is that the DUT does not
disconnect the emulated device when suspending. Since the DUT is
already connected to the emulated device, (an RN-42-EK connected to
Chameleon,) and the emulated device does not accept commands when
connected, the commands fail on Chameleon. (Autotest reports that these
commands have succeeded, which is incorrect.)

BUG= chromium:724669 
TEST=Run the specified test, watch it fail with the same reason, though
the logs show that the underlying problem is different:
$ test_that --board ${BOARD} --args "chameleon_host=${CHAMELEON_IP}" \
${DUT_IP} bluetooth_AdapterPairing.mouse.suspend_resume

Change-Id: Idbae10a3606e12ca29642ab86866ce15eb44a7ce
Reviewed-on: https://chromium-review.googlesource.com/634149
Commit-Ready: Alexander Lent <alent@google.com>
Tested-by: Alexander Lent <alent@google.com>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>

[modify] https://crrev.com/e6092e74d781eec7a96b42a1a9a980fde01f9148/server/site_tests/bluetooth_AdapterPairing/bluetooth_AdapterPairing.py

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/145c055367731ef5183519e647f8861835418c9e

commit 145c055367731ef5183519e647f8861835418c9e
Author: Ruchi Jahagirdar <rjahagir@google.com>
Date: Wed Aug 30 20:04:24 2017

[Bluetooth] Adding advertising stress tests

Adding stressx50 tests to bluetooth_AdapterLEAdvertising suspend/resume
and reboot tests.

BUG= chromium:724669 
TEST=Run the test as
$ test_that ${DUT_IP}
bluetooth_AdapterLEAdvertising.suspend_resume.stress_50
OR
bluetooth_AdapterLEAdvertising.reboot.stress_50

Change-Id: Ie066fc567bbb1a42c82e9b7801581c5eb2d5e64e
Reviewed-on: https://chromium-review.googlesource.com/606907
Commit-Ready: Ruchi Jahagirdar <rjahagir@chromium.org>
Tested-by: Ruchi Jahagirdar <rjahagir@chromium.org>
Reviewed-by: Shyh-In Hwang <josephsih@chromium.org>

[add] https://crrev.com/145c055367731ef5183519e647f8861835418c9e/server/site_tests/bluetooth_AdapterLEAdvertising/control.suspend_resume.stress_50
[add] https://crrev.com/145c055367731ef5183519e647f8861835418c9e/server/site_tests/bluetooth_AdapterLEAdvertising/control.reboot.stress_50
[modify] https://crrev.com/145c055367731ef5183519e647f8861835418c9e/server/site_tests/bluetooth_AdapterLEAdvertising/bluetooth_AdapterLEAdvertising.py

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f7e21d3cec3f06c29eba005e030505a1f52a885b

commit f7e21d3cec3f06c29eba005e030505a1f52a885b
Author: Ruchi Jahagirdar <rjahagir@google.com>
Date: Wed Sep 06 08:05:36 2017

[Autotest] Remove bluetooth_AdapterPairing.SR test

Remove bluetooth_AdapterPairing.mouse.suspend_resume from
bluetooth_sanity suite due to RN-42 issues. This test will be replaced
with bluetooth_HIDReports.mouse.suspend_resume.

BUG= chromium:724669 
TEST=None

Change-Id: Iee48908ce51f8fa349793e69cb6f9e77400c3367
Reviewed-on: https://chromium-review.googlesource.com/651026
Commit-Ready: Ruchi Jahagirdar <rjahagir@chromium.org>
Tested-by: Ruchi Jahagirdar <rjahagir@chromium.org>
Reviewed-by: Shyh-In Hwang <josephsih@chromium.org>

[modify] https://crrev.com/f7e21d3cec3f06c29eba005e030505a1f52a885b/server/site_tests/bluetooth_AdapterPairing/control.mouse.suspend_resume

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c0ce7ba587e19a52a3dba52e8ad32f0e635dd7dd

commit c0ce7ba587e19a52a3dba52e8ad32f0e635dd7dd
Author: Ruchi Jahagirdar <rjahagir@google.com>
Date: Thu Sep 14 00:13:55 2017

[Autotest] Removing bluetooth_AdapterReboot from sanity suite

Due to continuous restarting issue.

BUG= chromium:724669 
TEST=none

Change-Id: I67cd6e7d7aa59104474e8291dbf36d71d1da688a
Reviewed-on: https://chromium-review.googlesource.com/665182
Commit-Ready: Ruchi Jahagirdar <rjahagir@chromium.org>
Tested-by: Ruchi Jahagirdar <rjahagir@chromium.org>
Reviewed-by: Ruchi Jahagirdar <rjahagir@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>

[modify] https://crrev.com/c0ce7ba587e19a52a3dba52e8ad32f0e635dd7dd/server/site_tests/bluetooth_AdapterReboot/control

Status Update: I've added bluetooth_AdapterReboot, bluetooth_AdapterSuspendResume, bluetooth_AdapterLEAdvertising.suspend_resume/.reboot and the corresponding stress files. 

I've removed bluetooth_AdapterPairing.suspend_resume due to faultiness in the RN42 emulation kit.

The only thing left to do is add bluetooth_HIDReports.suspend_resume/reboot and corresponding stress files. This might be not possible right now due to the same RN42 faultiness.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9bfff5a1e7720044b9bce102faba1f1eabbbb1b6

commit 9bfff5a1e7720044b9bce102faba1f1eabbbb1b6
Author: Ruchi Jahagirdar <rjahagir@google.com>
Date: Fri Sep 22 13:10:15 2017

[Autotest] Readding reboot test to bluetooth_sanity

Readding bluetooth_AdapterReboot to bluetooth_sanity after a naming
mistake.

BUG= chromium:724669 
TEST=test_that {DUT_IP} bluetooth_AdapterReboot --autotest_dir
~/trunk/src/third_party/autotest/files

Change-Id: I24fc1ae6f99690091bb61c4012da0882a87c9186
Reviewed-on: https://chromium-review.googlesource.com/676730
Commit-Ready: Ruchi Jahagirdar <rjahagir@chromium.org>
Tested-by: Ruchi Jahagirdar <rjahagir@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>

[modify] https://crrev.com/9bfff5a1e7720044b9bce102faba1f1eabbbb1b6/server/site_tests/bluetooth_AdapterReboot/control
[modify] https://crrev.com/9bfff5a1e7720044b9bce102faba1f1eabbbb1b6/server/site_tests/bluetooth_AdapterReboot/control.stress_100

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f2e3d0c05c5b2b21aad51997e870f689a07af02b

commit f2e3d0c05c5b2b21aad51997e870f689a07af02b
Author: Ruchi Jahagirdar <rjahagir@google.com>
Date: Thu Sep 28 04:12:57 2017

[Autotest] Catch and pass autoserv suspend error

Catch and pass autoserv suspend error in bluetooth_adapter_tests

BUG= chromium:724669 
TEST= tested on local setup

Change-Id: I79ad1206e46206c8b3f4880f9cadbf3f0b6412f5
Reviewed-on: https://chromium-review.googlesource.com/679258
Commit-Ready: Ruchi Jahagirdar <rjahagir@chromium.org>
Tested-by: Ruchi Jahagirdar <rjahagir@chromium.org>
Reviewed-by: Ruchi Jahagirdar <rjahagir@chromium.org>

[modify] https://crrev.com/f2e3d0c05c5b2b21aad51997e870f689a07af02b/server/cros/bluetooth/bluetooth_adapter_tests.py

Status Update: I've caught and passed an autoservsuspenderror in bluetooth_adapter_tests (and removed the local suspend_resume method in bluetooth_AdapterSuspendResume). 

bluetooth_HIDReports.suspend_resume/reboot are written but we have an error where the RN42 kit "passes" the test regardless of failures. I'll open a separate bug for this and have it blocking this one.
Status Update: I've caught and passed an autoservsuspenderror in bluetooth_adapter_tests (and removed the local suspend_resume method in bluetooth_AdapterSuspendResume). 

bluetooth_HIDReports.suspend_resume/reboot are written but we have an error where the RN42 kit "passes" the test regardless of failures. I'll open a separate bug for this and have it blocking this one.
Blockedon: 764593
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a2ee38e9a5fe272299625c4b1b6627c53510f1be

commit a2ee38e9a5fe272299625c4b1b6627c53510f1be
Author: Ruchi Jahagirdar <rjahagir@google.com>
Date: Sat Oct 28 04:54:34 2017

[Bluetooth] Modifying bt_AdapterSuspendResume

Removing local suspend_resume method from test as this method has been
moved into bluetooth_adapter_tests and already imported.

BUG= chromium:724669 
TEST=test_that <ip> bluetooth_AdapterSuspendResume

Change-Id: I6dd7005592408660ec0b0b7c0817a39217111bc7
Reviewed-on: https://chromium-review.googlesource.com/742348
Commit-Ready: Ruchi Jahagirdar <rjahagir@chromium.org>
Tested-by: Ruchi Jahagirdar <rjahagir@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>

[modify] https://crrev.com/a2ee38e9a5fe272299625c4b1b6627c53510f1be/server/site_tests/bluetooth_AdapterSuspendResume/bluetooth_AdapterSuspendResume.py

Update: bluetooth_HIDReports.suspend_resume is in pre-cq. Last thing left is to write bluetooth_HIDReports.reboot.
Submitted bluetooth_AdapterHIDReports.mouse.suspend_resume

https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/598639
Project Member

Comment 18 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f3f25a1f8a3da78ed04ed6e0a0b8841db48f7a6a

commit f3f25a1f8a3da78ed04ed6e0a0b8841db48f7a6a
Author: Ruchi Jahagirdar <rjahagir@google.com>
Date: Fri Dec 01 04:30:13 2017

[Autotest] Adding reboot test to bt_HIDReports

Adding reboot section to bluetooth_AdapterHIDReports as well as removing
suspend resume stress test from bluetooth_AdapterPairing.

BUG= chromium:724669 
TEST=test_that <DUT_IP> bluetooth_AdapterHIDReports.mouse.reboot --args
"chameleon_host=<CHAMELEON_IP>"

Change-Id: Idc098cf67268a3e83cb3accd4e120e892e1acf7b
Reviewed-on: https://chromium-review.googlesource.com/773298
Commit-Ready: Ruchi Jahagirdar <rjahagir@chromium.org>
Tested-by: Ruchi Jahagirdar <rjahagir@chromium.org>
Reviewed-by: Shyh-In Hwang <josephsih@chromium.org>

[add] https://crrev.com/f3f25a1f8a3da78ed04ed6e0a0b8841db48f7a6a/server/site_tests/bluetooth_AdapterHIDReports/control.mouse.reboot
[delete] https://crrev.com/2445aecb11ce5672ec7d1bde7488aa1fc353b999/server/site_tests/bluetooth_AdapterPairing/control.mouse.suspend_resume_stress_100
[modify] https://crrev.com/f3f25a1f8a3da78ed04ed6e0a0b8841db48f7a6a/server/site_tests/bluetooth_AdapterHIDReports/bluetooth_AdapterHIDReports.py

Status: Verified (was: Started)
And with that, we can close this bug.

Sign in to add a comment