New issue
Advanced search Search tips

Issue 724668 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Improper label in getUserMedia video track of desktopCapture

Project Member Reported by braveyao@chromium.org, May 19 2017

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
1.Share a screen/window/tab with getUserMedia
2.Check the label in stream.getVideoTrack()[0].label
3.label is always printing the 'screen'


What is the expected result?
It should give human readable screen/window/web_content string

What happens instead?
Always get label as 'screen'

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
We can set the name with prefix of each capture type, for example:

screen capture -- screen:x:x
window capture -- window:x:x
tab capture    -- web-contents-media-stream:x:x
Components: Blink>GetUserMedia>Desktop
Project Member

Comment 3 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bcd03be11700eb3bd3755593f5a07530940e789

commit 5bcd03be11700eb3bd3755593f5a07530940e789
Author: braveyao <braveyao@chromium.org>
Date: Mon May 22 09:04:10 2017

desktopCapture: set the correct videoTrack label according to the capture type

Currently during desktopCature we always set vieoTrack label as "screen" to all the screen/window/tab capture.

This cl is to set the label with correct prefix to each capture type, i.e.
screen capture -- screen:x:x
window capture -- window:x:x
tab capture    -- web-contents-media-stream:x:x

BUG= 724668 

Review-Url: https://codereview.chromium.org/2890303003
Cr-Commit-Position: refs/heads/master@{#473529}

[modify] https://crrev.com/5bcd03be11700eb3bd3755593f5a07530940e789/chrome/browser/media/webrtc/desktop_capture_access_handler.cc

continue to investigate if we can get the title of the Window/Tab.
Labels: M-60
Labels: -Type-Bug Type-Feature
Status: Fixed (was: Started)
The title will vary with the current content in the middle of presentation. Also not all the title can reflect what's been presenting. So the stream label with window/tab title won't help a lot.
Close the issue for now. 

Sign in to add a comment