New issue
Advanced search Search tips

Issue 724659 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Opening incognito tab and switching from/to Chrome reveals empty bar

Project Member Reported by k...@chromium.org, May 19 2017

Issue description

Chrome Version: 60.0.3104.0
OS: Android

What steps will reproduce the problem?
(1) Enable new NTP experience / Chrome Home
(2) Open new incognito tab
(3) Go to homescreen
(4) Open Chrome again

What is the expected result?

See normal incognito NTP

What happens instead?

Omnibox is missing (see screenshot)

https://screenshot.googleplex.com/fD2GDyqKjbi
 
Cc: mdjones@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c459898a1951ee8090812a1ed70716248a1fec3

commit 2c459898a1951ee8090812a1ed70716248a1fec3
Author: twellington <twellington@chromium.org>
Date: Mon May 22 16:22:34 2017

[Home] Add some NTP UI polish

 * Don't show the overview if ChromeTabbedActivity#onStart() if it's
   already showing. This fixes a bug where the toolbar gets set back
   to the tab switcher toolbar even though the bottom sheet is open.
 * Enable omnibox suggestions for the normal NTP UI.
 * Disable the foreground tab creation animation when Chrome Home
   is enabled.

BUG= 724659 ,695973

Review-Url: https://codereview.chromium.org/2900463002
Cr-Commit-Position: refs/heads/master@{#473591}

[modify] https://crrev.com/2c459898a1951ee8090812a1ed70716248a1fec3/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/2c459898a1951ee8090812a1ed70716248a1fec3/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java
[modify] https://crrev.com/2c459898a1951ee8090812a1ed70716248a1fec3/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java
[modify] https://crrev.com/2c459898a1951ee8090812a1ed70716248a1fec3/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Status: Fixed (was: Assigned)

Sign in to add a comment