New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 724645 link

Starred by 1 user
Status: Archived
Owner:
aga...@chromium.org
Closed: Dec 2017
Cc:
█ iannucci@chromium.org
no...@chromium.org
aga...@chromium.org
vadimsh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 722476
Blocking:
issue 663787



Sign in to add a comment

Update everything to git>=2.12 via cipd in depot_tools

Project Member Reported by aga...@chromium.org, May 19 2017 
experiment to use cipd to deploy git to windows folks: https://chromium-review.googlesource.com/c/495632
experiment to use the same for linux: https://chromium-review.googlesource.com/c/506388
now that https://bugs.chromium.org/p/chromium/issues/detail?id=722476 is closed we can try the same for mac

Comment 1 by aga...@chromium.org, May 19 2017 

I've also uploaded https://chromium-review.googlesource.com/c/510056/ to let us generate historical versions of packages (e.g. the mac-*/2.12.2 that we missed while that builder was broken).
Project Member

Comment 2 by bugdroid1@chromium.org, May 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4536fc778b41bf20168b2c91eb91f4a63222e1c1

commit 4536fc778b41bf20168b2c91eb91f4a63222e1c1
Author: Aaron Gable <agable@chromium.org>
Date: Sat May 20 00:56:20 2017

Let third_party_packages build specific git releases

If the "git_release_tag" build property is set, then
the recipe will build that version rather than the latest
version available in the source repo. Only works for Unix,
and only for Git.

R=iannucci@chromium.org

Bug:  724645 
Change-Id: Ic453c74aa1d81173fa08877efa2d08a9146c5040
Reviewed-on: https://chromium-review.googlesource.com/510056
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[add] https://crrev.com/4536fc778b41bf20168b2c91eb91f4a63222e1c1/recipes/recipes/third_party_packages.expected/mac_specific_git_tag.json
[modify] https://crrev.com/4536fc778b41bf20168b2c91eb91f4a63222e1c1/recipes/recipes/third_party_packages.py

Comment 3 by aga...@chromium.org, May 22 2017 

We now have packages of 2.12.2 on all platforms:

> cipd resolve infra/git/ -version 'version:2.12.2.chromium2'                                                                                                             
Packages:
  infra/git/linux-386:30bfd098ab5338fd25eefea8a8181b7035411bda
  infra/git/linux-amd64:59b529444269281c90bff4dc37a2fd92e23f0925
  infra/git/mac-amd64:13b9dc25c50c2a56b92f0c9f106c5a3717d535e5
Errors:
  infra/git/windows-386: package "infra/git/windows-386" doesn't have instance with version "version:2.12.2.chromium2".
  infra/git/windows-amd64: package "infra/git/windows-amd64" doesn't have instance with version "version:2.12.2.chromium2".

> cipd resolve infra/git/ -version 'version:2.12.2.2.chromium2'
Packages:
  infra/git/windows-386:30603b08c35135c4b49a90c76c7dbe3199cf792a
  infra/git/windows-amd64:39ff21d3b7164682e2d69565b6652b9939273e40
Errors:
  infra/git/linux-386: package "infra/git/linux-386" doesn't have instance with version "version:2.12.2.2.chromium2".
  infra/git/linux-amd64: package "infra/git/linux-amd64" doesn't have instance with version "version:2.12.2.2.chromium2".
  infra/git/mac-amd64: package "infra/git/mac-amd64" doesn't have instance with version "version:2.12.2.2.chromium2".


Next steps:
https://chromium-review.googlesource.com/c/495632 and https://chromium-review.googlesource.com/c/506388

Comment 4 by zork@chromium.org, Dec 1 2017

Components: Infra>Platform>CIPD

Comment 5 by aga...@chromium.org, Dec 1 2017

Owner: aga...@chromium.org
Status: Fixed (was: Available)
Everything is currently running 2.15 now.

Comment 6 by dchan@google.com, Jul 30

Status: Archived (was: Fixed)
►

Sign in to add a comment