New issue
Advanced search Search tips

Issue 724637 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Bus in CGifLZWDecoder::AddCode

Project Member Reported by ClusterFuzz, May 19 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6125466154172416

Fuzzer: libfuzzer_pdf_codec_gif_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Bus
Crash Address: 0x62a00002140c
Crash State:
  CGifLZWDecoder::AddCode
  CGifLZWDecoder::Decode
  gif_load_frame
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=423384:423408

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6125466154172416


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Components: Internals>Plugins>PDF
Maybe related to https://bugs.chromium.org/p/chromium/issues/detail?id=654173#c6 ? That bug also notes that the affected codepath isn't enabled.

Comment 2 by wfh@chromium.org, May 19 2017

Cc: tsepez@chromium.org
Owner: npm@chromium.org
Status: Assigned (was: Untriaged)
seems there's a lot of similar bugs in this code. npm@ can you take a look and see if this one might already be fixed?
Project Member

Comment 3 by sheriffbot@chromium.org, May 20 2017

Labels: M-60
Project Member

Comment 4 by sheriffbot@chromium.org, May 20 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, May 20 2017

Labels: Pri-1
Project Member

Comment 6 by ClusterFuzz, May 22 2017

ClusterFuzz has detected this issue as fixed in range 472363:472390.

Detailed report: https://clusterfuzz.com/testcase?key=6125466154172416

Fuzzer: libfuzzer_pdf_codec_gif_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Bus
Crash Address: 0x62a00002140c
Crash State:
  CGifLZWDecoder::AddCode
  CGifLZWDecoder::Decode
  gif_load_frame
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=423384:423408
Fixed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=472363:472390

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6125466154172416


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, May 22 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6125466154172416 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, May 22 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta -Security_Impact-Head Security_Impact-Stable
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 9 2017

Labels: Merge-Request-60
Project Member

Comment 11 by sheriffbot@chromium.org, Jun 9 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by npm@chromium.org, Jun 9 2017

Labels: -Hotlist-Merge-Review -Security_Impact-Stable -Merge-Review-60 Security_Impact-None
Bad bot, merge request not needed because gif is only used in XFA, which is not currently enabled in Chrome.
Project Member

Comment 13 by sheriffbot@chromium.org, Aug 28 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment