New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 724636 link

Starred by 1 user
Status: Verified
Owner:
█ peterlaurens@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Sad Tab page bullet points are not indented properly when line wrapped

Project Member Reported by pkl@chromium.org, May 19 2017 
App Version (from "Chrome Settings > About Chrome"): 60.0.3104.0 canary
iOS Version: 10.3.2
Device: iPhone 5S

Steps to reproduce: 
Set your device to a language with longer translations, e.g. French.
Generate a sad tab with browsingtest.appspot.com/venti.html
The second bullet "Ouvrez la page en mode navigation privée" is longer than the screen width, so it line wrapped to a second line. But the 2nd line of text is not properly aligned to the first line. See screenshot attached.

Observed behavior: 

Expected behavior: 

Frequency: 
<number of times you were able to reproduce> 

Additional comments:
IMG_0801.PNG
46.4 KB View Download

Comment 1 by peterlaurens@chromium.org, May 19 2017 

I think we can get better control over indentation here with a UITextView (currently this is just a label) and configuring the NSTextContainer's paragraph styles (https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/TextUILayer/Tasks/SetTextMargins.html).

Comment 2 by jasonkliu@chromium.org, May 19 2017

Components: UI>Internationalization

Comment 3 by peterlaurens@chromium.org, May 25 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cff1e1836ec5a28bc4a31913ef6d22d62c9e2842

commit cff1e1836ec5a28bc4a31913ef6d22d62c9e2842
Author: peterlaurens <peterlaurens@chromium.org>
Date: Tue May 30 18:04:10 2017

Use UITextView for better bulleted list presentation

BUG= 724636 
TEST=Navigating to a page that fails to load twice in a row should present a bulleted list of suggestions for the user to try. However this list on small screened devices, and in certain localizations can lay out the bulleted text in a non aligned manner.

Specifically iPhone 5/5S/5SE, in French, is known to do this.

This change should align the left of the text blocks, and not allow the text to wrap just to the bullet indentation.

Review-Url: https://codereview.chromium.org/2905953003
Cr-Commit-Position: refs/heads/master@{#475594}

[modify] https://crrev.com/cff1e1836ec5a28bc4a31913ef6d22d62c9e2842/ios/chrome/browser/ui/sad_tab/sad_tab_view.mm

Comment 5 by peterlaurens@chromium.org, May 30 2017

Status: Fixed (was: Started)

Comment 6 by subhashi...@chromium.org, Jun 7 2017

Status: Verified (was: Fixed)
Verified this issue on:

App Version: 61.0.3123.0 canary
Device: iPhone 5S
iOS Version: 10.2.1

Issue is fixed. Device language was set to 'French' and generated a sad tab with browsingtest.appspot.com/venti.html , Text on second line is aligned properly. Please see the screenshot attached. Hence marking this bug as 'Verified'.
SadTab_french.PNG
59.9 KB View Download
►

Sign in to add a comment