Minor rebaseline-cl usage change: prompt to try filling in missing results. |
|||
Issue descriptionCurrently, if there are some try bots with no results, e.g. one of the try jobs failed, "webkit-patch rebaseline-cl" will abort. One has to pass --fill-missing (and possibly --no-trigger-jobs) in order to get it to continue and try to use results from bots with results. It would probably be nicer if the tool prompted one to try --fill-missing (and warned about possible problems) without one having to re-invoke the tool.
,
May 26 2017
Just tested this out on a real change (https://chromium-review.googlesource.com/513527) and the behavior was incorrect: Would you like to try to fill in missing results with available results? This assumes that layout test results for the platforms with missing results are the same as results on other platforms. [y/N]: y Aborting. But after trying again, it worked; It seems like this might have been because I accidentally added a space before pressing enter. The User.confirm() method isn't very tolerant of accidentally adding spaces. Uploaded https://chromium-review.googlesource.com/517434 to fix this.
,
May 26 2017
,
May 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbb248a23fbf31019a4612268577b0b2371b2aa4 commit dbb248a23fbf31019a4612268577b0b2371b2aa4 Author: Quinten Yearsley <qyearsley@google.com> Date: Mon May 29 19:56:07 2017 In User.confirm, allow responses like "y " or "yes" to mean yes. Bug: 724635 Change-Id: Ib4e6422c69b6c6093b8822cd724d93451efbc884 Reviewed-on: https://chromium-review.googlesource.com/517434 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#475377} [modify] https://crrev.com/dbb248a23fbf31019a4612268577b0b2371b2aa4/third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py [modify] https://crrev.com/dbb248a23fbf31019a4612268577b0b2371b2aa4/third_party/WebKit/Tools/Scripts/webkitpy/common/system/user_unittest.py
,
May 30 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, May 26 2017