New issue
Advanced search Search tips

Issue 724633 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Analyze should use delta between patch sets (retry only failing steps/tests)

Project Member Reported by danakj@chromium.org, May 19 2017

Issue description

1. Upload patch set 1, run bots.
2. See everything pass except one test step.
3. Upload patch set 2 to fix step, which modifies small part of CL.
4. See CQ run every test step again, instead of only the ones that failed in step 2 + the ones affected by the delta from patch set 1 and patch set 2.

This could significantly speed up the commit queue and reduce load.
 

Comment 1 by danakj@chromium.org, May 19 2017

The same could apply to multiple CQ attempts on a single patch set, only previously failed steps need to be run.

Comment 2 by danakj@chromium.org, May 19 2017

Description: Show this description
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
That's actually a non-trivial feature because it's nowhere trivial to predict what should be affected by delta you mentioned in light of potentially changing master with passage of time.

This is currently not on our roadmap because it requires a good design doc and a person owning this through several quarters. 
Components: -Infra>CQ Infra>Client>Chrome
Summary: Analyze should use delta between patch sets (retry only failing steps/tests) (was: Analyze should use delta between patch sets)
See https://docs.google.com/a/google.com/document/d/1i0OxqLm6BpSrDge6EXjjNgBtVE0vxEfRlbCcZuNq_Ac/edit?usp=sharing for a doc I wrote about this in 2015.

Agreed about benefits, and yeah - it'd be great to make that happen.

Comment 5 by danakj@chromium.org, May 23 2017

It would be a good first pass to ignore master and just include the diff between the master at which each patchset was run when running analyze. That would be a huge improvement over run everything.
Project Member

Comment 6 by sheriffbot@chromium.org, May 24 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Still potentially useful. But still not on our road-map. Back into our backlog it goes.

Sign in to add a comment