New issue
Advanced search Search tips

Issue 724628 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Sign in to add a comment

Make libc++ as default c++ lib for llvm

Project Member Reported by manojgupta@chromium.org, May 19 2017

Issue description

We want to move to libc++ instead of using libstdc++ from gcc in llvm.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e9ebefa28aaae1a834532e2a82765ae3b2a5a262

commit e9ebefa28aaae1a834532e2a82765ae3b2a5a262
Author: Manoj Gupta <manojgupta@google.com>
Date: Sun May 21 02:04:24 2017

Enable exceptions when building libcxxabi.

BUG= chromium:724628 
TEST=emerge-kevin libcxxabi works.

Change-Id: I666343dc1c3c87d44b6e8364ca7580a6cc8d7ff0
Reviewed-on: https://chromium-review.googlesource.com/509971
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/e9ebefa28aaae1a834532e2a82765ae3b2a5a262/chromeos/config/env/sys-libs/libcxxabi

Project Member

Comment 2 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7fd381e75aa3e402e0a40d13351ebc4151079331

commit 7fd381e75aa3e402e0a40d13351ebc4151079331
Author: Manoj Gupta <manojgupta@google.com>
Date: Tue May 23 15:27:02 2017

Fix ABI handling in libcxx/libcxxabi/llvm-libunwind.

Move ABI setup to cros-llvm eclass. Use multilib_env to set ABI env variables.
Use flags -stdlib=libstdc++ so that libcxx/libcxxabi can be installed
in a board's sysroot when libc++ is set as default in llvm.

Does not impact current llvm as libc++ is not default.

BUG= chromium:724628 
TEST=equery f cross-{armv7a, x86_64, aarch64}-cros-linux-gnu/libcxx shows packages installed
correctly.
TEST={armv7a, x86_64, aarch64}-cros-linux-gnu-clang++ -stdlib=libc++ work on simple c++ files.

Change-Id: I074d96b656fd01fc7dc69e1896e1c85c29733dcb
Reviewed-on: https://chromium-review.googlesource.com/509148
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>

[rename] https://crrev.com/7fd381e75aa3e402e0a40d13351ebc4151079331/sys-libs/libcxxabi/libcxxabi-4.0.0-r3.ebuild
[modify] https://crrev.com/7fd381e75aa3e402e0a40d13351ebc4151079331/eclass/cros-llvm.eclass
[rename] https://crrev.com/7fd381e75aa3e402e0a40d13351ebc4151079331/sys-libs/llvm-libunwind/llvm-libunwind-5.0_pre300080-r2.ebuild
[rename] https://crrev.com/7fd381e75aa3e402e0a40d13351ebc4151079331/sys-libs/libcxx/libcxx-4.0.0-r3.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/fb2aa3d1725890117bcc7aa8c2d6b250a3617db3

commit fb2aa3d1725890117bcc7aa8c2d6b250a3617db3
Author: Manoj Gupta <manojgupta@google.com>
Date: Mon Jun 26 10:28:03 2017

Include <pthread.h> to avoid compile errors in audiotest.

When using libc++, pthread.h does not get indirectly included.
Fixes compilation errors related to pthread.

In file included from /mnt/host/source/src/platform/audiotest/src/alsa_client.cc:5:
/mnt/host/source/src/platform/audiotest/include/alsa_client.h:77:5: error: use of undeclared identifier 'pthread_mutex_unlock'
     pthread_mutex_unlock(&mutexes_[last]);
    ^

BUG= chromium:724628 
TEST=audiotest compiles with libc++ enabled.

Change-Id: I6b72667fc419149e074fa92c072e27461fb92567
Reviewed-on: https://chromium-review.googlesource.com/547777
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/fb2aa3d1725890117bcc7aa8c2d6b250a3617db3/include/common.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/gestures/+/54e252222113e235f9e16e62769a629c5fa5f8c5

commit 54e252222113e235f9e16e62769a629c5fa5f8c5
Author: Manoj Gupta <manojgupta@google.com>
Date: Mon Jun 26 10:28:04 2017

Include <cmath> explicitly to avoid compile errors in gestures.

<cmath> header is not indirectly included with libc++.
Fixes a compilation error when using libc++ in clang.

In file included from src/finger_metrics.cc:5:
../gestures/include/finger_metrics.h:38:12: error: use of undeclared identifier 'sqrtf'
     return sqrtf(MagSq());
            ^

BUG= chromium:724628 
TEST=gestures compiles with libc++ enabled in clang.

Change-Id: Id28ed62819af5b8d7617f3f12ba300988fee61a3
Reviewed-on: https://chromium-review.googlesource.com/547739
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/54e252222113e235f9e16e62769a629c5fa5f8c5/include/finger_metrics.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dm-verity/+/1f3bea35a57fafd75ac010eae078a256a3eda25e

commit 1f3bea35a57fafd75ac010eae078a256a3eda25e
Author: Manoj Gupta <manojgupta@google.com>
Date: Tue Jun 27 17:55:49 2017

Fix compiler errors when using libc++ in verity.

Rename macros min,max and to_bytes.
min and max macros are no longer allowed in c++.
to_bytes conflict with a header function in <locale>.

Fixes compilation errors:
/build/caroline/usr/include/c++/v1/locale:3596:48: error: too many arguments
verity-9999:       provided to function-like macro invocation
verity-9999:     byte_string to_bytes(const _Elem* __first, const _Elem* __last);
verity-9999: /mnt/host/source/src/platform/verity/include/linux/device-mapper.h:31:9: note:
verity-9999:       macro 'to_bytes' defined here
verity-9999: #define to_bytes(x) ((x) << SECTOR_SHIFT)

verity-9999: /build/caroline/usr/include/c++/v1/__undef_min_max:17:2: error: macro min is
verity-9999:       incompatible with C++. #undefing min [-Werror,-W#warnings]
verity-9999: #warning: macro min is incompatible with C++.  #undefing min
verity-9999: /build/caroline/usr/include/c++/v1/__undef_min_max:29:2: error: macro max is
verity-9999:       incompatible with C++. #undefing max [-Werror,-W#warnings]
verity-9999: #warning: macro max is incompatible with C++.  #undefing max

BUG= chromium:724628 
TEST=verity compiles.

Change-Id: I709edbe48085c3dd692037957f9139010e9e5844
Reviewed-on: https://chromium-review.googlesource.com/547454
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>

[modify] https://crrev.com/1f3bea35a57fafd75ac010eae078a256a3eda25e/dm-bht_unittest.cc
[modify] https://crrev.com/1f3bea35a57fafd75ac010eae078a256a3eda25e/include/linux/kernel.h
[modify] https://crrev.com/1f3bea35a57fafd75ac010eae078a256a3eda25e/dm-bht.c
[modify] https://crrev.com/1f3bea35a57fafd75ac010eae078a256a3eda25e/file_hasher.cc
[modify] https://crrev.com/1f3bea35a57fafd75ac010eae078a256a3eda25e/include/linux/device-mapper.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mttools/+/0df724d840f30f230e9c238a4d57d75f7cfe7e6f

commit 0df724d840f30f230e9c238a4d57d75f7cfe7e6f
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed Jun 28 12:15:22 2017

Fix mttools to build with libc++.

Remove an unused libstdc++ GNU extension header file.

BUG= chromium:724628 
TEST=mttools compile.

Change-Id: I20f2986592b5ee4469f16dfb18cd6e31184ab6b7
Reviewed-on: https://chromium-review.googlesource.com/551837
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/0df724d840f30f230e9c238a4d57d75f7cfe7e6f/mtreplay/src/stream.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/94df77cd958bb666b0234dd1a16774ec206e532c

commit 94df77cd958bb666b0234dd1a16774ec206e532c
Author: Manoj Gupta <manojgupta@google.com>
Date: Fri Jul 14 05:03:35 2017

Add helper function to disable libc++ in clang.

Add helper function to force use of libstdc++ instead of libc++
when building with clang.

BUG= chromium:724628 
TEST=OpenCV builds by calling this helper function.
It was failing to build with libc++ enabled.

Change-Id: I1b15e14b1bed1b90cdbb956762ea273e98e59905
Reviewed-on: https://chromium-review.googlesource.com/566035
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/94df77cd958bb666b0234dd1a16774ec206e532c/profiles/base/profile.bashrc

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a8020c8b813b93dbfd167bccf9212bef4214b870

commit a8020c8b813b93dbfd167bccf9212bef4214b870
Author: Manoj Gupta <manojgupta@google.com>
Date: Sat Jul 15 03:13:55 2017

GCC Wrapper: Force use of libstdc++ in clang syntax-check only mode.

When libc++ is default in clang but package is compiled with GCC,
There are hard to fix warnings because clang is using libc++ headers.
Force clang to use libstdc++ haeaders in syntax-check only mode.

BUG= chromium:724628 
TEST=Extra warnings when building vboot_reference are gone.

Change-Id: Ib4adc2ecaf8d2724479a36d1c0acba8c5186d7ba
Reviewed-on: https://chromium-review.googlesource.com/572082
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/a8020c8b813b93dbfd167bccf9212bef4214b870/sys-devel/gcc/files/sysroot_wrapper.hardened.body
[rename] https://crrev.com/a8020c8b813b93dbfd167bccf9212bef4214b870/sys-devel/gcc/gcc-4.9.2-r162.ebuild

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c229ca617daaeac4dfc08dbba525d1676ff4a63c

commit c229ca617daaeac4dfc08dbba525d1676ff4a63c
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Jul 20 15:00:11 2017

authpolicy: Fix constexpr usage to be able to build with libc++.

std::make_pair requires minimum std=c++14 to be able to return constexpr
and libc++ enforces this restriction.
As platform libs are targeted to use gnu++11 std, change constexpr to const
at a few places to avoid compilation errors when using libc++.

src/platform2/authpolicy/samba_interface.cc:67:32: error: constexpr variable
'kDirsAndMode' must be initialized by a constant expression
constexpr std::pair<Path, int> kDirsAndMode[] = {
                               ^                ~
../../../../../../../../../mnt/host/source/src/platform2/authpolicy/samba_interface.cc:68:5: note: non-constexpr constructor
'pair<authpolicy::Path, const int &, false>' cannot be used in a constant expression
    {Path::TEMP_DIR, kFileMode_rwxrx},
    ^
../../../../../../../usr/include/c++/v1/utility:436:5: note: declared here
    pair(_U1&& __u1, _U2&& __u2)
    ^

src/platform2/authpolicy/policy/device_policy_encoder.cc:23:39: error: constexpr variable
'kConnectionTypes' must be initialized by a constant expression
constexpr std::pair<const char*, int> kConnectionTypes[] = {
                                      ^                    ~
src/platform2/authpolicy/policy/device_policy_encoder.cc:24:5: note: non-constexpr
constructor 'pair<const char *, enterprise_management::AutoUpdateSettingsProto_ConnectionType, false>' cannot be used in a constant
expression
    std::make_pair(
    ^
../../../../../../../usr/include/c++/v1/utility:464:5: note: declared here
    pair(pair<_U1, _U2>&& __p)
    ^

BUG= chromium:724628 
TEST=authpolicy compiles with libc++.

Change-Id: I64cfac3d8942173e89b0fe5dd5d25b1fc5bf669d
Reviewed-on: https://chromium-review.googlesource.com/578449
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>

[modify] https://crrev.com/c229ca617daaeac4dfc08dbba525d1676ff4a63c/authpolicy/policy/device_policy_encoder.cc
[modify] https://crrev.com/c229ca617daaeac4dfc08dbba525d1676ff4a63c/authpolicy/samba_interface.cc

Labels: libc
Blockedon: 747030
Blockedon: 747040
Labels: -libc libcxx
Blockedon: 747053
Blockedon: 747060
Blockedon: 747106
Blockedon: 747113
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/dc3ce15a9209caf0d4728eb81f3d2c1fea6b489e

commit dc3ce15a9209caf0d4728eb81f3d2c1fea6b489e
Author: Manoj Gupta <manojgupta@google.com>
Date: Fri Jul 21 04:21:24 2017

Fix glmark2 build when using libc++ in clang.

clang with libc++ does not like using void* function pointer with sqrt.
Update waflib config to detect sqrt function using the correct
c++ function pointer syntax for sqrt.

BUG= chromium:724628 
TEST=glmark2 builds when using libc++.

Change-Id: Icf0606f7448fa82e0f4d1d723677c3231340e6b2
Reviewed-on: https://chromium-review.googlesource.com/570937
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[add] https://crrev.com/dc3ce15a9209caf0d4728eb81f3d2c1fea6b489e/app-benchmarks/glmark2/files/glmark2-libcxx.patch
[modify] https://crrev.com/dc3ce15a9209caf0d4728eb81f3d2c1fea6b489e/app-benchmarks/glmark2/glmark2-285.ebuild
[rename] https://crrev.com/dc3ce15a9209caf0d4728eb81f3d2c1fea6b489e/app-benchmarks/glmark2/glmark2-285-r11.ebuild

Blockedon: 747561
Blockedon: 747600
Blockedon: 747613
Blockedon: 747618
Blockedon: 747696
Blockedon: 747697
Blockedon: 748474
Project Member

Comment 26 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/df6ddecab23b465d8aa64eaab05a7217434a9e23

commit df6ddecab23b465d8aa64eaab05a7217434a9e23
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed Jul 26 11:15:03 2017

libc++: Install libc++ libraries as part of sdk.

libc++ libraries should be installed in sdk so
that clang can compile packages with libc++.
This CL only adds the libc++ package to SDK for building.
Does not impact current compilation settings.

BUG= chromium:724628 
TEST=sudo emerge target-chromium-os-sdk builds libcxxabi and libcxx.

Change-Id: I1dd9d305caaaf6ee82686857aa5ab8cfffd87294
Reviewed-on: https://chromium-review.googlesource.com/585222
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>

[modify] https://crrev.com/df6ddecab23b465d8aa64eaab05a7217434a9e23/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1.ebuild
[rename] https://crrev.com/df6ddecab23b465d8aa64eaab05a7217434a9e23/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1-r79.ebuild

Status: Started (was: Untriaged)
Blockedon: 750831
Project Member

Comment 29 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/20cfc6ce4fcc152f5df83deeb49eb82abbf6250c

commit 20cfc6ce4fcc152f5df83deeb49eb82abbf6250c
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Aug 03 01:52:52 2017

Add libcxx and libcxxabi to host toolchain packages.

libcxx and libcxxabi need to be installed for host package
compilation with clang + libc++.

BUG= chromium:724628 
TEST=libcxx packages are pulled in when running cros_setup_toolchain

CQ-DEPEND=CL:595187

Change-Id: I662f7ff25f5851375a4a3b784db297b84e450019
Reviewed-on: https://chromium-review.googlesource.com/578137
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/20cfc6ce4fcc152f5df83deeb49eb82abbf6250c/scripts/cros_setup_toolchains.py

Project Member

Comment 30 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/4d1546989bf47666b42d7450688e27ab9b78b842

commit 4d1546989bf47666b42d7450688e27ab9b78b842
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Aug 03 05:13:30 2017

update_chroot: Add libcxxabi and libcxx

Add libcxxabi and libcxx to list of toolchain packages to update
when new binaries are available.

BUG= chromium:724628 
TEST=libcxx and libcxxabi packages are upgraded when running update_chroot.

Change-Id: If1e590620dd6053af0e725865eae0155cabdda2b
Reviewed-on: https://chromium-review.googlesource.com/599107
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/4d1546989bf47666b42d7450688e27ab9b78b842/update_chroot

Project Member

Comment 31 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/23f0d584ed27a73c692db7b7c5b016b91218e1ab

commit 23f0d584ed27a73c692db7b7c5b016b91218e1ab
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Aug 03 08:11:03 2017

Remove libcxxabi and libcxx from target sdk packages.

libcxxbi and libcxx are already built as part of toolchain packages.
So no need to be present in target-chromium-os-sdk.

BUG= chromium:724628 
TEST=libcxx and libcxxabi not listed in emerge target-sdk -e -pv.

Change-Id: I4e05f937ee1ef207b32fcc93eaec9dde9bdd5b9a
Reviewed-on: https://chromium-review.googlesource.com/599118
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/23f0d584ed27a73c692db7b7c5b016b91218e1ab/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1-r80.ebuild
[modify] https://crrev.com/23f0d584ed27a73c692db7b7c5b016b91218e1ab/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1.ebuild

Project Member

Comment 32 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/dd5103748da322cb9185aa4e226efd5b1c3811d5

commit dd5103748da322cb9185aa4e226efd5b1c3811d5
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Aug 03 22:58:51 2017

Add libcxxabi and libcxx to target sdk packages again.

libcxx package needs to be a part of target-sdk. If not,
libc++ tryjob fails SDKTest because of missing libc++ libraries in sdk.
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/chromiumos-sdk/builds/2430/

BUG= chromium:724628 
TEST=libcxx is installed in emerge target-sdk -e -pv

Change-Id: Iabfa106e4e2fed60dbfb4298561dff9c43e99f99
Reviewed-on: https://chromium-review.googlesource.com/600387
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[rename] https://crrev.com/dd5103748da322cb9185aa4e226efd5b1c3811d5/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1-r81.ebuild
[modify] https://crrev.com/dd5103748da322cb9185aa4e226efd5b1c3811d5/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1.ebuild

Blockedon: 752377
Blockedon: 752392
Blockedon: 753548
Project Member

Comment 36 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1e8d3c8ffc36180d6de2e66a74c87903f52dc8f3

commit 1e8d3c8ffc36180d6de2e66a74c87903f52dc8f3
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Aug 10 04:46:11 2017

cros-llvm eclass: Use clang wrapper for host builds.

Change host compiler to ${CBUILD}-clang(++) from clang(++).

BUG= chromium:724628 
TEST=host sys-libs/libcxxabi builds with x86_64-pc-linux-gnu-clang.

Change-Id: I941d07ad0ffc35ce8c9c7ac279372b9aec8f6a1f
Reviewed-on: https://chromium-review.googlesource.com/607409
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>

[modify] https://crrev.com/1e8d3c8ffc36180d6de2e66a74c87903f52dc8f3/eclass/cros-llvm.eclass

Project Member

Comment 37 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bac5855a5ff49bd8a14c8c0aaf328f62ca59794b

commit bac5855a5ff49bd8a14c8c0aaf328f62ca59794b
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Aug 10 04:46:14 2017

crash: Remove setfill() in istream.

Discovered this when building with libc++.
setfill() is applicable only for ostreams. It was being used
in istringstream and libc++ rightfully complained about it.
The unit tests still pass with call to setfill removed.

BUG= chromium:724628 
TEST=crash-reporter unit tests pass with/without libc++.

Change-Id: I4c137418db2d149ffa16d7f8e611d97fa9727612
Reviewed-on: https://chromium-review.googlesource.com/608586
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/bac5855a5ff49bd8a14c8c0aaf328f62ca59794b/crash-reporter/arc_collector_test.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/gestures/+/a09254620ff6c833a39b3d50c1b8207aa4326839

commit a09254620ff6c833a39b3d50c1b8207aa4326839
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Aug 10 10:27:21 2017

gestures: Stop using tr1 headers.

Using tr1 headers is not required with c++11 standard. gestures is already
compiled with std=gnu++11. This fixes a build issue with libc++ when
building gestures with unit tests.

BUG= chromium:724628 
TEST=gestures unit tests pass with/without libc++.

Change-Id: Iaa2de1db2a576991fc17a5c180d214b453366a6a
Reviewed-on: https://chromium-review.googlesource.com/609410
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a09254620ff6c833a39b3d50c1b8207aa4326839/include/activity_replay.h
[modify] https://crrev.com/a09254620ff6c833a39b3d50c1b8207aa4326839/src/activity_replay.cc

Blockedon: 754549
Project Member

Comment 40 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dm-verity/+/46ad6cc75f4ad98b64097cdf7f8d1233169acf69

commit 46ad6cc75f4ad98b64097cdf7f8d1233169acf69
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed Aug 16 09:06:00 2017

verity: Fix unit test issue with libc++

class Message in logging inherits from ostream which libc++
dislikes since ostream class has a private constructor. Inspection
showed no reason to inherit ostream. Message class only needs
to overload the "<<" operator for logging. So move the already
defined "<<" operator function inside the class.
Remove stream() function and update the macros.

BUG= chromium:724628 
TEST=verity unit tests pass with/without libc++.

Change-Id: Ia854f11287fdf3789844540da49ea6eb969a7b40
Reviewed-on: https://chromium-review.googlesource.com/614871
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/46ad6cc75f4ad98b64097cdf7f8d1233169acf69/logging/logging.h

Labels: -Pri-3 Pri-1
Blockedon: 756253
Labels: -Pri-1 Pri-2
Blockedon: 756528
Blockedon: 756588
Blockedon: 757753
Blockedon: 759342
Blockedon: 759455
Blockedon: 761172
Blockedon: 762199
Project Member

Comment 51 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/a129ccbb8bff2f198bddf3197982381cd2d2a720

commit a129ccbb8bff2f198bddf3197982381cd2d2a720
Author: Manoj Gupta <manojgupta@google.com>
Date: Fri Sep 15 07:24:08 2017

adhd: Fix build failure with libc++.

Use of std::max/min needs <algorithm> header file.

This fixes the following errors when libc++ is enabled as default:
tests/dev_io_stubs.cc:129:28: error: no member named 'min' in namespace 'std'
   dev->min_cb_level = std::min(stream->rstream->cb_threshold,
                       ~~~~~^
tests/dev_io_stubs.cc:131:28: error: no member named 'max' in namespace 'std'
  dev->max_cb_level = std::max(stream->rstream->cb_threshold,
                      ~~~~~^
Fail log:
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_toolchain/builds/304/steps/UnitTest/logs/stdio

BUG= chromium:724628 
TEST=adhd unit tests build.

Change-Id: I0953f68d9ca7fd773f847de0be56f928dbeb6778
Reviewed-on: https://chromium-review.googlesource.com/667793
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/a129ccbb8bff2f198bddf3197982381cd2d2a720/cras/src/tests/dev_io_stubs.cc

Project Member

Comment 52 by bugdroid1@chromium.org, Sep 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/94ada0e9b0effe67094edc4d6c0546e591b8d72d

commit 94ada0e9b0effe67094edc4d6c0546e591b8d72d
Author: Manoj Gupta <manojgupta@google.com>
Date: Sat Sep 16 04:25:41 2017

google-breakpad: Don't force libstdc++ on host for 32-bit.

libc++ 32-bit libraries are now available on host. So no need to
force libstdc++ in clang.

BUG= chromium:724628 
TEST=google-breakpad builds on host.

Change-Id: I059b174ac503d6ed38415aea9d9ac34b1c153f40
Reviewed-on: https://chromium-review.googlesource.com/668575
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/94ada0e9b0effe67094edc4d6c0546e591b8d72d/chromeos-base/google-breakpad/google-breakpad-9999.ebuild

Blockedon: 766252
Project Member

Comment 54 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ea9a50bd41877f3dc434dadd37faf42fca861aaa

commit ea9a50bd41877f3dc434dadd37faf42fca861aaa
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Sep 21 15:05:40 2017

libcontainer: Fix a buffer overflow in libcontainer_unittest

Caught this when testing libc++.
libcontiner _EXPECT macros copies the arguments to a long long type.
This is insufficient for any type with sizeof(type) > sizeof(long long).
Fix this in the unittest by doing a string comparison.

BUG= chromium:724628 
TEST=libcontainer Unit tests pass.

Change-Id: I9412a6f7b0eb0a505af2dbe5416c15044b6e40b7
Reviewed-on: https://chromium-review.googlesource.com/676876
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/ea9a50bd41877f3dc434dadd37faf42fca861aaa/libcontainer/libcontainer_unittest.cc

Blockedon: 769006
Blockedon: 769439
Blockedon: 769528
Project Member

Comment 58 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3c6389b563d6897f11afb118fd0e7cc8d170dbef

commit 3c6389b563d6897f11afb118fd0e7cc8d170dbef
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed Oct 11 02:49:37 2017

libc++: Add gcc-libs dependency for non cros_host builds.

Building libc++ libraries need system headers. These are provided by gcc-libs
package on target builds so add it as a dependency.

BUG= chromium:724628 
BUG= chromium:769439 
TEST=emerge-kevin -e libcxx pulls in gcc-libs.

Change-Id: Iedeb9c982747bd8674ae112ac47745e28f5d45e7
Reviewed-on: https://chromium-review.googlesource.com/710216
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3c6389b563d6897f11afb118fd0e7cc8d170dbef/sys-libs/libcxxabi/libcxxabi-9999.ebuild
[rename] https://crrev.com/3c6389b563d6897f11afb118fd0e7cc8d170dbef/sys-libs/libcxx/libcxx-4.0.0-r10.ebuild

Project Member

Comment 59 by bugdroid1@chromium.org, Oct 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/150e5b2d0381a69bd8b89b0ea037a103814825be

commit 150e5b2d0381a69bd8b89b0ea037a103814825be
Author: Manoj Gupta <manojgupta@google.com>
Date: Sat Oct 14 02:43:03 2017

libc++: Add lib++ lib dependency in ChromeOS.

We want to build chrome with libc++. To do so, add libc++
libraries to implicit-system dependencies.

BUG= chromium:724628 
BUG= chromium:769439 
TEST=./build_packages builds libc++abi/libc++ packages.

Change-Id: Iaa7ea27c0167c26c00ccf9a32bad7d4d7a28230d
Reviewed-on: https://chromium-review.googlesource.com/510029
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/150e5b2d0381a69bd8b89b0ea037a103814825be/virtual/implicit-system/implicit-system-1.ebuild
[rename] https://crrev.com/150e5b2d0381a69bd8b89b0ea037a103814825be/virtual/implicit-system/implicit-system-1-r2.ebuild

Project Member

Comment 60 by bugdroid1@chromium.org, Oct 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/8714140f60ad3fc56a44c0a58d5ffdabd15df116

commit 8714140f60ad3fc56a44c0a58d5ffdabd15df116
Author: Manoj Gupta <manojgupta@google.com>
Date: Sat Oct 14 10:18:32 2017

libc++: Install libc++ libraries during setup_board.

To be able to build packages with libc++, libc++ libraries
must be installed during setup_board stage.

BUG= chromium:724628 
TEST=./setup_board --board={daisy/peppy} installed libc++ libraries.
CQ-DEPEND=CL:710216

Change-Id: I7bece2ea623f8a40f92c2ab230df08157eb3b19b
Reviewed-on: https://chromium-review.googlesource.com/574646
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8714140f60ad3fc56a44c0a58d5ffdabd15df116/setup_board

Project Member

Comment 61 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/dc70f35175bc4fea0cc0d75f2e3916ce3aa21ad7

commit dc70f35175bc4fea0cc0d75f2e3916ce3aa21ad7
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed Oct 25 07:24:53 2017

Chrome: Build with libc++.

To start supporting C++14 features and cfi on Chrome, chrome must
be built with libc++.
This CL only builds Chrome with libc++. Performance and regression testing across
with libc++ is fine.

BUG= chromium:724628 
BUG= chromium:769439 

TEST=Chrome with libc++ was mostly tested at:
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_toolchain
and the results (incl HWTests) look ok. None of the fails in the tryjobs are related
to Chrome/libc++ but are because of other transient issues.

Logs for different boards are at:
https://docs.google.com/a/google.com/spreadsheets/d/1dg-N1Mzs-KMb2n8h3RA1fhhqRYja9PTO6FfXkZivtjo/edit?usp=sharing

Change-Id: I2db24649af71ba82c18ad25681479dda9b871b69
Reviewed-on: https://chromium-review.googlesource.com/717537
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>

[modify] https://crrev.com/dc70f35175bc4fea0cc0d75f2e3916ce3aa21ad7/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Blocking: 779455
Blocking: -779455
Blockedon: 779455
Blockedon: 779863
Project Member

Comment 66 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ae0ad67c6084f81f13214253d4e8cbf80e849238

commit ae0ad67c6084f81f13214253d4e8cbf80e849238
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed Nov 08 01:52:14 2017

Powertop: Remove forced libstdc++.

Powertop can be built with libc++ with CL:752008.
So remove forced  libstdc++ use.

BUG=b:63890677
BUG= chromium:724628 
TEST=powertop builds with libc++ in clang.
CQ-DEPEND=CL:752008

Change-Id: I6d9d6c997fef3056d9f16d3247b1dd902351affd
Reviewed-on: https://chromium-review.googlesource.com/752569
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ae0ad67c6084f81f13214253d4e8cbf80e849238/chromeos/config/env/sys-power/powertop

Project Member

Comment 67 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/5aaa3d8dce58d34ce892ca68057019cb4a174ef0

commit 5aaa3d8dce58d34ce892ca68057019cb4a174ef0
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed Nov 08 01:52:14 2017

powertop: Fix build with libc++.

powertop didn't build with libc++ because of missing <ctime>
include. Add it as a patch to make it work with libc++.

Upstream pull request: https://github.com/fenrus75/powertop/pull/27

BUG=b:63890677
BUG= chromium:724628 
TEST=powertop builds with libc++.
CQ-DEPEND=CL:752569
Change-Id: I8073db198abde31e3e5b22f042230678738ddfe9
Reviewed-on: https://chromium-review.googlesource.com/752008
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>

[add] https://crrev.com/5aaa3d8dce58d34ce892ca68057019cb4a174ef0/sys-power/powertop/files/powertop-2.8-libcxx.patch
[rename] https://crrev.com/5aaa3d8dce58d34ce892ca68057019cb4a174ef0/sys-power/powertop/powertop-2.8-r1.ebuild

Blockedon: 792615
Components: Infra
Components: -Infra Infra>Client>ChromeOS
[It appears that a bunch of old cros issues bulk-added the "Infra" component recently, but they should probably be "Infra>Client>ChromeOS".]
Components: -Infra>Client>ChromeOS
Project Member

Comment 72 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/ap-daemons/+/47cbaaed2c205f1e22547450fb9b1e966647cd39

commit 47cbaaed2c205f1e22547450fb9b1e966647cd39
Author: Manoj Gupta <manojgupta@google.com>
Date: Fri Jan 12 11:27:24 2018

Blockedon: 801595
Blockedon: 801681
Blockedon: 802091
Project Member

Comment 76 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c9ee36c0f8b0d9448bf2328df03bc25671b6992b

commit c9ee36c0f8b0d9448bf2328df03bc25671b6992b
Author: Manoj Gupta <manojgupta@google.com>
Date: Sat Jan 20 04:35:40 2018

lld: Detect the c++ library used in llvm.

This is hack just to ensure that we can build
lld when llvm is linked with either of libc++ or libstdc++.

Remove this hack when everything is moved to libc++.

BUG= chromium:801681 
BUG= chromium:724628 

TEST=sudo emerge lld works when clang uses libc++ as default.

Change-Id: Id128ce1f0807ca877bb904a212dd392167796622
Reviewed-on: https://chromium-review.googlesource.com/864493
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/c9ee36c0f8b0d9448bf2328df03bc25671b6992b/sys-devel/lld/lld-6.0_pre317203-r2.ebuild

Project Member

Comment 77 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/00e3bc5f580d1c79ab322c9893d4b8bd80180bad

commit 00e3bc5f580d1c79ab322c9893d4b8bd80180bad
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed Jan 24 04:00:29 2018

llvm/clang: Use libc++ as the default C++ library in ChromeOS.

Migrate Clang on ChromeOS to use libc++ as the default C++ library
instead of libstdc++. Post this change, libstdc++ usage should be mostly
limited to 32-bit packages and packages that still use GCC.

BUG= chromium:724628 
TEST=Toolchain team rotating builder testing.
TEST=chromiumos-sdk build passed.
Detailed test logs:
https://docs.google.com/spreadsheets/d/19-zSY0fpUDZ5ACuYRyY63xfDrQoLsjylwEpSkDpWAXQ/edit?usp=sharing

Change-Id: Iff568f26562db2c95a097942653623fd4c3039fa
Reviewed-on: https://chromium-review.googlesource.com/812956
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>

[rename] https://crrev.com/00e3bc5f580d1c79ab322c9893d4b8bd80180bad/sys-devel/clang/clang-6.0_pre317203_p20180123.ebuild
[rename] https://crrev.com/00e3bc5f580d1c79ab322c9893d4b8bd80180bad/sys-devel/llvm/llvm-6.0_pre317203_p20180123.ebuild

Project Member

Comment 78 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9e40c1f688e6f54ee92c40026ecafc5c6c92c561

commit 9e40c1f688e6f54ee92c40026ecafc5c6c92c561
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed Jan 24 20:53:26 2018

generic_stages: temporarily ignore all target prebuilts.

Ignore the target prebuilts and rebuild packages from source.

This is a temporary CL.  Revert this CL once in has participated in
a green CQ run.  This process is documented at:

https://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/clear_binaries

BUG= chromium:724628 
TEST=Tested with bob-paladin (rebuilt packages). Unittests pass.

Change-Id: Id5a4086600935363c6a1e9169c4723c2d73931de
Reviewed-on: https://chromium-review.googlesource.com/867671
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/9e40c1f688e6f54ee92c40026ecafc5c6c92c561/cbuildbot/config_dump.json
[modify] https://crrev.com/9e40c1f688e6f54ee92c40026ecafc5c6c92c561/lib/sysroot_lib.py
[modify] https://crrev.com/9e40c1f688e6f54ee92c40026ecafc5c6c92c561/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/9e40c1f688e6f54ee92c40026ecafc5c6c92c561/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/9e40c1f688e6f54ee92c40026ecafc5c6c92c561/lib/config_lib.py

Blockedon: 805657
Project Member

Comment 81 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/d7abf5d2e0a4b6f58000d56b1ae18cd682344273

commit d7abf5d2e0a4b6f58000d56b1ae18cd682344273
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Jan 25 01:47:47 2018

chroot_version_hooks.d: Clear host packages after libc++ migration.

All host packages using libstdc++ must be rebuilt post libc++ migration.
So update host packages by latest prebuilts.

BUG= chromium:724628 
TEST=`./update_chroot` rebuilds 71 host packages.

Change-Id: I1232fd51aed365f71a93ce4263ed5efb53d5ce27
Reviewed-on: https://chromium-review.googlesource.com/882949
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>

[add] https://crrev.com/d7abf5d2e0a4b6f58000d56b1ae18cd682344273/chroot_version_hooks.d/154_clean_sdk_post_libcxx

Project Member

Comment 82 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0558cca3a1a0518112ee113c3880eab0c5695bb7

commit 0558cca3a1a0518112ee113c3880eab0c5695bb7
Author: Manoj Gupta <manojgupta@chromium.org>
Date: Thu Jan 25 08:32:52 2018

Revert "generic_stages: temporarily ignore all target prebuilts."

This reverts commit 9e40c1f688e6f54ee92c40026ecafc5c6c92c561.

Reason for revert: CQ had a green run. Uploaded prebuilts.

Original change's description:
> generic_stages: temporarily ignore all target prebuilts.
>
> Ignore the target prebuilts and rebuild packages from source.
>
> This is a temporary CL.  Revert this CL once in has participated in
> a green CQ run.  This process is documented at:
>
> https://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/clear_binaries
>
> BUG= chromium:724628 
> TEST=Tested with bob-paladin (rebuilt packages). Unittests pass.
>
> Change-Id: Id5a4086600935363c6a1e9169c4723c2d73931de
> Reviewed-on: https://chromium-review.googlesource.com/867671
> Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
> Reviewed-by: Aviv Keshet <akeshet@chromium.org>
> Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
> Tested-by: Manoj Gupta <manojgupta@chromium.org>

Bug= chromium:724628 

Change-Id: I6a1c63ed54a00232dce27750a27fd48b09dcb80d
Reviewed-on: https://chromium-review.googlesource.com/886221
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Yong Hong <yhong@google.com>

[modify] https://crrev.com/0558cca3a1a0518112ee113c3880eab0c5695bb7/cbuildbot/config_dump.json
[modify] https://crrev.com/0558cca3a1a0518112ee113c3880eab0c5695bb7/lib/sysroot_lib.py
[modify] https://crrev.com/0558cca3a1a0518112ee113c3880eab0c5695bb7/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/0558cca3a1a0518112ee113c3880eab0c5695bb7/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/0558cca3a1a0518112ee113c3880eab0c5695bb7/lib/config_lib.py

Blockedon: 806013
Project Member

Comment 84 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/2ca9ec10243e39392d0b17cd2195fea3251a4106

commit 2ca9ec10243e39392d0b17cd2195fea3251a4106
Author: Manoj Gupta <manojgupta@google.com>
Date: Fri Jan 26 16:26:54 2018

chroot_version_hooks.d: Clear target packages post libc++ roll.

Detect and remove pakcages depending on libstdc++ from the boards.

BUG= chromium:724628 
TEST=./update_chroot removed packages depending on libstdc++.

Change-Id: I1b66a00b5396a693eae288ecc072e9641a9e33b4
Reviewed-on: https://chromium-review.googlesource.com/885246
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[add] https://crrev.com/2ca9ec10243e39392d0b17cd2195fea3251a4106/chroot_version_hooks.d/155_clean_boards_post_libcxx

Blockedon: 803280
Status: Verified (was: Started)
libc++ has been deployed since Jan 24.

Sign in to add a comment