New issue
Advanced search Search tips

Issue 724626 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Android Camera 1 and 2 color temperature broken

Project Member Reported by mcasas@chromium.org, May 19 2017

Issue description

Device name: Samsung Note 2
Tot #473230

Steps to reproduce:
(1) Go to https://beaufortfrancois.github.io/sandbox/image-capture/playground.html
(2) Move the color temperature slide
Nothing happens and it should.

 

Comment 1 by mcasas@chromium.org, May 19 2017

Cc: fbeaufort@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a3f0b33ece1d34d98041cc6e6e8fe651fc02878

commit 4a3f0b33ece1d34d98041cc6e6e8fe651fc02878
Author: Miguel Casas-Sanchez <mcasas@chromium.org>
Date: Fri May 19 22:24:52 2017

Image Capture: correct White Balance in Android Camera 1

This CL:
- decouples white-balance setting from auto white balance (it'll
 be enforced at the Blink level in subsequent patches, so it's lined
 up with UVC platforms, i.e. Linux/CrOs and Win).
- and corrects a color temperature that was wrongly set.

Bug:  724626 
Change-Id: I82d3ade5c753b64649ff35bed9fc175370cf932e
Reviewed-on: https://chromium-review.googlesource.com/510028
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473363}
[modify] https://crrev.com/4a3f0b33ece1d34d98041cc6e6e8fe651fc02878/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java

Comment 3 by mcasas@chromium.org, May 19 2017

Status: Fixed (was: Started)

Comment 4 by mcasas@chromium.org, May 20 2017

Status: Started (was: Fixed)
Summary: Android Camera 1 and 2 color temperature broken (was: Android Camera 1 color temperature broken)
Repurposing this bug for both Camera 1 and Camera 2 APIs.

Comment 5 by mcasas@chromium.org, May 20 2017

Fix for camera 2 WIP in https://crrev.com/c/509963/
Project Member

Comment 6 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca8f393a777bb351dc49a7b3f1303448e4b343d3

commit ca8f393a777bb351dc49a7b3f1303448e4b343d3
Author: Miguel Casas-Sanchez <mcasas@chromium.org>
Date: Mon May 22 19:41:33 2017

Image Capture: correct White Balance for Android Camera 2

This CL follows the previous one on the same bug:
- decouples white-balance setting from auto white balance (it'll
 be enforced at the Blink level in subsequent patches, so it's lined
 up with UVC platforms, i.e. Linux/CrOs and Win).
- corrects a few color temperatures that were wrongly set, and
 also fixes this value in Camera 1 -- the names do no correspond
 to particular colour temperatures so I'm setting on what a
 Pixel and a Samsung agree upon.
- simplified the colorTemperature step to 50 and aligned the
 values to that boundary, in both Camera 1 and 2, since a step 
 of 1 doesn't make any sense given the steps at hand.


Bug:  724626 
Change-Id: Ia2a92340c051d6f82c9950def1a262b8d0ae149f
Reviewed-on: https://chromium-review.googlesource.com/509963
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473658}
[modify] https://crrev.com/ca8f393a777bb351dc49a7b3f1303448e4b343d3/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
[modify] https://crrev.com/ca8f393a777bb351dc49a7b3f1303448e4b343d3/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java

Comment 7 by mcasas@chromium.org, May 23 2017

Labels: Merge-Request-59
Project Member

Comment 8 by sheriffbot@chromium.org, May 23 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by mcasas@chromium.org, May 23 2017

Status: Fixed (was: Started)
Labels: -Merge-Review-59 Merge-Rejected-59
We're too late for Pri-3's for new features - let's fix for 60.

Sign in to add a comment