New issue
Advanced search Search tips

Issue 724609 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update args in diagnose_bloat.py for supersize archive command

Project Member Reported by estevenson@chromium.org, May 19 2017

Issue description

We shouldn't need to detect the --tool-prefix in both diagnose_bloat.py and supersize.
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f864feddcefe57485bccde9bec8145bef68c5a5d

commit f864feddcefe57485bccde9bec8145bef68c5a5d
Author: Eric Stevenson <estevenson@chromium.org>
Date: Thu May 25 18:49:27 2017

diagnose_bloat.py: fix supersize command args.

This CL removes tool prefix detection since this is already done in
supersize.

Also, we only pass --no-source-paths to --cloud builds since the
required files aren't archived (and we avoid doing a gclient sync since
builders now store .size files directly anyways).

Also update supersize to handle stale build_vars.txt files (so that we
don't try to use a tool location that doesn't exist).

Bug:  724609 
Change-Id: Ia0536492fc94bd614f3385a9564a280f704512dd
Reviewed-on: https://chromium-review.googlesource.com/512943
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474726}
[modify] https://crrev.com/f864feddcefe57485bccde9bec8145bef68c5a5d/tools/binary_size/diagnose_bloat.py
[modify] https://crrev.com/f864feddcefe57485bccde9bec8145bef68c5a5d/tools/binary_size/libsupersize/paths.py

Status: Fixed (was: Assigned)

Sign in to add a comment