New issue
Advanced search Search tips

Issue 724604 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

gsutil.py sometimes fails in diagnose_bloat.py

Project Member Reported by estevenson@chromium.org, May 19 2017

Issue description

gsutil.py cp 'gs://chrome-perf/Android Builder/full-build-linux_3994a55ffa417d2f7065742b47b24c468cbfa76f.zip'  .
Traceback (most recent call last):
 File "../depot_tools/gsutil.py", line 160, in <module>
   sys.exit(main())
 File "../depot_tools/gsutil.py", line 157, in main
   clean=args.clean)
 File "../depot_tools/gsutil.py", line 125, in run_gsutil
   gsutil_bin = ensure_gsutil(force_version, target, clean)
 File "../depot_tools/gsutil.py", line 119, in ensure_gsutil
   raise InvalidGsutilError()
__main__.InvalidGsutilError
 
Description: Show this description
Cc: hinoka@chromium.org
+hinoka - let me know if there's a better place to ask this.

Any idea how/why one might hit this error? The comment for this line says: "This should never fail.". 

IIRC the default location to store depot_tools is in ~/lib/depot_tools, right?. Could conflicting versions on a machine cause this?

Comment 3 by hinoka@chromium.org, May 23 2017

That's weird.  Can you tar up your depot_tools/external_bin, post it here, delete the folder, then run the command again?
Owner: jyasskin@chromium.org
jyasskin@ - any chance you'd like to try c#3 when you get a chance?
Owner: estevenson@chromium.org
https://drive.google.com/a/google.com/file/d/0B0IA_MC_Ul5KS3lFRlRobUVpV0k/view?usp=sharing is the tarfile. After deleting external_bin, the gsutil.py command at the top works.
Cool, thanks for verifying!

I'll add a check to diagnose_bloat.py to verify gsutil is in a working state before doing any work. 
Project Member

Comment 7 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b60ccfb7c7c5769005610e94c602dbbbf5f4616

commit 4b60ccfb7c7c5769005610e94c602dbbbf5f4616
Author: Eric Stevenson <estevenson@chromium.org>
Date: Wed May 24 18:22:55 2017

diagnose_bloat.py: check for working gsutil.py.

This CL adds a check to verify that gsutil.py is in a working state
before trying any other commands. The added error message will make
debugging future issues easier.

Bug:  724604 
Change-Id: I5e8c21cb3a13345dc669c95bfc9122d8eac3f4a1
Reviewed-on: https://chromium-review.googlesource.com/514162
Reviewed-by: F . <zpeng@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474360}
[modify] https://crrev.com/4b60ccfb7c7c5769005610e94c602dbbbf5f4616/tools/binary_size/diagnose_bloat.py

Status: Fixed (was: Assigned)

Sign in to add a comment