Test.disableAnimationsAndTransitions uses /deep/ in CSS rules. |
||||||
Issue descriptionSee https://cs.chromium.org/chromium/src/chrome/test/data/webui/test_api.js?l=55,59. /deep/ in CSS selectors is about to be removed at issue 489954 . We should figure out if disableAnimationsAndTransitions() needs to be completely removed or updated in some equivalent way but without using /deep/.
,
Jun 7 2017
+rbpotter as FYI, since one of those tests is print_preview_ui_browsertest.js
,
Jun 7 2017
Fix candidate at https://codereview.chromium.org/2927663003/.
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2deb8c3767fbb87c7fac334eda0624bc838903df commit 2deb8c3767fbb87c7fac334eda0624bc838903df Author: dbeam <dbeam@chromium.org> Date: Thu Jun 08 00:38:36 2017 Fix Test.disableAnimationsAndTransitions to work with new /deep/ R=hcarmona@chromium.org BUG=724597 Review-Url: https://codereview.chromium.org/2927663003 Cr-Commit-Position: refs/heads/master@{#477834} [modify] https://crrev.com/2deb8c3767fbb87c7fac334eda0624bc838903df/chrome/test/data/webui/test_api.js
,
Jun 8 2017
It's worth noting that the previous code would apply for all elements that are created during the lifetime of the test. Whereas the current solution will only affect elements that are already in the DOM. I don't know if we plan to address this (or defer until it proves to be an issue).
,
Jun 8 2017
right, potential ways to do do this would be 1) listen for dom-change events (for polymer code, assuming they're on) 2) use a MutationObserver
,
Jun 8 2017
MutationObserver observes a single HTMLElement and only reports DOM changes of its immediate children AFAIK.
,
Jun 8 2017
,
Jun 8 2017
yeah, sorry, you're right: I thought childList was recursive.
,
Jun 30 2017
,
Dec 12 2017
This is a no longer blocking issue. /deep/ and ::shadow were removed at M63.
,
Jul 20
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dpa...@chromium.org
, Jun 7 2017