New issue
Advanced search Search tips

Issue 724585 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR

Blocked on:
issue 728148

Blocking:
issue 719661



Sign in to add a comment

Allow CCT to be launched in VR from an intent.

Project Member Reported by mthiesse@chromium.org, May 19 2017

Issue description

If CCT is launched with a VR intent, and the flag for enabling CCT in VR is set, we should launch CCT in VR.

We should *not* autopresent webVR in this case for security reasons, instead showing the browser UI expected of CCT.
 
Cc: -ymalik@chromium.org
Owner: ymalik@chromium.org
Mind taking this Yash? Will be much easier after https://codereview.chromium.org/2873843002/ lands. Should be pretty trivial hopefully and would allow us to get feedback in M60 for what VR CCT users want.

Comment 2 by ymalik@chromium.org, May 23 2017

Yeah, I can pick this up. Will probably get to it later today or tomorrow.

Comment 3 by ymalik@chromium.org, May 24 2017

Components: UI>Browser>VR
Status: (was: Available)

Comment 4 by ymalik@chromium.org, May 24 2017

Status: Started

Comment 5 by ymalik@chromium.org, May 24 2017

Status: Available (was: Started)

Comment 6 by ymalik@chromium.org, May 25 2017

This is not super trivial because the VrShellDelegate.onNewIntent function that https://codereview.chromium.org/2873843002/ introduces only works for CTA and not CCT. It gets called every time we get a "new" CTA intent so that we can auto-present if required. 

If we want to enter VR for CCT VR intents, we will need to find the right place to call VrShellDelegate.onNewIntent in the CCT case. Note that VrShellDelegate.onNewIntent, should only be called when we actually get a new intent (e.g. shouldn't be called when you switch away from chrome using task switcher, then back to chrome because we don't want to auto-present in this case).

Comment 7 by ymalik@chromium.org, May 26 2017

Blocking: 719661
Blockedon: 726590
Labels: -Pri-1 -M-60 M-61 Pri-2
 Issue 726590  may affect how things work, so we should address it first.
Blockedon: -726590
Blockedon: 728148
Owner: mthiesse@chromium.org
Labels: -M-61 M-62
Labels: -M-62
M62 feature freeze has already gone by. Is this something we want to do in M63? It should be fairly straightforward, engineering-wise, but PMs are probably pretty busy :P
Labels: VRB-Next-Triage
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385

commit 6c5ebd4660dc55d441ff0fa49efdc1c3170a3385
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Mon Jul 09 18:34:33 2018

VR: Remove experimental VR Browsing in CCT support.

This has been sitting behind a flag for, like, ever and we have no
plans to launch it. If that ever changes we can re-land this code.

Bug:  724585 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If29a5aca5d5aca885fbbe76fba1790f234618249
Reviewed-on: https://chromium-review.googlesource.com/1128166
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573375}
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/about_flags.cc
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/android/vr/vr_gl_thread.cc
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/android/vr/vr_gl_thread.h
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/android/vr/vr_shell.cc
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/android/vr/vr_shell.h
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/vr/elements/content_element_unittest.cc
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/vr/elements/text_input_unittest.cc
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/vr/model/model.h
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/vr/test/mock_ui_browser_interface.h
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/vr/test/ui_test.cc
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/vr/test/ui_test.h
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/vr/testapp/vr_test_context.h
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/vr/ui.cc
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/vr/ui.h
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/vr/ui_browser_interface.h
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/vr/ui_input_manager_unittest.cc
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/vr/ui_pixeltest.cc
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/6c5ebd4660dc55d441ff0fa49efdc1c3170a3385/chrome/browser/vr/ui_unittest.cc

Status: Assigned (was: Available)
Owner: ----
Status: Available (was: Assigned)

Comment 18 by samdrazin@chromium.org, Jan 17 (6 days ago)

Status: WontFix (was: Available)
VRB team triage deciding to close because: unclear of next steps (and closed umbrella bug issue:719661)

Sign in to add a comment