If CCT is launched with a VR intent, and the flag for enabling CCT in VR is set, we should launch CCT in VR.
We should *not* autopresent webVR in this case for security reasons, instead showing the browser UI expected of CCT.
Mind taking this Yash? Will be much easier after https://codereview.chromium.org/2873843002/ lands. Should be pretty trivial hopefully and would allow us to get feedback in M60 for what VR CCT users want.
This is not super trivial because the VrShellDelegate.onNewIntent function that https://codereview.chromium.org/2873843002/ introduces only works for CTA and not CCT. It gets called every time we get a "new" CTA intent so that we can auto-present if required.
If we want to enter VR for CCT VR intents, we will need to find the right place to call VrShellDelegate.onNewIntent in the CCT case. Note that VrShellDelegate.onNewIntent, should only be called when we actually get a new intent (e.g. shouldn't be called when you switch away from chrome using task switcher, then back to chrome because we don't want to auto-present in this case).
M62 feature freeze has already gone by. Is this something we want to do in M63? It should be fairly straightforward, engineering-wise, but PMs are probably pretty busy :P
Comment 1 by mthiesse@chromium.org
, May 19 2017Owner: ymalik@chromium.org